Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u94H3-00F22S-Ny for pgsql-committers@arkaria.postgresql.org; Sun, 27 Apr 2025 15:50:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u94H1-009ZSF-Ud for pgsql-committers@arkaria.postgresql.org; Sun, 27 Apr 2025 15:50:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u94H1-009ZS7-KE for pgsql-committers@lists.postgresql.org; Sun, 27 Apr 2025 15:50:32 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1u94Gy-002LlR-3D for pgsql-committers@lists.postgresql.org; Sun, 27 Apr 2025 15:50:31 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-39141ffa9fcso4628383f8f.0 for ; Sun, 27 Apr 2025 08:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bowt-ie.20230601.gappssmtp.com; s=20230601; t=1745769028; x=1746373828; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v9HiUIXsbWaFTOCFkNXsMnWcAllM1ymcSQRksDbfIVc=; b=d3nYCa5ZYm0rvgI4qSz0Vh++VgoKWqeLWx+R4IpAPctq0oemO8p1SBnin5sIbtpzWn ge2XMCPNCJsgziiv8QGmFapyLnSM9hxtRbSERKPoa5y4j4VDARB5uN4ss9j1aXZOVAQ+ z4VclFmx0mYL3ljMnCtL5LZijE3iYLdj/+q0djA10rwhm1LJWiYJzLq2wq1o8SrWa2kZ 1YQvEN+Ib/W9J23nyq4v3oflm3SzDmDy3OE9tHZqbWvPfZAIg9lA+qHKMGmFinqLD78a uxfcjCzxZPSopBHCIExV1ZqOagWEtfJmiXKVtxEG0SLpLZgabORxqRV7x2ZkdKsgBcGc nzpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745769028; x=1746373828; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v9HiUIXsbWaFTOCFkNXsMnWcAllM1ymcSQRksDbfIVc=; b=vlNJohFsAelDost3KtMffx1uCyJX8d4Uz9LEFGIGCswks1TOB8IaVxfCChMiFWkDM2 swz1/mGK0PGwU9WoigJhry49sjmso2BE5jVE10Sit908YDiLhNFGygIODsmMV2B6LZJl shN86BBjIhyN9Mu5r1mPN8RspxwVKXX4BFHAh1izsFEyUtG9Em4yQBEXRqV9gZYe7hTn /fap95bPVWiID/WuPhT5qA7xZz0jMBX9Bd6sdKhdS/bII/Kr+6IGBR7CKDdzmwoNEmYB gtThzdutr2SIjHaU5TAPcOGsg+kiPFte3KtWxhh8KqdGJt7lU2iuiDtw2ky9KhLPLNrJ 3uOQ== X-Forwarded-Encrypted: i=1; AJvYcCWEYtCJUhyaoqKz3DQKkZ6xKEbGe6Ln158HaN4Nq/lOIPlG8KYygAn8cF0ymHZixrdiWQYLlQ7KjS+0obTnfV3W@lists.postgresql.org X-Gm-Message-State: AOJu0YyXAvqj7kgsQiAm/39X0/B2Yl7ND7C8bblKl2lvsyPEYiyzs5hY pBl+KbEsQwhy9/l7FOpuP5JDOfW4qxMlWhYpeK6Qg9segsvQicoLAmIbaYH8RVhHP7lsbfCIdBx yxm6sF76o6Fs3DPFsJnsqqjhfFEW7Nwc+iHgPTA== X-Gm-Gg: ASbGncvG0IAI34csv+WMrlJE2Aoo3R8F/DIQwJtmVJ52EWQMNkGivNHa8zfZ4vLe5Qg nx2GNtVe98O4Uzlea0PRYqI2MjwB7iyX6ZxzXIBuhJ93Dp54+UMxiNOBVccaand6EMyGa7ksVgT Ef68eBxhemZbwtx3RFQdbD6w== X-Google-Smtp-Source: AGHT+IGT16s0JHe+EJRqJcUWQLXfzcvULAqKGEjTHP4wSv2pAh3m1YfmhKsWzUL6Lohl4Hsnt41E6Ff+/2sc468o/8g= X-Received: by 2002:a05:6000:2481:b0:39f:6d3b:f136 with SMTP id ffacd0b85a97d-3a074f10c98mr6520547f8f.41.1745769028512; Sun, 27 Apr 2025 08:50:28 -0700 (PDT) MIME-Version: 1.0 References: <362183.1744475715@sss.pgh.pa.us> <367395.1744478199@sss.pgh.pa.us> In-Reply-To: From: Peter Geoghegan Date: Sun, 27 Apr 2025 11:50:02 -0400 X-Gm-Features: ATxdqUHsy3RL7QQhYM12-ZuZJMLcYOhr4d6XIymDGdppqSwt7AbCY0Pz45QwUKw Message-ID: Subject: Re: clang-tidy complaints To: Bertrand Drouvot Cc: Tom Lane , pgsql-committers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, Apr 27, 2025 at 4:25=E2=80=AFAM Bertrand Drouvot wrote: > +1. Peter, do you think you could add "misc-header-include-cycle" in your > annual check (see [1])? I'll also put a note on my side to do it at a reg= ular > basis. I've added it to my personal clangd config (I mostly use clang-tidy through clangd). I'll try to remember to use it when I run clang-tidy a year from now, to clean up the master branch at the end of the Postgres 19 cycle. --=20 Peter Geoghegan