public inbox for [email protected]  

help / color / mirror / Atom feed

From: Mark Dilger <[email protected]>
To: Peter Geoghegan <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Improve nbtree skip scan primitive scan scheduling.
Date: Sun, 27 Apr 2025 10:06:22 -0700
Message-ID: <CAHgHdKuWD2h3n6MHv2SOp8VLcKsKM1R+tLBHZrnE_WDOmDaqPg@mail.gmail.com> (raw)
In-Reply-To: <CAH2-Wz=1eJZMSMoACDW2oLcxd8QUtKQS7HuYtqx98LLji+WKuQ@mail.gmail.com>
References: <[email protected]>
	<CAHgHdKtLFWZcjr87hMH0hYDHgcifu4Tj7iHz-xh8qsJREt5cqA@mail.gmail.com>
	<CAH2-Wz=1eJZMSMoACDW2oLcxd8QUtKQS7HuYtqx98LLji+WKuQ@mail.gmail.com>

On Sat, Apr 26, 2025 at 8:53 PM Peter Geoghegan <[email protected]> wrote:

> On Sat, Apr 26, 2025 at 10:39 PM Mark Dilger
> <[email protected]> wrote:
> > Peter, Matthias, thanks kindly for the good work on skipscans!
>
> Thanks!
>
> > I found a test case which fails after commit
> 21a152b37f36c9563d1b0b058fe1436baf578b4c.  Please find a reproducible test
> case, attached.
>
> The bug isn't actually in commit
> 21a152b37f36c9563d1b0b058fe1436baf578b4c -- it's just an accident that
> the mechanism added by that commit happens to make your test case
> fail. The underlying issue was introduced in commit 8a510275, "Further
> optimize nbtree search scan key comparisons".
>
> This looks to have been a silly oversight in our handling of NULL
> tuple datums within _bt_check_compare. Attached provisional fix makes
> your test case pass.
>
> --
> Peter Geoghegan
>

I can confirm that your patch fixes the problem, having spent some four
hours trying to find other test cases which still fail, finding none.

Thank you for the quick reply, and again for the work on btree.

-- 
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Improve nbtree skip scan primitive scan scheduling.
  In-Reply-To: <CAHgHdKuWD2h3n6MHv2SOp8VLcKsKM1R+tLBHZrnE_WDOmDaqPg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox