Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uCc7R-00HROC-I3 for pgsql-committers@arkaria.postgresql.org; Wed, 07 May 2025 10:35:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uCc7P-00DNUq-Nj for pgsql-committers@arkaria.postgresql.org; Wed, 07 May 2025 10:35:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uCc7P-00DNUh-FU for pgsql-committers@lists.postgresql.org; Wed, 07 May 2025 10:35:15 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uCc7N-000ZiG-01 for pgsql-committers@lists.postgresql.org; Wed, 07 May 2025 10:35:14 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-2c76a1b574cso2107459fac.2 for ; Wed, 07 May 2025 03:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timescale.com; s=google; t=1746614113; x=1747218913; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LzdUPtnHm3+LxHXRy3uesYzofRYBQ/GpBAMaLfLcPKg=; b=mI3UITkBcqg3wWXD28LrcJhO6ta5olN7gp2+bIWzNUFOnhI+yxOeO0WLvVeVmKMVvw fuvu0uspvN+3kDwYoz1gbWWBeAwrNyjU1hd1ntNXVShlkOl9DQre0n/tH8ylK6ZvsDZ/ yaUJtuLSIi4j8O8G3ZGxD76M0tx3HcwlMYa8R9frVjhWnYtLI1W/cEgDNZK0FmlsqvdW Z439xA1ZMh7fAaYjoadsAXa+00E9XV3BZEmn016crLUieu5rTreUBveDEHwlYoVJySg/ vz56y69uXaEHOhfJH1qq1RwNr37oi0tzcM9mpggAp3rqeFGVVnmuMpjjhLNycQhn5w1C PooQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746614113; x=1747218913; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LzdUPtnHm3+LxHXRy3uesYzofRYBQ/GpBAMaLfLcPKg=; b=nS5bOJsR1Diw0W4qwTsnNLXYJm58NhY5qf3iOj7YBtC/8nxRRq28xzAtpsvNqz42AG B47+gAqUrF0E7dMeszhPgMo6HSekbQth5OBIzaHGiaPPBFOnuDKJsh7GpoYRb3MDTHjI aqpZBtpS3ouXvYQ2qo8G+T3eUlH4KT6W2rkriVqfGfVscNPMA2EbrJ4lLNQdf6/tTwYk ZOE9XSz6MthWXYYaJb8zpKspYzU93GniDxpITYk8fLWT9f6sXNUJdRNt1ltl4KUerawy Brw2WXcosqHOPxIS/HfUauDzkgPyLHdDc+W1Q0G4tYS0GdZTGwpiyW32opAN8WSYPM8u O6ZQ== X-Gm-Message-State: AOJu0YxJSSCiVCpykB3OiMFjOaAppLnFCKdoDunZrTP7s3FKQ+86n4s0 RQ8+1KJiYKZ1pOp11q9MwGYb092XmHB8wiGy7g3rvVeHInpclnt9mfsEDhweoHL/6kQuL1oiL5i gH5Urb+hkGz+O8oRBYlQMspuCp0PANE5N5/z/Y3YUaIOgbvOtsEw= X-Gm-Gg: ASbGnct/Dj2IyK9AzcOAO+wGplniChqLaNnoRnNjAaKnKinUD2yUkTp2RPw//VdTkhf lO26lHJiOa0uSfcDKHmQkk00aOVWijAP4LfO+e3okcvfEQBzXqi+Bk8TKBYRZ1CmfyWjZJHfWLH ynAQqBBzKCnjeXPqOVpw3L X-Google-Smtp-Source: AGHT+IHNL9kgM6O0OYFAWiQah9biUfZklKfPpt4cR2hJH9OlPiQoQAp+E/7GphDiWj6DOruO5triDuDWrAf41NCuq1E= X-Received: by 2002:a05:6870:2007:b0:29e:766d:e969 with SMTP id 586e51a60fabf-2db5be0e345mr1543140fac.10.1746614112750; Wed, 07 May 2025 03:35:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aleksander Alekseev Date: Wed, 7 May 2025 13:35:01 +0300 X-Gm-Features: ATxdqUEWH0B9AaN3IPe7MqcG8mTuSqsMGq4Sppns1wzEuSu5aH2mp-q2RROP0XU Message-ID: Subject: Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback To: pgsql-committers@lists.postgresql.org Cc: Alexander Korotkov , Alexander Korotkov Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, > OK, now I get your point: you think this should go to the next major > release. But no, it's not. It's intended to eventually land into > REL_18_STABLE, REL_18_BETA2 etc. It addresses one of PG18 Open Items: > Richard Guo found the way SJE changes ChangeVarNodes() unsatisfiable, > and this commit is intended to fix that. Also, note that it is not > the only PG18 Open Item left after beta1, and fixing Open Items > usually requires changes besides docs and whitespaces. Now I get it. From the commit message it looked like a regular refactoring. I didn't realize it fixes an open item. Many thanks! -- Best regards, Aleksander Alekseev