Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyzyF-0003xa-MI for pgsql-committers@arkaria.postgresql.org; Tue, 16 May 2023 19:04:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pyzyD-0008Ra-8t for pgsql-committers@arkaria.postgresql.org; Tue, 16 May 2023 19:04:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyzyD-0008RR-12 for pgsql-committers@lists.postgresql.org; Tue, 16 May 2023 19:04:25 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pyzy9-000C7h-1p for pgsql-committers@lists.postgresql.org; Tue, 16 May 2023 19:04:24 +0000 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2ac80da3443so157453281fa.0 for ; Tue, 16 May 2023 12:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684263860; x=1686855860; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CwOzN688znhTFt115AtYrqDLbVkfJNQjvpNXQm2+hUw=; b=nWLoe415w8vT3TMFtze613wPN2ptB69pEVrsab4zmgC4C7JwWNGYB+MMR+6jUm2GUV QmSbNHIuHbVHVJTodmXMPrVARJqshOnSqjQzHydPaIeUJax3AvkaNJMVgpJIZR/Qhjj0 61b51kkD72EYm2aszwr19KZvQxUM3fqqgxLSqFaqncBqfBK5vrAhX4p41Zmjv5hHszkL EyyF8GgDfzWx/nV0ticVoBYnOuulbnOtNMhps4yrFvps282RvsEsUaK8QsctBEuDThMJ Atjd9zboUTUgUpmr8613v9z498q6rL7OK71aiFjVbScdRsJHDxHEIgntBiVgFDCS6gIK gPGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684263860; x=1686855860; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CwOzN688znhTFt115AtYrqDLbVkfJNQjvpNXQm2+hUw=; b=WYa8hzNWSsArbIDk5f77WWCZB10lVjtO3eLHjPIngmiHr29c5sRIKk0FmGCq4SLOca SYDYejTlmrVMmGNPQi+yuu0BjO7ASfMZWbG1WZqdcf1r5ztP84FcDhlqdBOclqlcJpRS QMU7dI7Zo5+3XQD5jyNTS96vQMNAvtNGRwMMnjRizPPWgdv4ZDw38BpYbg9hxiycKV05 pOA0YDYFUZZJMzshFE0rWyxCCXc5sTeT4LhsBsxVnhgTZP3g7oaCUaXXP5sDYbxhX2rn Agr0a0TC7LbV2CmHURUM8+4NvdO9UR5FZ0TRaBdpPmJnScwK+ZPRp5bRc8QzkNnkC46d 5N7A== X-Gm-Message-State: AC+VfDyUnwX+C8olfuZ08SnPKuONtZJGywIENAI8AhRNAPCnmdQxm5jO QznVyfnrPR/lJ6f8uIDptVcQUm2kOhSEFfYq5phgtoJTJIyW/Q== X-Google-Smtp-Source: ACHHUZ4XPUX8y3BGXtVC6i/KEETbgdjmKkNf9NoWb7voGGxAF6OU7X9zvGP9hF86pO9PurjZReKUbdZvJcpIgifjDSU= X-Received: by 2002:a2e:90cb:0:b0:29b:d2f1:de9b with SMTP id o11-20020a2e90cb000000b0029bd2f1de9bmr9640939ljg.47.1684263860061; Tue, 16 May 2023 12:04:20 -0700 (PDT) MIME-Version: 1.0 References: <34800305-E1E6-4194-8738-9977946DB12A@postgresql.org> In-Reply-To: <34800305-E1E6-4194-8738-9977946DB12A@postgresql.org> From: Damir Belyalov Date: Tue, 16 May 2023 22:04:08 +0300 Message-ID: Subject: Re: pgsql: Refactor background psql TAP functions To: Daniel Gustafsson Cc: Peter Eisentraut , pgsql-committers@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000164adb05fbd43de6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000164adb05fbd43de6 Content-Type: text/plain; charset="UTF-8" Hello! There is another perl module: AdjustUpgrade.pm that is not in Makefile. Do we need it? $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/RecursiveCopy.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/RecursiveCopy.pm' $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Cluster.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm' $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm' + $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm' $(INSTALL_DATA) $(srcdir)/PostgreSQL/Version.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm' uninstall: @@ -32,6 +33,7 @@ uninstall: rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/RecursiveCopy.pm' rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm' rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm' + rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm' rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm' Regards, Damir Belyalov Postgres Professional --000000000000164adb05fbd43de6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello!

Ther= e is another perl module: AdjustUpgrade.pm that is not in Makefile. Do we n= eed it?

=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(INSTALL_= DATA) $(srcdir)/PostgreSQL/Test/RecursiveCopy.pm '$(DESTDIR)$(pgxsdir)/= $(subdir)/PostgreSQL/Test/RecursiveCopy.pm'
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Cluster.pm '$(DESTDIR)$(p= gxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.pm '$(D= ESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm'
+ =C2= =A0 =C2=A0 =C2=A0 $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.= pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'= ;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $(INSTALL_DATA) $(srcdir)/PostgreSQL/Versi= on.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm'
=C2= =A0
=C2=A0uninstall:
@@ -32,6 +33,7 @@ uninstall:
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Rec= ursiveCopy.pm'
=C2=A0 =C2=A0 =C2=A0 =C2=A0 rm -f '$(DESTDIR)$(pg= xsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Background= Psql.pm'
+ =C2=A0 =C2=A0 =C2=A0 rm -f '$(DESTDIR)$(pgxsdir)/$(su= bdir)/PostgreSQL/Test/AdjustUpgrade.pm'
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm'
<= div>

Regards,
Damir Belyalov
Postgres Professional
--000000000000164adb05fbd43de6--