Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruoXn-007oFG-LQ for pgsql-committers@arkaria.postgresql.org; Thu, 11 Apr 2024 07:08:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ruoXm-00EKMZ-EO for pgsql-committers@arkaria.postgresql.org; Thu, 11 Apr 2024 07:08:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruoXm-00EKMQ-70 for pgsql-committers@lists.postgresql.org; Thu, 11 Apr 2024 07:08:22 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1ruoXk-000KnX-Cd for pgsql-committers@lists.postgresql.org; Thu, 11 Apr 2024 07:08:21 +0000 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2d4886a1cb4so89314761fa.0 for ; Thu, 11 Apr 2024 00:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712819299; x=1713424099; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1RI6xDhKtKpJhZBhu8Qe4ZHkhlwyWcg7NjWDfPbALNU=; b=QXjMKUQMEduANGyrtU5vf+BgH7RrdTonJL5E7/i2wnbFdZub4mBbp5NTNH21zUW5BE U0e1R2vaMLjj64H+uSs9UTnV/epawsU3X6RUn8RfGzdFMU5M6kVY6OQ0cXmCUkuiZQgP q6UerS48krEsjNV/Z4bpdn14Alr/0NyAILhBDfoS3/rx/C7LjKc3ckFw27fL2APZsuCk ITv4LtD4m3iPkxXOsAYq5+EqscLfgx9MMLcFWfThY3JazEWZpr7r3w8dKxWR4Typ2YFa k5ZPtHq1akS6xeV2rQcdch2bZJDavCc9WRsO98/xU9uz+WBRKyTCCUh6ysqpxGBFztou OgTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712819299; x=1713424099; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1RI6xDhKtKpJhZBhu8Qe4ZHkhlwyWcg7NjWDfPbALNU=; b=qwPwPwgVnSBk+o/vRRopvwWV2GIWACszsfpRWhSiphC2myvSlPqFSyFnq7ucLrp56w zD+HCPS1WHfiOJP111DVYNMbGfRaqUDDIzZfY7gqNkv8Ji5zKCO9/AgNExaNXEZVNNM4 wN/9OdsKiyWSwtKC6hnR/ibHU5W5eOXsEleRgoSFLdw3qAFdznGfq1Nd1YdtCSzZD8qz maSksOgND9yltwf9hOvF40xKcf4RY2Fxe8zUe9VzOHlHodEclCDC6eHNc6cdkQrKw6P/ DF6kdX9QOPQJg7IXTq77oIDyBlkS9evM/1JC4uV2r0hMvxSLnjIL20+D+zAAZ0A4A9a9 YzEg== X-Gm-Message-State: AOJu0YzCd2zjyqs2+S1Jy6ItQ51Y6lp+4tk9zUEyDDocSBQDqPYVR8F7 f/ZNY4w8b5S5q/rQ6Ika2MdS1vNsrFDOh50TADU7rafYqBcvU1h9QBJ/fogsdoCJHT5JoVYkWCf pvRRsb9z4anS2PSTK6i0EjLMvBKAtUlIe X-Google-Smtp-Source: AGHT+IFZlyy6alA5Rvjo3028HhA/wySAkb2pkpLiKNhHukVdMM2ddsU9LR/6n/eg7wpwOKBHPn0lWJ+ARH8ZRV/d1Bk= X-Received: by 2002:a2e:3313:0:b0:2d6:b98d:c868 with SMTP id d19-20020a2e3313000000b002d6b98dc868mr4249258ljc.14.1712819298642; Thu, 11 Apr 2024 00:08:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bharath Rupireddy Date: Thu, 11 Apr 2024 12:38:06 +0530 Message-ID: Subject: Re: pgsql: Fix race leading to incorrect conflict cause in InvalidatePossib To: Michael Paquier Cc: pgsql-committers@lists.postgresql.org Content-Type: multipart/mixed; boundary="000000000000dc4d640615ccd1e2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000dc4d640615ccd1e2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 20, 2024 at 10:14=E2=80=AFAM Michael Paquier wrote: > > Fix race leading to incorrect conflict cause in InvalidatePossiblyObsolet= eSlot() I found a typo with the code added by this commit - we've used XLogRecPtr/InvalidXLogRecPtr for xmins in place of TransactionId/InvalidTransactionId. Attached a patch to fix this. --=20 Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com --000000000000dc4d640615ccd1e2 Content-Type: application/octet-stream; name="v1-0001-Use-correct-datatype-for-xmin-variables-added-by-.patch" Content-Disposition: attachment; filename="v1-0001-Use-correct-datatype-for-xmin-variables-added-by-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luuwboti0 RnJvbSA3M2Y4NWNjNjM0ZDg1ZTgyZGM2Y2QzODk0NWM0OTJmYjAzODlmZTk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCaGFyYXRoIFJ1cGlyZWRkeSA8YmhhcmF0aC5ydXBpcmVkZHlm b3Jwb3N0Z3Jlc0BnbWFpbC5jb20+CkRhdGU6IFRodSwgMTEgQXByIDIwMjQgMDc6MDQ6MjggKzAw MDAKU3ViamVjdDogW1BBVENIIHYxXSBVc2UgY29ycmVjdCBkYXRhdHlwZSBmb3IgeG1pbiB2YXJp YWJsZXMgYWRkZWQgYnkgODE4ZmVmZDgKCi0tLQogc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vc2xv dC5jIHwgNCArKy0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0aW9uL3Nsb3QuYyBiL3NyYy9i YWNrZW5kL3JlcGxpY2F0aW9uL3Nsb3QuYwppbmRleCAzYmRkYWFlMDIyLi5jZWJmNDRiYjBmIDEw MDY0NAotLS0gYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9zbG90LmMKKysrIGIvc3JjL2JhY2tl bmQvcmVwbGljYXRpb24vc2xvdC5jCkBAIC0xNTQ1LDggKzE1NDUsOCBAQCBJbnZhbGlkYXRlUG9z c2libHlPYnNvbGV0ZVNsb3QoUmVwbGljYXRpb25TbG90SW52YWxpZGF0aW9uQ2F1c2UgY2F1c2Us CiAJaW50CQkJbGFzdF9zaWduYWxlZF9waWQgPSAwOwogCWJvb2wJCXJlbGVhc2VkX2xvY2sgPSBm YWxzZTsKIAlib29sCQl0ZXJtaW5hdGVkID0gZmFsc2U7Ci0JWExvZ1JlY1B0cglpbml0aWFsX2Vm ZmVjdGl2ZV94bWluID0gSW52YWxpZFhMb2dSZWNQdHI7Ci0JWExvZ1JlY1B0cglpbml0aWFsX2Nh dGFsb2dfZWZmZWN0aXZlX3htaW4gPSBJbnZhbGlkWExvZ1JlY1B0cjsKKwlUcmFuc2FjdGlvbklk IGluaXRpYWxfZWZmZWN0aXZlX3htaW4gPSBJbnZhbGlkVHJhbnNhY3Rpb25JZDsKKwlUcmFuc2Fj dGlvbklkIGluaXRpYWxfY2F0YWxvZ19lZmZlY3RpdmVfeG1pbiA9IEludmFsaWRUcmFuc2FjdGlv bklkOwogCVhMb2dSZWNQdHIJaW5pdGlhbF9yZXN0YXJ0X2xzbiA9IEludmFsaWRYTG9nUmVjUHRy OwogCVJlcGxpY2F0aW9uU2xvdEludmFsaWRhdGlvbkNhdXNlIGludmFsaWRhdGlvbl9jYXVzZV9w cmV2IFBHX1VTRURfRk9SX0FTU0VSVFNfT05MWSA9IFJTX0lOVkFMX05PTkU7CiAKLS0gCjIuMzQu MQoK --000000000000dc4d640615ccd1e2--