MIME-Version: 1.0
References: <E1qsBJZ-000l5A-FT@gemulon.postgresql.org>
In-Reply-To: <E1qsBJZ-000l5A-FT@gemulon.postgresql.org>
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Fri, 12 Jan 2024 07:28:26 +0530
Message-ID: 
 <CALj2ACVQoFXxFm2kCmhHcdM7DjA84_bOjoM8HVAKHbE+KrZ1uA@mail.gmail.com>
Subject: Re: pgsql: Add support event triggers on authenticated login
To: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CALj2ACVQoFXxFm2kCmhHcdM7DjA84_bOjoM8HVAKHbE%2BKrZ1uA%40mail.gmail.com>
Precedence: bulk

On Mon, Oct 16, 2023 at 5:49=E2=80=AFAM Alexander Korotkov
<akorotkov@postgresql.org> wrote:
>
> Add support event triggers on authenticated login

Hi, I'm seeing a compiler warning with CFLAGS -O3 but not with -O2.

In file included from dbcommands.c:20:
dbcommands.c: In function =E2=80=98createdb=E2=80=99:
../../../src/include/postgres.h:104:16: warning: =E2=80=98src_hasloginevt=
=E2=80=99 may
be used uninitialized in this function [-Wmaybe-uninitialized]
  104 |         return (Datum) (X ? 1 : 0);
      |                ^~~~~~~~~~~~~~~~~~~
dbcommands.c:683:25: note: =E2=80=98src_hasloginevt=E2=80=99 was declared h=
ere
  683 |         bool            src_hasloginevt;
      |                         ^~~~~~~~~~~~~~~

The configure command I used is ./configure --prefix=3D$PWD/inst/
CFLAGS=3D"-ggdb3 -O3" > install.log && make -j 8 install > install.log
2>&1 &:

CONFIGURE =3D  '--prefix=3D/home/ubuntu/postgres/inst/' 'CFLAGS=3D-ggdb3 -O=
3'
CC =3D gcc
CPPFLAGS =3D -D_GNU_SOURCE
CFLAGS =3D -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Werror=3Dvla -Wendif-labels
-Wmissing-format-attribute -Wimplicit-fallthrough=3D3
-Wcast-function-type -Wshadow=3Dcompatible-local -Wformat-security
-fno-strict-aliasing -fwrapv -fexcess-precision=3Dstandard
-Wno-format-truncation -Wno-stringop-truncation -ggdb3 -O3
CFLAGS_SL =3D -fPIC

The compiler version is:
gcc --version
gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

--=20
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com