Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1YvCN8-0007mq-WA for pgsql-hackers@arkaria.postgresql.org; Wed, 20 May 2015 22:21:55 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1YvCN8-0008Mk-H9 for pgsql-hackers@arkaria.postgresql.org; Wed, 20 May 2015 22:21:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1YvCN7-0008Me-6O for pgsql-hackers@postgresql.org; Wed, 20 May 2015 22:21:53 +0000 Received: from mail-la0-f48.google.com ([209.85.215.48]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1YvCN4-0004gT-Hz for pgsql-hackers@postgresql.org; Wed, 20 May 2015 22:21:52 +0000 Received: by labbd9 with SMTP id bd9so90417177lab.2 for ; Wed, 20 May 2015 15:21:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Sf1tDVflxueNi9Rah2S7jjdu3Q0n00iINKgEkDJaOUw=; b=JSiMnTAN6aLkQ0jReCreAnaOzcjlpz2ibnDg30QgHKHMbBUxo6vIUj7W9YPcH3lM03 YfQQUH6J5iM7u43//tdiSM6/24TBG9ExJf8gcpUA6Rb0jKO7AMf/nFuJT2DwE4J1LTXG P9P3Oaqm+gL4cqd5fDBMpyHkigxEZw6VovSHh3viDxl+3sdshqlYZoUWcFW6ZZeJm9WA pFuh79EZK5n2bzutpomtIXIamr56kfOiWLq1u5P2epd/a24KaFt7H/ybajeET0uyr11/ 9EpzjAsgK4zy5SsHgVxbW3qkvORurP+Y6b/2RmA4etsrVapP03DPRlTZ155RxY76/qUH NcJw== X-Gm-Message-State: ALoCoQlm4TkIHLN2LeIAz8kv7i2DlCj6Cr5BrYCWhOtfQnebcJNXhF5QMBD/T67vqFn3ATGSqe5Q MIME-Version: 1.0 X-Received: by 10.152.37.201 with SMTP id a9mr26910559lak.120.1432160509285; Wed, 20 May 2015 15:21:49 -0700 (PDT) Received: by 10.114.57.132 with HTTP; Wed, 20 May 2015 15:21:49 -0700 (PDT) In-Reply-To: References: <20150520215816.GI5885@postgresql.org> <20150520220911.GK5885@postgresql.org> Date: Wed, 20 May 2015 15:21:49 -0700 Message-ID: Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. From: Peter Geoghegan To: Alvaro Herrera Cc: Andres Freund , Pg Hackers Content-Type: multipart/mixed; boundary=089e013d17066b509e05168ada96 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --089e013d17066b509e05168ada96 Content-Type: text/plain; charset=UTF-8 On Wed, May 20, 2015 at 3:14 PM, Peter Geoghegan wrote: > I think you're right. The initial commit neglected to update that, and > only handled it from ProcessQuery(). So it works for PlannedStmts, not > raw parse trees. Attached patch fixes this. Thanks for the report. -- Peter Geoghegan --089e013d17066b509e05168ada96 Content-Type: text/x-patch; charset=US-ASCII; name="commandtag-bug.patch" Content-Disposition: attachment; filename="commandtag-bug.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i9xbawbi0 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3Rjb3AvdXRpbGl0eS5jIGIvc3Jj L2JhY2tlbmQvdGNvcC91dGlsaXR5LmMKaW5kZXggYTk1ZWZmMS4uOGZkNWVl OCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdGNvcC91dGlsaXR5LmMKKysr IGIvc3JjL2JhY2tlbmQvdGNvcC91dGlsaXR5LmMKQEAgLTE4OTgsNyArMTg5 OCwxNCBAQCBDcmVhdGVDb21tYW5kVGFnKE5vZGUgKnBhcnNldHJlZSkKIAl7 CiAJCQkvKiByYXcgcGxhbm5hYmxlIHF1ZXJpZXMgKi8KIAkJY2FzZSBUX0lu c2VydFN0bXQ6Ci0JCQl0YWcgPSAiSU5TRVJUIjsKKwkJCXsKKwkJCQlJbnNl cnRTdG10ICpzdG10ID0gKEluc2VydFN0bXQgKikgcGFyc2V0cmVlOworCisJ CQkJdGFnID0gIklOU0VSVCI7CisJCQkJaWYgKHN0bXQtPm9uQ29uZmxpY3RD bGF1c2UgJiYKKwkJCQkJc3RtdC0+b25Db25mbGljdENsYXVzZS0+YWN0aW9u ID09IE9OQ09ORkxJQ1RfVVBEQVRFKQorCQkJCQl0YWcgPSAiVVBTRVJUIjsK KwkJCX0KIAkJCWJyZWFrOwogCiAJCWNhc2UgVF9EZWxldGVTdG10Ogo= --089e013d17066b509e05168ada96 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --089e013d17066b509e05168ada96--