MIME-Version: 1.0
References: <E1tz8dY-001tOE-31@gemulon.postgresql.org>
 <CANWCAZYRbrAyUG29SyVZdamEaSfX0FG=TuyhMaGyqJhpdTN=vg@mail.gmail.com>
 <CANWCAZbA+sDBdSQFcyp_-1T-r5HKFMbLhjM0uwZWZNZ+T9R85A@mail.gmail.com>
 <CANWCAZZSxs3a1YRKehkgk2OHKbrVn+xZ+AWW8Co2R_f70NqqmA@mail.gmail.com>
 <3837990.1743423175@sss.pgh.pa.us> <3857592.1743426546@sss.pgh.pa.us>
In-Reply-To: <3857592.1743426546@sss.pgh.pa.us>
From: John Naylor <johncnaylorls@gmail.com>
Date: Tue, 1 Apr 2025 11:20:43 +0700
Message-ID: 
 <CANWCAZa7qLYyPAeNvkRJnGgAbsMWZzkzCyd318YoRabqps9TDA@mail.gmail.com>
Subject: Re: pgsql: Inline CRC computation for small fixed-length input on x86
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-committers@lists.postgresql.org,
	cookt@blackduck.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZa7qLYyPAeNvkRJnGgAbsMWZzkzCyd318YoRabqps9TDA%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 31, 2025 at 8:09=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I wrote:
> > What I conclude is that Red Hat hot-wired gcc to assume -msse4.2,
> > but they didn't hot-wire clang the same way.
>
> In confirmation of that: everything goes through fine if I manually
> add -msse4.2 to configure's choice of BITCODE_CFLAGS.  Not sure if
> that line of thought can lead to a usable solution, or if it's
> superior to messing with the attributes on relevant functions as
> you mooted upthread.

Thanks for doing additional legwork!

Since the broader issue is still up in the air, and we have
confirmation that the attributes will get the buildfarm green again,
I'll go do that now.

--=20
John Naylor
Amazon Web Services