Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riR3K-00H8bl-Hu for pgsql-committers@arkaria.postgresql.org; Fri, 08 Mar 2024 03:37:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1riR3I-009sG1-U2 for pgsql-committers@arkaria.postgresql.org; Fri, 08 Mar 2024 03:37:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riR3I-009sFt-N8 for pgsql-committers@lists.postgresql.org; Fri, 08 Mar 2024 03:37:45 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1riR3F-003Mk6-DP for pgsql-committers@lists.postgresql.org; Fri, 08 Mar 2024 03:37:44 +0000 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-51336ab1fb7so616967e87.1 for ; Thu, 07 Mar 2024 19:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709869060; x=1710473860; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KYkoiwbxtDP97Q2itxrY5vEwdztQKF5opai7MDNqzUc=; b=Szdx65MP00flh2BxH4aU7xUKnyXDd44hLQ4KDh5GsomRdObTc7nmM52eWRUESt3sQ0 9rkLqKqjn/oljYw0gYx6axxpXKLjlxCrB4Kmbx+h3NEYbb5K6FSjpFgNE7731+VH9Wkk dSVgVahKoGALbK+Yi7bftVdM1BnRpgjdwx++BYmKHrbDPSn49Rdp5/2aAbC34vHeGDVT xiR+1Z46dQhDruXcKPNIeT0PKRMa3gdl3d7vcfCaXg3SuG0m2wbh9DAAOhq5b6APtec3 xGatxpYdhnSnLAL/3AtdMzVb+VD+TrvJZXWPdRys4hSHNskfHTxV65SyWAhbsuANE56Y wPHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709869060; x=1710473860; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KYkoiwbxtDP97Q2itxrY5vEwdztQKF5opai7MDNqzUc=; b=RhugRxeea1OJ5H6YWEa+X7ACU1jD6HXYk7r8qVPchYF0KZm3LVjC9msmFcZr28iziX UuhaW4ruSp9WSwaTTYqn3Wf3PSCgH8Hcgbo1kntPcHxB3E/ESgZouSd9R3uG5ISQsC/9 p48Ek4ag61KwEYcT4F4cAg27j42kikIbgbYxThDgzzO4lnkavDMeXHHHe5Cw7wh2BkjG juTEMdj3BlBzvBG9JxIpg30iuEBuYa+6zNyxNLRaB2/Bfxrxyn5xMDTN6pJwIz8WZDjU 32WXH5Wl7ACSjeV68dym5Xd4BUKvmR0hAm0BF5DUTbdJ1xQY2r/yl+ScxJJYMijrHcwe cj5A== X-Forwarded-Encrypted: i=1; AJvYcCVGOkjnZXQ4Lkp5r2kBx/0ZG9dgxBnnMYMUVR/eTSFqzXPLjSUkKoV2gI216L1ufJejKvdndRRQUpNd6xrVSIRvxzftoSc3+BVeM1DkDGzYB4BG4ppH X-Gm-Message-State: AOJu0Ywkv0zV/HLp1dLC8ajdBexyNPj5ohYlNW/jvNTBSdX9qJAoM0ER XPIRXF12IczKWaP/WG/F+KVCbMTCiNs/E9dWfR8d+CBqLr0/bdxxsYNBBqp7MRwh/BA7aAUXMTn qrt4WgkDWmNfpWe/yjZtED3vjtCGoFEgS X-Google-Smtp-Source: AGHT+IHdtjL7FOovKUvIhmUXHFu0r9wqX3Jkaf/51QhQ1nYiHh7QxKp40imwtmoHI39nfPmUn/W4syRMwIC3zFIdsbk= X-Received: by 2002:ac2:5e31:0:b0:513:26fd:5c13 with SMTP id o17-20020ac25e31000000b0051326fd5c13mr2361414lfg.52.1709869060158; Thu, 07 Mar 2024 19:37:40 -0800 (PST) MIME-Version: 1.0 References: <202403070936.rjwhdy5k62lp@alvherre.pgsql> In-Reply-To: From: John Naylor Date: Fri, 8 Mar 2024 10:37:29 +0700 Message-ID: Subject: Re: pgsql: Add template for adaptive radix tree To: David Rowley Cc: Alvaro Herrera , Tom Lane , John Naylor , pgsql-committers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Mar 8, 2024 at 10:29=E2=80=AFAM David Rowley = wrote: > > On Fri, 8 Mar 2024 at 13:48, John Naylor wrote: > > Now, after I get some coffee I'll look into the Windows failures. > > I had a look at this and the attached fixes the broken build on MSVC for = me. > > I didn't take the time to fully understand it, but I did also try > PGDLLEXPORT and that *didn't* fix it. My guess is it's because these > are function pointer variables rather than functions. Thanks, I was getting close to committing a hackish workaround -- this seems better!