MIME-Version: 1.0
References: <E1vub8B-000rlS-05@gemulon.postgresql.org>
 <CAOYmi+=4QhCjssfNEoZVK8LPtWxnfkwT5p-PAeoxtG9gpNjqOQ@mail.gmail.com>
 <3626145.1771885089@sss.pgh.pa.us>
 <CAOYmi+k8ENYkErqSEYEqW39YWPfe_ii7g5Acm1c9asNuRMriNg@mail.gmail.com>
 <3635497.1771889682@sss.pgh.pa.us>
 <CAOYmi+mtFBsB2zePSvbpa-2Zb-+V5bov_t2BzkGH7vfKX0ny_w@mail.gmail.com>
 <3797860.1771893905@sss.pgh.pa.us>
 <CAOYmi+kC3AN0QJKT0OunHCmi4UU7-15eu7w-DY5ckOgHiQE1QA@mail.gmail.com>
 <3864574.1771898936@sss.pgh.pa.us>
In-Reply-To: <3864574.1771898936@sss.pgh.pa.us>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Tue, 24 Feb 2026 09:18:19 -0800
Message-ID: 
 <CAOYmi+=96EGcQnY2w99yLeARHsbvgT_2Bv1hjXKUziykMzMhtA@mail.gmail.com>
Subject: Re: pgsql: libpq: Grease the protocol by default
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>,
 pgsql-hackers@lists.postgresql.org,
	Andrew Dunstan <andrew@dunslane.net>
Content-Type: multipart/mixed; boundary="000000000000950e3a064b951398"
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2B%3D96EGcQnY2w99yLeARHsbvgT_2Bv1hjXKUziykMzMhtA%40mail.gmail.com>
Precedence: bulk

--000000000000950e3a064b951398
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 23, 2026 at 6:08=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Jacob Champion <jacob.champion@enterprisedb.com> writes:
> > On Mon, Feb 23, 2026 at 4:45=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wr=
ote:
> >> Also: I was initially baffled why you thought this needs
> >> back-patching, but I guess you have one eye on packagers like
> >> Debian who think they can make older versions use newer libpq.so.
>
> > Right.
>
> Actually, that is going to be harder than you thought, because libpq
> before v18 will spit up on connection option "max_protocol_version".

Ha, right. Luckily the failure is very loud when testing :)

> Fortunately, we long ago had the foresight to invent PQlibVersion,
> so you could make addition of the extra option conditional on
> PQlibVersion(conn) >=3D 180000 in branches before 18.

Attached is a sample backport for REL_14_STABLE, using that strategy.
Tested with pg_upgrade 9.2-to-14, when linked against both 14.22 and
HEAD versions of libpq. I still need to run a sanity check with the
other 9.x lines to make sure I've selected the right cutoffs.

> Yeah, I came to the same conclusion.  I got a clean BF run using
> your patch together with the attached patch for the BF client.

Nice, thanks!

--Jacob

--000000000000950e3a064b951398
Content-Type: application/octet-stream;
	name="0001-pg_upgrade-Use-max_protocol_version-3.0-for-older-se.14.patch"
Content-Disposition: attachment;
	filename="0001-pg_upgrade-Use-max_protocol_version-3.0-for-older-se.14.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mm0vc8t10>
X-Attachment-Id: f_mm0vc8t10

RnJvbSBiMGEwYzM4MWFiODNlZTM5YjcxYzI5NmQzNjdlYjA2ZTIzNTY5YWE1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNvYiBDaGFtcGlvbiA8amFjb2IuY2hhbXBpb25AZW50ZXJw
cmlzZWRiLmNvbT4KRGF0ZTogTW9uLCAyMyBGZWIgMjAyNiAxNToyODozMiAtMDgwMApTdWJqZWN0
OiBbUEFUQ0hdIHBnX3VwZ3JhZGU6IFVzZSBtYXhfcHJvdG9jb2xfdmVyc2lvbj0zLjAgZm9yIG9s
ZGVyIHNlcnZlcnMKClRoZSBncmVhc2UgcGF0Y2ggaW4gNDk2NmJkM2VkIGZvdW5kIGl0cyBmaXJz
dCBwcm9ibGVtOiBwcmlvciB0byB0aGUKRmVicnVhcnkgMjAxOCBwYXRjaCByZWxlYXNlcywgbm8g
c2VydmVyIGtuZXcgaG93IHRvIG5lZ290aWF0ZSBwcm90b2NvbAp2ZXJzaW9ucywgc28gcGdfdXBn
cmFkZSBuZWVkcyB0byB0YWtlIHRoYXQgaW50byBhY2NvdW50IHdoZW4gc3BlYWtpbmcgdG8KdGhv
c2Ugb2xkZXIgc2VydmVycy4KClRoaXMgd2lsbCBiZSB0cnVlIGV2ZW4gYWZ0ZXIgdGhlIGdyZWFz
ZSBmZWF0dXJlIGlzIHJldmVydGVkOyB3ZSBkb24ndApuZWVkIGFueW9uZSB0byB0cmlwIG92ZXIg
dGhpcyBhZ2FpbiBpbiB0aGUgZnV0dXJlLiBCYWNrcGF0Y2ggc28gdGhhdCBhbGwKc3VwcG9ydGVk
IHZlcnNpb25zIG9mIHBnX3VwZ3JhZGUgY2FuIGdyYWNlZnVsbHkgaGFuZGxlIGFuIHVwZGF0ZSB0
byB0aGUKZGVmYXVsdCBwcm90b2NvbCB2ZXJzaW9uLiAoVGhpcyBpcyBuZWVkZWQgZm9yIGFueSBk
aXN0cmlidXRpb25zIHRoYXQKbGluayBvbGRlciBiaW5hcmllcyBhZ2FpbnN0IG5ld2VyIGxpYnBx
cywgc3VjaCBhcyBEZWJpYW4uKSBCcmFuY2hlcwpwcmlvciB0byAxOCBuZWVkIGFuIGFkZGl0aW9u
YWwgdmVyc2lvbiBjaGVjaywgZm9yIHRoZSBleGlzdGVuY2Ugb2YKbWF4X3Byb3RvY29sX3ZlcnNp
b24uCgpQZXIgYnVpbGRmYXJtIG1lbWJlciBjcmFrZS4KCkRpc2N1c3Npb246IGh0dHBzOi8vcG9z
dGdyLmVzL20vQ0FPWW1pJTJCJTNENFFoQ2pzc2ZORW9aVks4TFB0V3huZmt3VDVwLVBBZW94dEc5
Z3BOanFPUSU0MG1haWwuZ21haWwuY29tCkJhY2twYXRjaC10aHJvdWdoOiAxNAotLS0KIHNyYy9i
aW4vcGdfdXBncmFkZS9wZ191cGdyYWRlLmggfCAgMSArCiBzcmMvYmluL3BnX3VwZ3JhZGUvZHVt
cC5jICAgICAgIHwgIDYgKysrKystCiBzcmMvYmluL3BnX3VwZ3JhZGUvc2VydmVyLmMgICAgIHwg
IDIgKysKIHNyYy9iaW4vcGdfdXBncmFkZS92ZXJzaW9uLmMgICAgfCAzNyArKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgNDUgaW5zZXJ0aW9ucygrKSwg
MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfdXBncmFkZS9wZ191cGdyYWRl
LmggYi9zcmMvYmluL3BnX3VwZ3JhZGUvcGdfdXBncmFkZS5oCmluZGV4IGU2NDdlNzFlY2FmLi4x
NGY5Y2I1MjJkYiAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ191cGdyYWRlL3BnX3VwZ3JhZGUuaAor
KysgYi9zcmMvYmluL3BnX3VwZ3JhZGUvcGdfdXBncmFkZS5oCkBAIC00NDYsNiArNDQ2LDcgQEAg
Ym9vbAkJY2hlY2tfZm9yX2RhdGFfdHlwZXNfdXNhZ2UoQ2x1c3RlckluZm8gKmNsdXN0ZXIsCiBi
b29sCQljaGVja19mb3JfZGF0YV90eXBlX3VzYWdlKENsdXN0ZXJJbmZvICpjbHVzdGVyLAogCQkJ
CQkJCQkJICBjb25zdCBjaGFyICp0eXBlX25hbWUsCiAJCQkJCQkJCQkgIGNvbnN0IGNoYXIgKm91
dHB1dF9wYXRoKTsKK2Jvb2wJCXByb3RvY29sX25lZ290aWF0aW9uX3N1cHBvcnRlZChjb25zdCBD
bHVzdGVySW5mbyAqY2x1c3Rlcik7CiB2b2lkCQluZXdfOV8wX3BvcHVsYXRlX3BnX2xhcmdlb2Jq
ZWN0X21ldGFkYXRhKENsdXN0ZXJJbmZvICpjbHVzdGVyLAogCQkJCQkJCQkJCQkJCSBib29sIGNo
ZWNrX21vZGUpOwogdm9pZAkJb2xkXzlfM19jaGVja19mb3JfbGluZV9kYXRhX3R5cGVfdXNhZ2Uo
Q2x1c3RlckluZm8gKmNsdXN0ZXIpOwpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ191cGdyYWRlL2R1
bXAuYyBiL3NyYy9iaW4vcGdfdXBncmFkZS9kdW1wLmMKaW5kZXggOTAwNjBkMGY4ZWIuLmVlMGFj
ZTA4MmNhIDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX3VwZ3JhZGUvZHVtcC5jCisrKyBiL3NyYy9i
aW4vcGdfdXBncmFkZS9kdW1wLmMKQEAgLTIxLDkgKzIxLDEwIEBAIGdlbmVyYXRlX29sZF9kdW1w
KHZvaWQpCiAKIAkvKiBydW4gbmV3IHBnX2R1bXBhbGwgYmluYXJ5IGZvciBnbG9iYWxzICovCiAJ
ZXhlY19wcm9nKFVUSUxJVFlfTE9HX0ZJTEUsIE5VTEwsIHRydWUsIHRydWUsCi0JCQkgICJcIiVz
L3BnX2R1bXBhbGxcIiAlcyAtLWdsb2JhbHMtb25seSAtLXF1b3RlLWFsbC1pZGVudGlmaWVycyAi
CisJCQkgICJcIiVzL3BnX2R1bXBhbGxcIiAlcyVzIC0tZ2xvYmFscy1vbmx5IC0tcXVvdGUtYWxs
LWlkZW50aWZpZXJzICIKIAkJCSAgIi0tYmluYXJ5LXVwZ3JhZGUgJXMgLWYgJXMiLAogCQkJICBu
ZXdfY2x1c3Rlci5iaW5kaXIsIGNsdXN0ZXJfY29ubl9vcHRzKCZvbGRfY2x1c3RlciksCisJCQkg
IHByb3RvY29sX25lZ290aWF0aW9uX3N1cHBvcnRlZCgmb2xkX2NsdXN0ZXIpID8gIiIgOiAiIC1k
IFwibWF4X3Byb3RvY29sX3ZlcnNpb249My4wXCIiLAogCQkJICBsb2dfb3B0cy52ZXJib3NlID8g
Ii0tdmVyYm9zZSIgOiAiIiwKIAkJCSAgR0xPQkFMU19EVU1QX0ZJTEUpOwogCWNoZWNrX29rKCk7
CkBAIC00Miw2ICs0Myw5IEBAIGdlbmVyYXRlX29sZF9kdW1wKHZvaWQpCiAJCWluaXRQUUV4cEJ1
ZmZlcigmY29ubnN0cik7CiAJCWFwcGVuZFBRRXhwQnVmZmVyU3RyKCZjb25uc3RyLCAiZGJuYW1l
PSIpOwogCQlhcHBlbmRDb25uU3RyVmFsKCZjb25uc3RyLCBvbGRfZGItPmRiX25hbWUpOworCQlp
ZiAoIXByb3RvY29sX25lZ290aWF0aW9uX3N1cHBvcnRlZCgmb2xkX2NsdXN0ZXIpKQorCQkJYXBw
ZW5kUFFFeHBCdWZmZXJTdHIoJmNvbm5zdHIsICIgbWF4X3Byb3RvY29sX3ZlcnNpb249My4wIik7
CisKIAkJaW5pdFBRRXhwQnVmZmVyKCZlc2NhcGVkX2Nvbm5zdHIpOwogCQlhcHBlbmRTaGVsbFN0
cmluZygmZXNjYXBlZF9jb25uc3RyLCBjb25uc3RyLmRhdGEpOwogCQl0ZXJtUFFFeHBCdWZmZXIo
JmNvbm5zdHIpOwpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ191cGdyYWRlL3NlcnZlci5jIGIvc3Jj
L2Jpbi9wZ191cGdyYWRlL3NlcnZlci5jCmluZGV4IDdmZWQwYWUxMDg2Li5mNDlmMzAxM2MzOCAx
MDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ191cGdyYWRlL3NlcnZlci5jCisrKyBiL3NyYy9iaW4vcGdf
dXBncmFkZS9zZXJ2ZXIuYwpAQCAtNzAsNiArNzAsOCBAQCBnZXRfZGJfY29ubihDbHVzdGVySW5m
byAqY2x1c3RlciwgY29uc3QgY2hhciAqZGJfbmFtZSkKIAkJYXBwZW5kUFFFeHBCdWZmZXJTdHIo
JmNvbm5fb3B0cywgIiBob3N0PSIpOwogCQlhcHBlbmRDb25uU3RyVmFsKCZjb25uX29wdHMsIGNs
dXN0ZXItPnNvY2tkaXIpOwogCX0KKwlpZiAoIXByb3RvY29sX25lZ290aWF0aW9uX3N1cHBvcnRl
ZChjbHVzdGVyKSkKKwkJYXBwZW5kUFFFeHBCdWZmZXJTdHIoJmNvbm5fb3B0cywgIiBtYXhfcHJv
dG9jb2xfdmVyc2lvbj0zLjAiKTsKIAogCWNvbm4gPSBQUWNvbm5lY3RkYihjb25uX29wdHMuZGF0
YSk7CiAJdGVybVBRRXhwQnVmZmVyKCZjb25uX29wdHMpOwpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9w
Z191cGdyYWRlL3ZlcnNpb24uYyBiL3NyYy9iaW4vcGdfdXBncmFkZS92ZXJzaW9uLmMKaW5kZXgg
Y2NiMDEyNjU3YmUuLmZkZGRkOTBiZjk3IDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX3VwZ3JhZGUv
dmVyc2lvbi5jCisrKyBiL3NyYy9iaW4vcGdfdXBncmFkZS92ZXJzaW9uLmMKQEAgLTMyNSw2ICsz
MjUsNDMgQEAgb2xkXzlfNl9jaGVja19mb3JfdW5rbm93bl9kYXRhX3R5cGVfdXNhZ2UoQ2x1c3Rl
ckluZm8gKmNsdXN0ZXIpCiAJCWNoZWNrX29rKCk7CiB9CiAKKy8qCisgKiBPbGRlciBzZXJ2ZXJz
IGNhbid0IHN1cHBvcnQgbmV3ZXIgcHJvdG9jb2wgdmVyc2lvbnMsIHNvIHRoZWlyIGNvbm5lY3Rp
b24KKyAqIHN0cmluZ3Mgd2lsbCBuZWVkIHRvIGxvY2sgbWF4X3Byb3RvY29sX3ZlcnNpb24gdG8g
My4wLgorICovCitib29sCitwcm90b2NvbF9uZWdvdGlhdGlvbl9zdXBwb3J0ZWQoY29uc3QgQ2x1
c3RlckluZm8gKmNsdXN0ZXIpCit7CisJaW50CQkJbWFqb3IgPSBHRVRfTUFKT1JfVkVSU0lPTihj
bHVzdGVyLT5tYWpvcl92ZXJzaW9uKTsKKworCS8qCisJICogQmFjay1icmFuY2gtc3BlY2lmaWMg
Y29tcGxpY2F0aW9uOiBmb3IgbGlicHEgdmVyc2lvbnMgcHJpb3IgdG8gUEcxOCwKKwkgKiBtYXhf
cHJvdG9jb2xfdmVyc2lvbiBpc24ndCBzdXBwb3J0ZWQuIEJ1dCB3ZSBhbHNvIGRvbid0IG5lZWQg
dG8gd29ycnkKKwkgKiBhYm91dCBuZXdlciBwcm90b2NvbCB2ZXJzaW9ucyBiZWluZyB1c2VkIGlu
IHRoYXQgY2FzZSwgc28ganVzdCBsaWUgYW5kCisJICogcmV0dXJuIHRydWUuCisJICoKKwkgKiAo
Q2hlY2tpbmcgZm9yIGEgbGlicHEgdmVyc2lvbiB0aGF0J3MgbmV3ZXIgdGhhbiB0aGlzIGJyYW5j
aCBsb29rcyB2ZXJ5CisJICogc3RyYW5nZSwgYnV0IGRpc3RyaWJ1dGlvbnMgYXJlIGFsbG93ZWQg
dG8gbGluayBvbGRlciBwZ191cGdyYWRlCisJICogYmluYXJpZXMgYWdhaW5zdCB0aGUgbmV3ZXN0
IHJlbGVhc2Ugb2YgbGlicHEuKQorCSAqLworCWlmIChQUWxpYlZlcnNpb24oKSA8IDE4MDAwMCkK
KwkJcmV0dXJuIHRydWU7CisKKwkvKgorCSAqIFRoZXNlIHZlcnNpb24gbnVtYmVycyBjb21lIGZy
b20gdGhlIEZlYnJ1YXJ5IDIwMTggcGF0Y2ggcmVsZWFzZSwgd2hpY2gKKwkgKiBhZGRlZCBzdXBw
b3J0IGZvciBOZWdvdGlhdGVQcm90b2NvbFZlcnNpb246IDkuMy4yMSwgOS40LjE2LCA5LjUuMTEs
CisJICogOS42LjcsIGFuZCAxMC4yLgorCSAqLworCWlmIChjbHVzdGVyLT5tYWpvcl92ZXJzaW9u
IDwgOTAzMjEKKwkJfHwgKG1ham9yID09IDkwNCAmJiBjbHVzdGVyLT5tYWpvcl92ZXJzaW9uIDwg
OTA0MTYpCisJCXx8IChtYWpvciA9PSA5MDUgJiYgY2x1c3Rlci0+bWFqb3JfdmVyc2lvbiA8IDkw
NTExKQorCQl8fCAobWFqb3IgPT0gOTA2ICYmIGNsdXN0ZXItPm1ham9yX3ZlcnNpb24gPCA5MDYw
NykKKwkJfHwgKG1ham9yID09IDEwMDAgJiYgY2x1c3Rlci0+bWFqb3JfdmVyc2lvbiA8IDEwMDAw
MikpCisJCXJldHVybiBmYWxzZTsKKworCXJldHVybiB0cnVlOworfQorCiAvKgogICogb2xkXzlf
Nl9pbnZhbGlkYXRlX2hhc2hfaW5kZXhlcygpCiAgKgk5LjYgLT4gMTAKLS0gCjIuMzQuMQoK
--000000000000950e3a064b951398--