MIME-Version: 1.0
References: <E1tl8m6-000KH7-0J@gemulon.postgresql.org>
 <Z-sPFl27Y0ZC-VBl@msg.df7cb.de>
In-Reply-To: <Z-sPFl27Y0ZC-VBl@msg.df7cb.de>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Mon, 31 Mar 2025 16:09:22 -0700
Message-ID: 
 <CAOYmi+=SEwJ+7ATgxrkvDFyGb-FQ5FN9eF_RVMic6DAU3bk5zw@mail.gmail.com>
Subject: Re: pgsql: Add support for OAUTHBEARER SASL mechanism
To: Christoph Berg <myon@debian.org>
Cc: Daniel Gustafsson <dgustafsson@postgresql.org>,
 Thomas Munro <thomas.munro@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2B%3DSEwJ%2B7ATgxrkvDFyGb-FQ5FN9eF_RVMic6DAU3bk5zw%40mail.gmail.com>
Precedence: bulk

On Mon, Mar 31, 2025 at 2:54=E2=80=AFPM Christoph Berg <myon@debian.org> wr=
ote:
>
> > Add support for OAUTHBEARER SASL mechanism
>
> Debian still has this experimental port with a GNU userland and a
> FreeBSD kernel called kfreebsd. I don't expect anyone to particularly
> care about it, but it found an actual bug:
>
> /build/reproducible-path/postgresql-18-18~~devel.20250331/build/../src/in=
terfaces/libpq/fe-auth-oauth-curl.c: In function =E2=80=98register_socket=
=E2=80=99:
> /build/reproducible-path/postgresql-18-18~~devel.20250331/build/../src/in=
terfaces/libpq/fe-auth-oauth-curl.c:1317:20: error: =E2=80=98actx=E2=80=99 =
undeclared (first use in this function); did you mean =E2=80=98ctx=E2=80=99=
?
>  1317 |         actx_error(actx, "libpq does not support multiplexer sock=
ets on this platform");
>       |                    ^~~~
>
> This should not be a compile-time error; actx is not defined outside
> the #ifdef blocks there:

Ah, sorry about that. Thank you for reporting it!

(That means that Windows builds --with-libcurl are similarly broken, I
think. Not that Windows packagers will want to use --with-libcurl --
it doesn't do anything -- but it should build.)

I don't have hurd-amd64 to test, but I'm working on a patch that will
build and pass tests if I manually munge pg_config.h. We were skipping
the useless tests via a $windows_os check; I think I should use
check_pg_config() instead.

We could change how this works a bit for the proposed libpq-oauth.so
plugin, and only build it if we have a workable implementation. I do
like having these other platforms compile the Curl code, though, since
we'd prefer to keep the build clean for a future Windows
implementation...

--Jacob