public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jacob Champion <[email protected]>
To: Tom Lane <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: [email protected]
Cc: Andrew Dunstan <[email protected]>
Subject: Re: pgsql: libpq: Grease the protocol by default
Date: Mon, 23 Feb 2026 17:05:45 -0800
Message-ID: <CAOYmi+kC3AN0QJKT0OunHCmi4UU7-15eu7w-DY5ckOgHiQE1QA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAOYmi+=4QhCjssfNEoZVK8LPtWxnfkwT5p-PAeoxtG9gpNjqOQ@mail.gmail.com>
	<[email protected]>
	<CAOYmi+k8ENYkErqSEYEqW39YWPfe_ii7g5Acm1c9asNuRMriNg@mail.gmail.com>
	<[email protected]>
	<CAOYmi+mtFBsB2zePSvbpa-2Zb-+V5bov_t2BzkGH7vfKX0ny_w@mail.gmail.com>
	<[email protected]>

On Mon, Feb 23, 2026 at 4:45 PM Tom Lane <[email protected]> wrote:
> Jacob Champion <[email protected]> writes:
> > Something like the attached (tested only against 9.2 so far)? I would
> > plan to backpatch after feature freeze is lifted.

(er, should have been "release freeze", though we're clearly in no hurry)

> Also: I was initially baffled why you thought this needs
> back-patching, but I guess you have one eye on packagers like
> Debian who think they can make older versions use newer libpq.so.

Right.

> It'd be good to spell out that reasoning in the commit message.

Okay, will do.

> It's not obvious to me where the problem lies.  I can replicate
> the failure by trying to use HEAD's psql to connect to a 9.2
> server, but adding -d "max_protocol_version=3.0" makes psql happy,
> so why not pg_dumpall?

Hmmm, looks like the -dump1.log output is actually from *before*
pg_upgrade actually runs:

    https://github.com/PGBuildFarm/client-code/blob/28d7e945cc2a27fecdf4cc685782821ca504db5d/PGBuild/Mod...

So that will still need to be modified in the buildfarm client,
independently of my patch. (I reproduced the error with a bare
pg_upgrade invocation and didn't think to look closer; sorry for the
confusion.)

--Jacob

view thread (27+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: libpq: Grease the protocol by default
  In-Reply-To: <CAOYmi+kC3AN0QJKT0OunHCmi4UU7-15eu7w-DY5ckOgHiQE1QA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox