MIME-Version: 1.0
References: <E1tzyNB-002IXa-0i@gemulon.postgresql.org>
 <61be9e31-7b7d-49d5-bc11-721800d89d64@eisentraut.org>
 <09323e6a-4743-4be2-9d7f-74b86e4dac64@iki.fi>
 <34d5d731-06cc-43af-88cd-b3a4c5c8d9df@iki.fi>
 <2afbd9c6-51b7-450f-9ae1-61e552368963@eisentraut.org>
 <4bd8421a-50ad-4169-a096-99247c2f563c@iki.fi>
 <9399dc5d-5575-483e-8e23-af6be79385c8@iki.fi>
 <52d648b1-9aca-43d1-a9e4-a6a556410f41@iki.fi>
In-Reply-To: <52d648b1-9aca-43d1-a9e4-a6a556410f41@iki.fi>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Thu, 8 May 2025 15:28:24 -0700
Message-ID: 
 <CAOYmi+kJcKkbe3Ng7=jYOz7V2gYEvdNXKESKbmuW=6N7=243tg@mail.gmail.com>
Subject: Re: pgsql: Make cancel request keys longer
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2BkJcKkbe3Ng7%3DjYOz7V2gYEvdNXKESKbmuW%3D6N7%3D243tg%40mail.gmail.com>
Precedence: bulk

On Thu, May 8, 2025 at 12:11=E2=80=AFPM Heikki Linnakangas <hlinnaka@iki.fi=
> wrote:
> Polished this up a tiny bit, and committed.

Thanks! I think the uint8->int change for cancel_key_len is more than
just cosmetic; it most likely fixes a bug where a key size of 256
wrapped around to 0. I'll double-check that this fixes that later;
I've gotten side-tracked from the protocol stuff a bit.

While I have you, though, is the following just a really complicated
way to say `msgLength - 4`, or is there some other reason to do the
pointer math?

    cancel_key_len =3D 5 + msgLength - (conn->inCursor - conn->inStart);

--Jacob