MIME-Version: 1.0
References: <E1tzyNB-002IXa-0i@gemulon.postgresql.org>
 <61be9e31-7b7d-49d5-bc11-721800d89d64@eisentraut.org>
 <09323e6a-4743-4be2-9d7f-74b86e4dac64@iki.fi>
 <34d5d731-06cc-43af-88cd-b3a4c5c8d9df@iki.fi>
 <2afbd9c6-51b7-450f-9ae1-61e552368963@eisentraut.org>
 <4bd8421a-50ad-4169-a096-99247c2f563c@iki.fi>
 <9399dc5d-5575-483e-8e23-af6be79385c8@iki.fi>
 <52d648b1-9aca-43d1-a9e4-a6a556410f41@iki.fi>
 <CAOYmi+kJcKkbe3Ng7=jYOz7V2gYEvdNXKESKbmuW=6N7=243tg@mail.gmail.com>
 <a92c439b-6f6d-4460-b5ec-1aacd80a866b@iki.fi>
In-Reply-To: <a92c439b-6f6d-4460-b5ec-1aacd80a866b@iki.fi>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Fri, 23 May 2025 14:59:44 -0700
Message-ID: 
 <CAOYmi+nmqLB9jYPy0PNmTbLbzrAEfwrGVeKe4G_S4fRs4-D52w@mail.gmail.com>
Subject: Re: pgsql: Make cancel request keys longer
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Jelte Fennema-Nio <postgres@jeltef.nl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2BnmqLB9jYPy0PNmTbLbzrAEfwrGVeKe4G_S4fRs4-D52w%40mail.gmail.com>
Precedence: bulk

On Thu, May 8, 2025 at 11:38=E2=80=AFPM Heikki Linnakangas <hlinnaka@iki.fi=
> wrote:
> It didn't occur to me that you could write it simply as 'msgLength - 4'.
> That depends on knowing that the preceding fields are exactly 4 bytes
> long, but that's clear enough if we just add a comment on that, see
> attached.

Sorry for the conference delay; this looks fine to me.

One of the side effects of the uint8 change is that the client now
accepts cancel keys up to roughly 30kb. Is that intended?

--Jacob