MIME-Version: 1.0
References: <E1uLe9X-000zsY-2g@gemulon.postgresql.org>
 <ed2296f1-1a6b-4932-b870-5bb18c2591ae@oss.nttdata.com>
 <aD0bg6Km5IigzUkC@paquier.xyz>
In-Reply-To: <aD0bg6Km5IigzUkC@paquier.xyz>
From: Etsuro Fujita <etsuro.fujita@gmail.com>
Date: Tue, 3 Jun 2025 19:45:34 +0900
Message-ID: 
 <CAPmGK17Vf4fWt=+kCZ8V3JP7jO6iMrUze7TjOVtGzZwNbevnwg@mail.gmail.com>
Subject: Re: pgsql: postgres_fdw: Inherit the local transaction's
 access/deferrable
To: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>,
 Etsuro Fujita <efujita@postgresql.org>,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPmGK17Vf4fWt%3D%2BkCZ8V3JP7jO6iMrUze7TjOVtGzZwNbevnwg%40mail.gmail.com>
Precedence: bulk

On Mon, Jun 2, 2025 at 12:33=E2=80=AFPM Michael Paquier <michael@paquier.xy=
z> wrote:
> On Mon, Jun 02, 2025 at 12:03:50PM +0900, Fujii Masao wrote:
> > I'm not sure this change should be considered a bug fix,
> > since the current behavior of postgres_fdw with a local read-only
> > transaction isn't clearly documented. Some users might see this
> > as a behavioral change rather than a fix. Anyway if we go with it,
> > shouldn't we document the change in the v18 release notes?
>
> After going through the thread and the commit, I have to admit that I
> was surprised to see this applied on HEAD now that we are in feature
> freeze.  This is a behavior change.  Perhaps this could be done once
> v19 happens, still it's rather unclear if the new behavior is better
> than the previous one.

No, this is a fix, not a feature, as discussed in the thread; as
mentioned in the commit message, the previous version of postgres_fdw
could cause surprising behaviors that would never happen in normal
cases where a read-only and/or deferrable transaction only
accesses/modifies data on the local server, so this commit fixes those
behaviors.  But yes, it makes a behavior change, so I think it=E2=80=99s a
good idea to add a note about that to the v18 release notes, as
proposed by Fujii-san.

Thank you for the comments!

Best regards,
Etsuro Fujita