MIME-Version: 1.0
References: <E1u0guq-002dS9-1m@gemulon.postgresql.org>
 <CAAKRu_bFn5xis9gugrnU3N8O6NN8WYncv5NedHfv3J65m_RZ8w@mail.gmail.com>
 <CAApHDvryXfsJO1HUWqcQTBBxdSJDwrotnZFt7sSL-ddZ+g+f5Q@mail.gmail.com>
In-Reply-To: 
 <CAApHDvryXfsJO1HUWqcQTBBxdSJDwrotnZFt7sSL-ddZ+g+f5Q@mail.gmail.com>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Mon, 7 Apr 2025 16:08:49 +0300
Message-ID: 
 <CAPpHfdtNKv-87KVBHnQ7kXavkp9bDOFTiHtkqQn3SzxOPmP_+w@mail.gmail.com>
Subject: Re: pgsql: Convert 'x IN (VALUES ...)' to 'x = ANY ...' then
 appropriate
To: David Rowley <dgrowleyml@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>,
	Alexander Korotkov <akorotkov@postgresql.org>,
 pgsql-committers@lists.postgresql.org,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdtNKv-87KVBHnQ7kXavkp9bDOFTiHtkqQn3SzxOPmP_%2Bw%40mail.gmail.com>
Precedence: bulk

Hi, David!

On Mon, Apr 7, 2025 at 12:15=E2=80=AFPM David Rowley <dgrowleyml@gmail.com>=
 wrote:
>
> On Mon, 7 Apr 2025 at 19:39, Melanie Plageman <melanieplageman@gmail.com>=
 wrote:
> > +++ C:/cirrus/build/testrun/pg_upgrade/002_pg_upgrade/data/results/subs=
elect.out
> > 2025-04-04 14:47:20.358393500 +0000
> > @@ -2769,15 +2769,16 @@
> >  EXPLAIN (COSTS OFF)
> >  SELECT c.oid,c.relname FROM pg_class c JOIN pg_am a USING (oid)
> >  WHERE c.oid IN (VALUES (1), (2));
> > -                          QUERY PLAN
> > ----------------------------------------------------------------
> > - Hash Join
> > -   Hash Cond: (a.oid =3D c.oid)
> > -   ->  Seq Scan on pg_am a
> > -   ->  Hash
> > -         ->  Index Scan using pg_class_oid_index on pg_class c
> > -               Index Cond: (oid =3D ANY ('{1,2}'::oid[]))
> > -(6 rows)
> > +                       QUERY PLAN
> > +---------------------------------------------------------
> > + Merge Join
> > +   Merge Cond: (c.oid =3D a.oid)
> > +   ->  Index Scan using pg_class_oid_index on pg_class c
> > +         Index Cond: (oid =3D ANY ('{1,2}'::oid[]))
> > +   ->  Sort
> > +         Sort Key: a.oid
> > +         ->  Seq Scan on pg_am a
> > +(7 rows)
>
> Are these failures from patches applied to master prior to 3ba2cdaa?

Yes, these failures appears before 3ba2cdaa.  Tom committed 3ba2cdaa
to fix the problem before I get into it [1].

Links.
1. https://www.postgresql.org/message-id/srnuqlttuimzmvoulhsrbgvj4vnul6b65o=
sswvua7sfkqsvmuy%40yg7apybpxp34

------
Regards,
Alexander Korotkov
Supabase