public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alexander Korotkov <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: [email protected]
Cc: Maxim Orlov <[email protected]>
Cc: Svetlana Derevyanko <[email protected]>
Subject: Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
Date: Sat, 8 Mar 2025 12:42:41 +0200
Message-ID: <CAPpHfdv9QjNPNt+c+1qrtO2bHtSUE4zybWkGfUQa4kKSV5QOmA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Sat, Mar 8, 2025 at 11:57 AM Álvaro Herrera <[email protected]> wrote:
>
> On 2025-Mar-07, Álvaro Herrera wrote:
>
> > I tested this, because of a refactoring suggestion [1] and I find that
> > it's rather completely broken.
>
> I think we need significantly more complex scheduling code if we want
> this to actually work, possibly even having to hack the ParallelSlot
> API some, so that we can inspect which tables have a running reindex and
> know not to schedule the next one on it.  What we're doing now makes no
> sense.
>
> We should strike this out from the list of features of 17 and revert
> this commit.
>
> If we want this feature in 19, we need another go through the drawing
> board.  (There's clearly not enough time to do it for 18.)

Yes, I also think we need to revert this from 17.  One thing to care
about: it might be already used in some user scripts.  Should we
replace pg_fatal() with some notice and then run in a single job?  So,
user scripts wouldn't error out.

------
Regards,
Alexander Korotkov
Supabase

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
  In-Reply-To: <CAPpHfdv9QjNPNt+c+1qrtO2bHtSUE4zybWkGfUQa4kKSV5QOmA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox