MIME-Version: 1.0
References: <E1wSIm8-001NOT-1v@gemulon.postgresql.org>
In-Reply-To: <E1wSIm8-001NOT-1v@gemulon.postgresql.org>
From: Alexander Korotkov <aekorotkov@gmail.com>
Date: Wed, 27 May 2026 23:08:41 +0300
Message-ID: 
 <CAPpHfdvEoXXsesebHHDTB2w9U73oS6h_n+uR027xobzLJsDwng@mail.gmail.com>
Subject: Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY)
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: pgsql-committers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAPpHfdvEoXXsesebHHDTB2w9U73oS6h_n%2BuR027xobzLJsDwng%40mail.gmail.com>
Precedence: bulk

Hi!

On Wed, May 27, 2026 at 9:14=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kuril=
emu.de> wrote:
> Disable logical decoding after REPACK (CONCURRENTLY)
>
> REPACK (CONCURRENTLY) uses a temporary logical replication slot, which
> is dropped once done, but it wasn't calling RequestDisableLogicalDecoding=
(),
> leaving effective_wal_level stuck at 'logical'.
>
> Fix by adding a Boolean flag to ReplicationSlotDropAcquired() to have it
> request to disable logical decoding, and passing it as true on REPACK.
> Other callers of that function preserve their existing behavior.
>
> Author: Imran Zaheer <imran.zhir@gmail.com>
> Reviewed-by: shveta malik <shveta.malik@gmail.com>
> Discussion: https://postgr.es/m/CA+UBfaktds57dw2M8BEv_kS-=3Dixph3w+3MxKix=
taDQMi_k7Ybg@mail.gmail.com

This seams to cause buildfarm failures, for instance
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dloach&dt=3D2026-0=
5-27%2018%3A25%3A00

------
Regards,
Alexander Korotkov
Supabase