Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iJqIk-00009p-Lu for pgsql-committers@arkaria.postgresql.org; Mon, 14 Oct 2019 02:41:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iJqFV-0002BU-8X for pgsql-committers@arkaria.postgresql.org; Mon, 14 Oct 2019 02:38:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iJqED-0002AQ-DA for pgsql-committers@lists.postgresql.org; Mon, 14 Oct 2019 02:36:57 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iJqEA-0003W0-FO for pgsql-committers@lists.postgresql.org; Mon, 14 Oct 2019 02:36:56 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 0994121C224C for ; Mon, 14 Oct 2019 05:36:53 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (not verified)) by mail.postgrespro.ru (Postfix) with ESMTPSA id 59EFA21C1CC3 for ; Mon, 14 Oct 2019 05:36:52 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1571020612; bh=geEs9xy/+NlFmjx/nShk7HcUMt7DjTGCLwg+zAUAlO0=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=a91ZZBSm15kbVchPz/4o9vft/TtvjjfAzYxUWvIvLoEs62T5GR2+MpCcTarEqy3uk L5mT6vP29W2C90cT+rpY2DAGyfoa1VKMI7jST/VJFH5UFMnhXEQV3vovy8CIXCP8Je p6rwopgaS3ALfv8esHTV5Png7ZnUGLWdkQGO3Vmg= Received: by mail-io1-f54.google.com with SMTP id z19so34832781ior.0 for ; Sun, 13 Oct 2019 19:36:52 -0700 (PDT) X-Gm-Message-State: APjAAAWJnVKTIm8CrJEcALUoTtLfe2Ynt6rIYcufVbTttEUQyd8n101p WFQ4fl+CnolXxNpsZTm9GMsNTWXD3oCUM1z00vo= X-Google-Smtp-Source: APXvYqyCOR7g+svhwXzB9GLczCVL2/Swq25zu2SUyTh+mN6LV4zr/uzSwuhOAxMANNXcSAG3Pl5u76oHPwydRPZ360o= X-Received: by 2002:a02:a15b:: with SMTP id m27mr35062626jah.59.1571020610898; Sun, 13 Oct 2019 19:36:50 -0700 (PDT) MIME-Version: 1.0 References: <31235.1570933467@sss.pgh.pa.us> In-Reply-To: <31235.1570933467@sss.pgh.pa.us> From: Alexander Korotkov Date: Mon, 14 Oct 2019 05:36:39 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pgsql: Implement jsonpath .datetime() method To: Tom Lane Cc: Robert Haas , Nikita Glukhov , pgsql-committers , Alexander Korotkov , pgsql-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Sun, Oct 13, 2019 at 5:24 AM Tom Lane wrote: > Alexander Korotkov writes: > > This patch also changes the way timestamp to timestamptz cast works. > > Previously it did timestamp2tm() then tm2timestamp(). Instead, after > > timestamp2tm() it calculates timezone offset and applies it to > > original timestamp value. I hope this is correct. > > I'd wonder whether this gives the same answers near DST transitions, > where it's not real clear which offset applies. I will try this and share the results. > Please *don't* wrap this sort of thing into an unrelated feature patch. Sure, thank you for noticing. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company