Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\))
Subject: Re: pgsql: Add support for OAUTHBEARER SASL mechanism
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <Z-vkHdDPFlD8SKAf@msg.df7cb.de>
Date: Tue, 1 Apr 2025 15:11:51 +0200
Cc: Jacob Champion <jacob.champion@enterprisedb.com>,
 Thomas Munro <thomas.munro@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: 7bit
Message-Id: <CB1D7ED6-0A7C-4B3E-84E4-72E9576E9AAD@yesql.se>
References: <E1tl8m6-000KH7-0J@gemulon.postgresql.org>
 <Z-sPFl27Y0ZC-VBl@msg.df7cb.de>
 <CAOYmi+=SEwJ+7ATgxrkvDFyGb-FQ5FN9eF_RVMic6DAU3bk5zw@mail.gmail.com>
 <Z-vkHdDPFlD8SKAf@msg.df7cb.de>
To: Christoph Berg <myon@debian.org>
Archived-At: 
 <https://www.postgresql.org/message-id/CB1D7ED6-0A7C-4B3E-84E4-72E9576E9AAD%40yesql.se>
Precedence: bulk

> On 1 Apr 2025, at 15:03, Christoph Berg <myon@debian.org> wrote:

> With the libpq-oauth split, this makes even more sense because
> building a library that always throws an error isn't very useful.
> (Don't build that file at all if the feature doesn't work.)

After the split, configure/meson should fail if the libcurl dependency isn't
satisfied or if the platform isn't supported.

> Since oauth/curl have some security implications, would it make more
> sense to call the switch --enable-oauth (-Doauth) so users could
> control better what features their libpq is going to have? Perhaps
> some other feature (pg_service as URL?) is going to need libcurl as
> well, but it should be configurable separately.

Perhaps --with-oauth-client for the opt-in libpq-oauth?

--
Daniel Gustafsson