Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u4eiP-005PPf-HX for pgsql-committers@arkaria.postgresql.org; Tue, 15 Apr 2025 11:44:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u4eiM-008xnb-VJ for pgsql-committers@arkaria.postgresql.org; Tue, 15 Apr 2025 11:44:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u4eiM-008xnS-K0 for pgsql-committers@lists.postgresql.org; Tue, 15 Apr 2025 11:44:31 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u4eiK-000CsO-0v for pgsql-committers@lists.postgresql.org; Tue, 15 Apr 2025 11:44:30 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id DAC1F34F26C for ; Tue, 15 Apr 2025 13:44:27 +0200 (CEST) Received: from s899.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id CC8D63500B3; Tue, 15 Apr 2025 13:44:27 +0200 (CEST) Received: from s472.loopia.se (unknown [172.22.191.6]) by s899.loopia.se (Postfix) with ESMTP id CADE52C8BAB8; Tue, 15 Apr 2025 13:44:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s472.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s980.loopia.se ([172.22.191.5]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with UTF8LMTP id jzLwDIlb-6s9; Tue, 15 Apr 2025 13:44:27 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s980.loopia.se (Postfix) with ESMTPSA id 2AC3322016BC; Tue, 15 Apr 2025 13:44:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1744717467; bh=mi7dy7FQmNObK7fIBda0LYTsA+khR3FGchEbkU8bBW4=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=YFbVoRQhr1Y3Gp0NAUbLNPHcv0g8/ZyS/rtk1jK4IedkjHORP3NzTC0Ba06AqgJ3/ 6SmkD677p5Aavdw928hW9cjMVsL+U0IYFvMu831mhd7zCYADj4XOIFF1bTLOKkeXgw k/8JgQwvCBRI+mhQKbFcD9Jm+OZ/XX79GTTOZ1Z1eut8shZECLipg62KpXgWKa0PBz nwjhFuKKoImDf+VtqOjDjSNDcV8G2KpZO57HT0k3WprTR9/B91PfOEttL4rh+b9gAf EfX9CgGi/QTEYTD8hnB4988BDqDiOAeLMs8w/fwXar1j/2iLaTpBfZSmOqmfUTescM nr0WyWshR8nbg== From: Daniel Gustafsson Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_72AA7DD0-D027-4E7D-AEB8-D351802475C2" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Subject: Re: pgsql: Add support for basic NUMA awareness Date: Tue, 15 Apr 2025 13:44:16 +0200 In-Reply-To: Cc: pgsql-committers@lists.postgresql.org To: Tomas Vondra References: X-Mailer: Apple Mail (2.3776.700.51.11.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Apple-Mail=_72AA7DD0-D027-4E7D-AEB8-D351802475C2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 7 Apr 2025, at 23:18, Tomas Vondra = wrote: >=20 > Add support for basic NUMA awareness It seems like this commit didn't run autoheader, which leaves a trivial = diff in pg_config.h.in carried over for future callers. It doesn't change = anuything really as the HAVE_LIBNUMA macro isn't used, but for completeness sake = we should probably add it? -- Daniel Gustafsson --Apple-Mail=_72AA7DD0-D027-4E7D-AEB8-D351802475C2 Content-Disposition: attachment; filename=libnuma_autoheader.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="libnuma_autoheader.diff" Content-Transfer-Encoding: 7bit diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in index 1af0b6316dd..c3cc9fa856d 100644 --- a/src/include/pg_config.h.in +++ b/src/include/pg_config.h.in @@ -249,6 +249,9 @@ /* Define to 1 if you have the `m' library (-lm). */ #undef HAVE_LIBM +/* Define to 1 if you have the `numa' library (-lnuma). */ +#undef HAVE_LIBNUMA + /* Define to 1 if you have the `pam' library (-lpam). */ #undef HAVE_LIBPAM @@ -689,7 +692,7 @@ /* Define to 1 to build with libcurl support. (--with-libcurl) */ #undef USE_LIBCURL -/* Define to 1 to build with NUMA support. (--with-libnuma) */ +/* Define to build with NUMA support. (--with-libnuma) */ #undef USE_LIBNUMA /* Define to build with io_uring support. (--with-liburing) */ --Apple-Mail=_72AA7DD0-D027-4E7D-AEB8-D351802475C2--