Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbp8i-00076b-2E for pgsql-committers@arkaria.postgresql.org; Tue, 05 Apr 2022 19:46:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nbp8g-0000nr-OL for pgsql-committers@arkaria.postgresql.org; Tue, 05 Apr 2022 19:46:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbp8g-0000nh-HQ for pgsql-committers@lists.postgresql.org; Tue, 05 Apr 2022 19:46:54 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nbp8c-0003Ud-K4 for pgsql-committers@lists.postgresql.org; Tue, 05 Apr 2022 19:46:53 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id C6D7E2F25EEC for ; Tue, 5 Apr 2022 21:46:28 +0200 (CEST) Received: from s934.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id B7D4C2E30522; Tue, 5 Apr 2022 21:46:28 +0200 (CEST) Received: from s898.loopia.se (unknown [172.22.191.6]) by s934.loopia.se (Postfix) with ESMTP id B5C0C7E4E6B; Tue, 5 Apr 2022 21:46:28 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s499.loopia.se ([172.22.191.6]) by s898.loopia.se (s898.loopia.se [172.22.190.17]) (amavisd-new, port 10024) with LMTP id mc8hqkUTG16H; Tue, 5 Apr 2022 21:46:28 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s499.loopia.se (Postfix) with ESMTPSA id 382E61CE5340; Tue, 5 Apr 2022 21:46:28 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: pgsql: pg_rewind: Fetch small files according to new size. From: Daniel Gustafsson In-Reply-To: <13C2BF64-4A6D-47E4-9181-3A658F00C9B7@yesql.se> Date: Tue, 5 Apr 2022 21:46:27 +0200 Cc: pgsql-committers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <13C2BF64-4A6D-47E4-9181-3A658F00C9B7@yesql.se> To: Daniel Gustafsson X-Mailer: Apple Mail (2.3696.80.82.1.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 5 Apr 2022, at 15:36, Daniel Gustafsson wrote: >=20 >> On 5 Apr 2022, at 15:02, Daniel Gustafsson = wrote: >>=20 >> =EF=BB=BFpg_rewind: Fetch small files according to new size. >=20 > The buildfarm is less impressed than CI was, I=E2=80=99m collecting = more feedback and will then fix. Sorry for being slow, life took over and children with fever took = priority. The error in question was: local_source.c:118:15: error: format specifies type 'unsigned long long' = but the argument has type 'size_t' (aka 'unsigned int') = [-Werror,-Wformat] srcpath, len, written_len); ~~~~~~~~~^~~~~~~~~~~~~~~~~ I'm running a fixup with casting to int and printing with %d (like how pg_rewind.c:digestControlFile already does it for printing a size_t) = through CI just to be sure and will push once it's had a green run: - pg_fatal("size of source file \"%s\" changed = concurrently: " UINT64_FORMAT " bytes expected, " UINT64_FORMAT " = copied", - srcpath, len, written_len); + pg_fatal("size of source file \"%s\" changed = concurrently: %d bytes expected, %d copied", + srcpath, (int) len, (int) written_len); -- Daniel Gustafsson https://vmware.com/