pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Make dblink try harder to form useful error messages 6+ messages / 1 participants [nested] [flat]
* pgsql: Make dblink try harder to form useful error messages @ 2016-12-22 17:49 Joe Conway <mail@joeconway.com> 0 siblings, 0 replies; 6+ messages in thread From: Joe Conway @ 2016-12-22 17:49 UTC (permalink / raw) To: pgsql-committers Make dblink try harder to form useful error messages When libpq encounters a connection-level error, e.g. runs out of memory while forming a result, there will be no error associated with PGresult, but a message will be placed into PGconn's error buffer. postgres_fdw takes care to use the PGconn error message when PGresult does not have one, but dblink has been negligent in that regard. Modify dblink to mirror what postgres_fdw has been doing. Back-patch to all supported branches. Author: Joe Conway Reviewed-By: Tom Lane Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/2f802d95b4904dbed3dfdca1b3a607cd085d2e20 Modified Files -------------- contrib/dblink/dblink.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make dblink try harder to form useful error messages @ 2016-12-22 17:49 Joe Conway <mail@joeconway.com> 0 siblings, 0 replies; 6+ messages in thread From: Joe Conway @ 2016-12-22 17:49 UTC (permalink / raw) To: pgsql-committers Make dblink try harder to form useful error messages When libpq encounters a connection-level error, e.g. runs out of memory while forming a result, there will be no error associated with PGresult, but a message will be placed into PGconn's error buffer. postgres_fdw takes care to use the PGconn error message when PGresult does not have one, but dblink has been negligent in that regard. Modify dblink to mirror what postgres_fdw has been doing. Back-patch to all supported branches. Author: Joe Conway Reviewed-By: Tom Lane Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com Branch ------ REL9_6_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/51126ccdb1ce720b674405e11bcb5e7b8fa902fb Modified Files -------------- contrib/dblink/dblink.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make dblink try harder to form useful error messages @ 2016-12-22 17:49 Joe Conway <mail@joeconway.com> 0 siblings, 0 replies; 6+ messages in thread From: Joe Conway @ 2016-12-22 17:49 UTC (permalink / raw) To: pgsql-committers Make dblink try harder to form useful error messages When libpq encounters a connection-level error, e.g. runs out of memory while forming a result, there will be no error associated with PGresult, but a message will be placed into PGconn's error buffer. postgres_fdw takes care to use the PGconn error message when PGresult does not have one, but dblink has been negligent in that regard. Modify dblink to mirror what postgres_fdw has been doing. Back-patch to all supported branches. Author: Joe Conway Reviewed-By: Tom Lane Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com Branch ------ REL9_5_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/80ca22aa60a6138b5ada890339dd6a6e2397222d Modified Files -------------- contrib/dblink/dblink.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make dblink try harder to form useful error messages @ 2016-12-22 17:49 Joe Conway <mail@joeconway.com> 0 siblings, 0 replies; 6+ messages in thread From: Joe Conway @ 2016-12-22 17:49 UTC (permalink / raw) To: pgsql-committers Make dblink try harder to form useful error messages When libpq encounters a connection-level error, e.g. runs out of memory while forming a result, there will be no error associated with PGresult, but a message will be placed into PGconn's error buffer. postgres_fdw takes care to use the PGconn error message when PGresult does not have one, but dblink has been negligent in that regard. Modify dblink to mirror what postgres_fdw has been doing. Back-patch to all supported branches. Author: Joe Conway Reviewed-By: Tom Lane Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com Branch ------ REL9_4_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/76943f54a743e3d7875a6772fec89bb57a8f2118 Modified Files -------------- contrib/dblink/dblink.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make dblink try harder to form useful error messages @ 2016-12-22 17:49 Joe Conway <mail@joeconway.com> 0 siblings, 0 replies; 6+ messages in thread From: Joe Conway @ 2016-12-22 17:49 UTC (permalink / raw) To: pgsql-committers Make dblink try harder to form useful error messages When libpq encounters a connection-level error, e.g. runs out of memory while forming a result, there will be no error associated with PGresult, but a message will be placed into PGconn's error buffer. postgres_fdw takes care to use the PGconn error message when PGresult does not have one, but dblink has been negligent in that regard. Modify dblink to mirror what postgres_fdw has been doing. Back-patch to all supported branches. Author: Joe Conway Reviewed-By: Tom Lane Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com Branch ------ REL9_3_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/9b8507bfae9119427a5c3acf037c466a7e3d7046 Modified Files -------------- contrib/dblink/dblink.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Make dblink try harder to form useful error messages @ 2016-12-22 17:49 Joe Conway <mail@joeconway.com> 0 siblings, 0 replies; 6+ messages in thread From: Joe Conway @ 2016-12-22 17:49 UTC (permalink / raw) To: pgsql-committers Make dblink try harder to form useful error messages When libpq encounters a connection-level error, e.g. runs out of memory while forming a result, there will be no error associated with PGresult, but a message will be placed into PGconn's error buffer. postgres_fdw takes care to use the PGconn error message when PGresult does not have one, but dblink has been negligent in that regard. Modify dblink to mirror what postgres_fdw has been doing. Back-patch to all supported branches. Author: Joe Conway Reviewed-By: Tom Lane Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com Branch ------ REL9_2_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/44de099f89c2a2d94c78f80f09555fd9b5792583 Modified Files -------------- contrib/dblink/dblink.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2016-12-22 17:49 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2016-12-22 17:49 pgsql: Make dblink try harder to form useful error messages Joe Conway <mail@joeconway.com> 2016-12-22 17:49 pgsql: Make dblink try harder to form useful error messages Joe Conway <mail@joeconway.com> 2016-12-22 17:49 pgsql: Make dblink try harder to form useful error messages Joe Conway <mail@joeconway.com> 2016-12-22 17:49 pgsql: Make dblink try harder to form useful error messages Joe Conway <mail@joeconway.com> 2016-12-22 17:49 pgsql: Make dblink try harder to form useful error messages Joe Conway <mail@joeconway.com> 2016-12-22 17:49 pgsql: Make dblink try harder to form useful error messages Joe Conway <mail@joeconway.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox