agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedpgsql: Message style fixes
13+ messages / 5 participants
[nested] [flat]
* pgsql: Message style fixes
@ 2017-09-11 15:34 Peter Eisentraut <peter_e@gmx.net>
2017-09-11 15:58 ` Re: pgsql: Message style fixes Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 13+ messages in thread
From: Peter Eisentraut @ 2017-09-11 15:34 UTC (permalink / raw)
To: pgsql-committers
Message style fixes
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/821fb8cdbf700a8aadbe12d5b46ca4e61be5a8a8
Modified Files
--------------
doc/src/sgml/catalogs.sgml | 2 +-
doc/src/sgml/perform.sgml | 4 ++--
doc/src/sgml/ref/create_statistics.sgml | 10 +++++-----
doc/src/sgml/ref/psql-ref.sgml | 2 +-
src/backend/access/transam/twophase.c | 14 +++++++-------
src/backend/access/transam/xlog.c | 2 +-
src/backend/commands/publicationcmds.c | 2 +-
src/backend/commands/statscmds.c | 10 +++++-----
src/backend/commands/tablecmds.c | 2 +-
src/backend/commands/trigger.c | 2 +-
src/backend/executor/execReplication.c | 4 ++--
src/backend/libpq/hba.c | 2 +-
src/backend/replication/logical/relation.c | 5 ++---
src/backend/replication/logical/worker.c | 6 +++---
src/backend/replication/pgoutput/pgoutput.c | 2 +-
src/backend/rewrite/rewriteDefine.c | 4 ++--
src/backend/storage/lmgr/predicate.c | 2 +-
src/backend/utils/adt/int8.c | 8 ++++----
src/backend/utils/adt/jsonfuncs.c | 6 +++---
src/backend/utils/adt/mac8.c | 4 ++--
src/backend/utils/adt/numutils.c | 12 ++++++------
src/backend/utils/adt/txid.c | 14 +++++++-------
src/backend/utils/misc/guc.c | 6 +++---
src/backend/utils/time/snapmgr.c | 2 +-
src/bin/psql/variables.c | 2 +-
src/include/catalog/pg_statistic_ext.h | 2 +-
src/test/regress/expected/alter_table.out | 2 +-
src/test/regress/expected/foreign_data.out | 2 +-
src/test/regress/expected/json.out | 26 +++++++++++++-------------
src/test/regress/expected/jsonb.out | 26 +++++++++++++-------------
src/test/regress/expected/psql.out | 4 ++--
src/test/regress/expected/rules.out | 4 ++--
src/test/regress/expected/stats_ext.out | 4 ++--
src/test/regress/expected/triggers.out | 2 +-
34 files changed, 100 insertions(+), 101 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pgsql: Message style fixes
2017-09-11 15:34 pgsql: Message style fixes Peter Eisentraut <peter_e@gmx.net>
@ 2017-09-11 15:58 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-09-11 16:35 ` Re: pgsql: Message style fixes Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 1 reply; 13+ messages in thread
From: Tom Lane @ 2017-09-11 15:58 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-committers
Peter Eisentraut <peter_e@gmx.net> writes:
> Message style fixes
Hm. Aren't your changes in int8.c and numutils.c
reverting changes that were made intentionally in
commit 9a34123bc315e55b33038464422ef1cd2b67dab2 ?
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pgsql: Message style fixes
2017-09-11 15:34 pgsql: Message style fixes Peter Eisentraut <peter_e@gmx.net>
2017-09-11 15:58 ` Re: pgsql: Message style fixes Tom Lane <tgl@sss.pgh.pa.us>
@ 2017-09-11 16:35 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 0 replies; 13+ messages in thread
From: Peter Eisentraut @ 2017-09-11 16:35 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers
On 9/11/17 11:58, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> Message style fixes
>
> Hm. Aren't your changes in int8.c and numutils.c
> reverting changes that were made intentionally in
> commit 9a34123bc315e55b33038464422ef1cd2b67dab2 ?
Yeah, but that part of that change was apparently mistaken. (These
routines don't use "integer" as a specific type but as a general
description of numbers.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2017-09-11 15:34 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 13+ messages in thread
From: Peter Eisentraut @ 2017-09-11 15:34 UTC (permalink / raw)
To: pgsql-committers
Message style fixes
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f552d18f3edd178598564d20f09577a623b1e302
Modified Files
--------------
doc/src/sgml/catalogs.sgml | 2 +-
doc/src/sgml/perform.sgml | 4 ++--
doc/src/sgml/ref/create_statistics.sgml | 10 +++++-----
doc/src/sgml/ref/psql-ref.sgml | 2 +-
src/backend/access/transam/twophase.c | 14 +++++++-------
src/backend/access/transam/xlog.c | 2 +-
src/backend/commands/publicationcmds.c | 2 +-
src/backend/commands/statscmds.c | 10 +++++-----
src/backend/commands/tablecmds.c | 2 +-
src/backend/commands/trigger.c | 2 +-
src/backend/executor/execReplication.c | 4 ++--
src/backend/libpq/hba.c | 2 +-
src/backend/replication/logical/relation.c | 5 ++---
src/backend/replication/logical/worker.c | 6 +++---
src/backend/replication/pgoutput/pgoutput.c | 2 +-
src/backend/rewrite/rewriteDefine.c | 4 ++--
src/backend/storage/lmgr/predicate.c | 2 +-
src/backend/utils/adt/int8.c | 8 ++++----
src/backend/utils/adt/jsonfuncs.c | 6 +++---
src/backend/utils/adt/mac8.c | 4 ++--
src/backend/utils/adt/numutils.c | 12 ++++++------
src/backend/utils/adt/txid.c | 14 +++++++-------
src/backend/utils/misc/guc.c | 6 +++---
src/backend/utils/time/snapmgr.c | 2 +-
src/bin/psql/variables.c | 2 +-
src/include/catalog/pg_statistic_ext.h | 2 +-
src/test/regress/expected/alter_table.out | 2 +-
src/test/regress/expected/foreign_data.out | 2 +-
src/test/regress/expected/json.out | 26 +++++++++++++-------------
src/test/regress/expected/jsonb.out | 26 +++++++++++++-------------
src/test/regress/expected/psql.out | 4 ++--
src/test/regress/expected/rules.out | 4 ++--
src/test/regress/expected/stats_ext.out | 4 ++--
src/test/regress/expected/triggers.out | 2 +-
34 files changed, 100 insertions(+), 101 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2019-04-30 14:37 Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 0 replies; 13+ messages in thread
From: Alvaro Herrera @ 2019-04-30 14:37 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9f8b717a80c59e4a8e8091a8ff6c6f7666a69c33
Modified Files
--------------
src/backend/access/table/tableamapi.c | 6 +++---
src/backend/access/transam/twophase.c | 4 ++--
src/backend/commands/indexcmds.c | 2 +-
src/backend/commands/tablecmds.c | 6 ++++--
src/backend/utils/misc/guc.c | 4 ++--
src/test/regress/output/tablespace.source | 2 +-
6 files changed, 13 insertions(+), 11 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2019-09-06 21:08 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 13+ messages in thread
From: Peter Eisentraut @ 2019-09-06 21:08 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c5bc7050aff1d1bba6532377fe37b351581661a8
Modified Files
--------------
src/bin/psql/command.c | 2 +-
src/bin/psql/help.c | 2 +-
src/interfaces/ecpg/ecpglib/error.c | 2 +-
src/interfaces/ecpg/ecpglib/prepare.c | 4 ++--
src/interfaces/ecpg/preproc/ecpg.trailer | 2 +-
src/interfaces/ecpg/test/expected/sql-declare.stderr | 8 ++++----
src/interfaces/libpq/fe-connect.c | 10 +++++-----
7 files changed, 15 insertions(+), 15 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2019-09-06 21:08 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 13+ messages in thread
From: Peter Eisentraut @ 2019-09-06 21:08 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2552c78c18a1cb11d0f49a3af0660a477f81839d
Modified Files
--------------
src/bin/psql/command.c | 2 +-
src/bin/psql/help.c | 2 +-
src/interfaces/ecpg/ecpglib/error.c | 2 +-
src/interfaces/ecpg/ecpglib/prepare.c | 4 ++--
src/interfaces/ecpg/preproc/ecpg.trailer | 2 +-
src/interfaces/ecpg/test/expected/sql-declare.stderr | 8 ++++----
src/interfaces/libpq/fe-connect.c | 10 +++++-----
7 files changed, 15 insertions(+), 15 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2019-09-23 11:40 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 13+ messages in thread
From: Peter Eisentraut @ 2019-09-23 11:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/887248e97e2da6f602ddf22aaaaf8cb41d0d010d
Modified Files
--------------
contrib/test_decoding/expected/slot.out | 2 +-
src/backend/access/transam/xlog.c | 2 +-
src/backend/access/transam/xlogfuncs.c | 2 +-
src/backend/catalog/pg_aggregate.c | 4 ++--
src/backend/libpq/auth.c | 2 +-
src/backend/replication/basebackup.c | 8 +++++---
src/backend/replication/slotfuncs.c | 2 +-
src/backend/storage/file/fd.c | 4 ++--
src/backend/utils/adt/ri_triggers.c | 2 +-
src/backend/utils/misc/guc.c | 6 +++---
src/test/regress/expected/foreign_key.out | 10 +++++-----
11 files changed, 23 insertions(+), 21 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2019-09-23 11:40 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 13+ messages in thread
From: Peter Eisentraut @ 2019-09-23 11:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/516a4c116c5c4206388828f7e2b4e75fa1b1fc87
Modified Files
--------------
contrib/test_decoding/expected/slot.out | 2 +-
src/backend/access/transam/xlog.c | 2 +-
src/backend/access/transam/xlogfuncs.c | 2 +-
src/backend/catalog/pg_aggregate.c | 4 ++--
src/backend/libpq/auth.c | 2 +-
src/backend/replication/basebackup.c | 8 +++++---
src/backend/replication/slotfuncs.c | 2 +-
src/backend/storage/file/fd.c | 4 ++--
src/backend/utils/adt/ri_triggers.c | 2 +-
src/backend/utils/misc/guc.c | 6 +++---
src/test/regress/expected/foreign_key.out | 10 +++++-----
11 files changed, 23 insertions(+), 21 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2022-09-07 15:34 Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 0 replies; 13+ messages in thread
From: Alvaro Herrera @ 2022-09-07 15:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4b4663fb4a704b7a145ed6ec018b1f0c116eeb6b
Modified Files
--------------
src/backend/replication/logical/worker.c | 6 +++---
src/backend/utils/init/postinit.c | 7 ++++---
src/backend/utils/misc/guc.c | 2 +-
src/test/subscription/t/029_on_error.pl | 2 +-
4 files changed, 9 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2022-09-07 15:34 Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 0 replies; 13+ messages in thread
From: Alvaro Herrera @ 2022-09-07 15:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/144cefac92644f338c35b77f6d9b4a9456c80563
Modified Files
--------------
src/backend/replication/logical/worker.c | 6 +++---
src/backend/utils/init/postinit.c | 7 ++++---
src/backend/utils/misc/guc.c | 2 +-
src/test/subscription/t/029_on_error.pl | 2 +-
4 files changed, 9 insertions(+), 8 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2026-07-21 13:43 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 13+ messages in thread
From: Peter Eisentraut @ 2026-07-21 13:43 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Change DETAIL messages to conform to the style guide by capitalizing
the first word of sentences and ending sentences with a period.
Author: Peter Smith <peter.b.smith@fujitsu.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: vignesh C <vignesh21.gmail.com>
Reviewed-by: Xiaopeng Wang <wxp_728.163.com>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPszSntkUgN%2BQa9matGY6MLEoFGSuVbuKDgnnTdZ7YPRwg%4...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c90c9678e533e622a393d3296f8fe4b9e5e317af
Modified Files
--------------
contrib/dblink/dblink.c | 2 +-
contrib/passwordcheck/expected/passwordcheck.out | 2 +-
contrib/passwordcheck/expected/passwordcheck_1.out | 2 +-
contrib/passwordcheck/passwordcheck.c | 2 +-
contrib/pg_stash_advice/expected/pg_stash_advice.out | 2 +-
contrib/pg_stash_advice/expected/pg_stash_advice_utf8.out | 2 +-
contrib/pg_stash_advice/pg_stash_advice.c | 8 ++++----
contrib/postgres_fdw/expected/postgres_fdw.out | 2 +-
src/backend/commands/copyto.c | 2 +-
src/backend/commands/extension.c | 2 +-
src/backend/commands/tablecmds.c | 10 +++++-----
src/backend/libpq/be-secure-openssl.c | 2 +-
src/test/modules/test_extensions/expected/test_extensions.out | 2 +-
src/test/regress/expected/create_view.out | 2 +-
src/test/regress/expected/rangefuncs.out | 2 +-
15 files changed, 22 insertions(+), 22 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Message style fixes
@ 2026-07-21 13:43 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 13+ messages in thread
From: Peter Eisentraut @ 2026-07-21 13:43 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message style fixes
Change DETAIL messages to conform to the style guide by capitalizing
the first word of sentences and ending sentences with a period.
Author: Peter Smith <peter.b.smith@fujitsu.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: vignesh C <vignesh21.gmail.com>
Reviewed-by: Xiaopeng Wang <wxp_728.163.com>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPszSntkUgN%2BQa9matGY6MLEoFGSuVbuKDgnnTdZ7YPRwg%4...
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4d529d77f8f0e2bdbd6bc2119bb09eebffd23583
Modified Files
--------------
contrib/dblink/dblink.c | 2 +-
contrib/passwordcheck/expected/passwordcheck.out | 2 +-
contrib/passwordcheck/expected/passwordcheck_1.out | 2 +-
contrib/passwordcheck/passwordcheck.c | 2 +-
contrib/pg_stash_advice/expected/pg_stash_advice.out | 2 +-
contrib/pg_stash_advice/expected/pg_stash_advice_utf8.out | 2 +-
contrib/pg_stash_advice/pg_stash_advice.c | 8 ++++----
contrib/postgres_fdw/expected/postgres_fdw.out | 2 +-
src/backend/commands/copyto.c | 2 +-
src/backend/commands/extension.c | 2 +-
src/backend/commands/tablecmds.c | 10 +++++-----
src/backend/libpq/be-secure-openssl.c | 2 +-
src/test/modules/test_extensions/expected/test_extensions.out | 2 +-
src/test/regress/expected/create_view.out | 2 +-
src/test/regress/expected/rangefuncs.out | 2 +-
15 files changed, 22 insertions(+), 22 deletions(-)
^ permalink raw reply [nested|flat] 13+ messages in thread
end of thread, other threads:[~2026-07-21 13:43 UTC | newest]
Thread overview: 13+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-09-11 15:34 pgsql: Message style fixes Peter Eisentraut <peter_e@gmx.net>
2017-09-11 15:58 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-09-11 16:35 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-09-11 15:34 pgsql: Message style fixes Peter Eisentraut <peter_e@gmx.net>
2019-04-30 14:37 pgsql: Message style fixes Alvaro Herrera <alvherre@alvh.no-ip.org>
2019-09-06 21:08 pgsql: Message style fixes Peter Eisentraut <peter@eisentraut.org>
2019-09-06 21:08 pgsql: Message style fixes Peter Eisentraut <peter@eisentraut.org>
2019-09-23 11:40 pgsql: Message style fixes Peter Eisentraut <peter@eisentraut.org>
2019-09-23 11:40 pgsql: Message style fixes Peter Eisentraut <peter@eisentraut.org>
2022-09-07 15:34 pgsql: Message style fixes Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-09-07 15:34 pgsql: Message style fixes Alvaro Herrera <alvherre@alvh.no-ip.org>
2026-07-21 13:43 pgsql: Message style fixes Peter Eisentraut <peter@eisentraut.org>
2026-07-21 13:43 pgsql: Message style fixes Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox