pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix mistaken failure to allow parallelism in corner case.
4+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2017-10-27 94d622f27b 69fc2ca4cc Move new structure member to the end.
* pgsql: Fix mistaken failure to allow parallelism in corner case.
@ 2017-10-27 14:12 Robert Haas <rhaas@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: Robert Haas @ 2017-10-27 14:12 UTC (permalink / raw)
To: pgsql-committers
Fix mistaken failure to allow parallelism in corner case.
If we try to run a parallel plan in serial mode because, for example,
it's going to be scanned via a cursor, but for some reason we're
already in parallel mode (for example because an outer query is
running in parallel), we'd incorrectly try to launch workers.
Fix by adding a flag to the EState, so that we can be certain that
ExecutePlan() and ExecGather()/ExecGatherMerge() will have the same
idea about whether we are executing serially or in parallel.
Report and fix by Amit Kapila with help from Kuntal Ghosh. A few
tweaks by me.
Discussion: http://postgr.es/m/CAA4eK1+_BuZrmVCeua5Eqnm4Co9DAXdM5HPAOE2J19ePbR912Q@mail.gmail.com
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/965a16fa9f8c316c30f4ada3c1c98b5dd4666f25
Modified Files
--------------
src/backend/executor/execMain.c | 1 +
src/backend/executor/execUtils.c | 2 ++
src/backend/executor/nodeGather.c | 2 +-
src/backend/executor/nodeGatherMerge.c | 2 +-
src/include/nodes/execnodes.h | 2 ++
5 files changed, 7 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix mistaken failure to allow parallelism in corner case.
@ 2017-10-27 14:12 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Robert Haas @ 2017-10-27 14:12 UTC (permalink / raw)
To: pgsql-committers
Fix mistaken failure to allow parallelism in corner case.
If we try to run a parallel plan in serial mode because, for example,
it's going to be scanned via a cursor, but for some reason we're
already in parallel mode (for example because an outer query is
running in parallel), we'd incorrectly try to launch workers.
Fix by adding a flag to the EState, so that we can be certain that
ExecutePlan() and ExecGather()/ExecGatherMerge() will have the same
idea about whether we are executing serially or in parallel.
Report and fix by Amit Kapila with help from Kuntal Ghosh. A few
tweaks by me.
Discussion: http://postgr.es/m/CAA4eK1+_BuZrmVCeua5Eqnm4Co9DAXdM5HPAOE2J19ePbR912Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/639c1a6bb9ee08fe4757a6fab1ddbd01291515e1
Modified Files
--------------
src/backend/executor/execMain.c | 1 +
src/backend/executor/execUtils.c | 2 ++
src/backend/executor/nodeGather.c | 2 +-
src/backend/executor/nodeGatherMerge.c | 2 +-
src/include/nodes/execnodes.h | 2 ++
5 files changed, 7 insertions(+), 2 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix mistaken failure to allow parallelism in corner case.
@ 2017-10-27 14:12 Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Robert Haas @ 2017-10-27 14:12 UTC (permalink / raw)
To: pgsql-committers
Fix mistaken failure to allow parallelism in corner case.
If we try to run a parallel plan in serial mode because, for example,
it's going to be scanned via a cursor, but for some reason we're
already in parallel mode (for example because an outer query is
running in parallel), we'd incorrectly try to launch workers.
Fix by adding a flag to the EState, so that we can be certain that
ExecutePlan() and ExecGather()/ExecGatherMerge() will have the same
idea about whether we are executing serially or in parallel.
Report and fix by Amit Kapila with help from Kuntal Ghosh. A few
tweaks by me.
Discussion: http://postgr.es/m/CAA4eK1+_BuZrmVCeua5Eqnm4Co9DAXdM5HPAOE2J19ePbR912Q@mail.gmail.com
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/036b6bd50365b9ae6ec0b4cb21d172510ef440a9
Modified Files
--------------
src/backend/executor/execMain.c | 5 +----
src/backend/executor/execUtils.c | 2 ++
src/backend/executor/nodeGather.c | 2 +-
src/include/nodes/execnodes.h | 2 ++
4 files changed, 6 insertions(+), 5 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Fix mistaken failure to allow parallelism in corner case.
@ 2017-10-27 14:19 Tom Lane <tgl@sss.pgh.pa.us>
parent: Robert Haas <rhaas@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Tom Lane @ 2017-10-27 14:19 UTC (permalink / raw)
To: Robert Haas <rhaas@postgresql.org>; +Cc: pgsql-committers
Robert Haas <rhaas@postgresql.org> writes:
> Fix mistaken failure to allow parallelism in corner case.
You can't insert fields into the middle of a widely-known struct
in the back branches. In v10, this broke ABI compatibility for
any extension touching estate->es_query_dsa, which seems unlikely
to be the empty set.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2017-10-27 14:19 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 14:12 pgsql: Fix mistaken failure to allow parallelism in corner case. Robert Haas <rhaas@postgresql.org>
2017-10-27 14:12 pgsql: Fix mistaken failure to allow parallelism in corner case. Robert Haas <rhaas@postgresql.org>
2017-10-27 14:19 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-10-27 14:12 pgsql: Fix mistaken failure to allow parallelism in corner case. Robert Haas <rhaas@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox