pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove redundant initialization of a local variable.
2+ messages / 1 participants
[nested] [flat]

* pgsql: Remove redundant initialization of a local variable.
@ 2018-02-19 04:33  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2018-02-19 04:33 UTC (permalink / raw)
  To: pgsql-committers

Remove redundant initialization of a local variable.

In what was doubtless a typo, commit bf6c614a2 introduced a duplicate
initialization of a local variable.  This made Coverity unhappy, as well
as pretty much anybody reading the code.  We don't even have a real use
for the local variable, so just remove it.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8c44802b6ed4846accb08e2ffe93040b8b42aae9

Modified Files
--------------
src/backend/executor/nodeGroup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Remove redundant initialization of BrinMemTuple.
@ 2022-01-04 21:53  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 2+ messages in thread

From: Tom Lane @ 2022-01-04 21:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove redundant initialization of BrinMemTuple.

brin_new_memtuple already did this, so there's no need
for initialize_brin_buildstate to do it again.

Richard Guo, reviewed by Bharath Rupireddy

Discussion: https://postgr.es/m/CAMbWs4-kYYpKNOdiWtsCZ3jbkFFj4nhOVH22JH7dsrMYX=aGjg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/913a03ec29abcb6c20e5941e5f3ac0578619cd3e

Modified Files
--------------
src/backend/access/brin/brin.c | 2 --
1 file changed, 2 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2022-01-04 21:53 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-02-19 04:33 pgsql: Remove redundant initialization of a local variable. Tom Lane <tgl@sss.pgh.pa.us>
2022-01-04 21:53 pgsql: Remove redundant initialization of BrinMemTuple. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox