Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqk2U-0003oA-Ur for pgsql-committers@arkaria.postgresql.org; Tue, 27 Feb 2018 18:31:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eqk2T-0007Xh-Dy for pgsql-committers@arkaria.postgresql.org; Tue, 27 Feb 2018 18:31:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqjzG-00059R-I6 for pgsql-committers@lists.postgresql.org; Tue, 27 Feb 2018 18:28:26 +0000 Received: from mahout.postgresql.org ([2001:4800:1501:1::227]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eqjz9-0000b3-Bz for pgsql-committers@postgresql.org; Tue, 27 Feb 2018 18:28:25 +0000 Received: from gemulon.postgresql.org ([2001:4800:1501:1::198]) by mahout.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eqjz7-0000lG-3K for pgsql-committers@postgresql.org; Tue, 27 Feb 2018 18:28:17 +0000 Received: from git by gemulon.postgresql.org with local (Exim 4.89) (envelope-from ) id 1eqjz6-00043s-6s for pgsql-committers@postgresql.org; Tue, 27 Feb 2018 18:28:16 +0000 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 To: pgsql-committers@postgresql.org From: Tom Lane Subject: pgsql: Prevent dangling-pointer access when update trigger returns old Message-Id: Date: Tue, 27 Feb 2018 18:28:16 +0000 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk UHJldmVudCBkYW5nbGluZy1wb2ludGVyIGFjY2VzcyB3aGVuIHVwZGF0ZSB0cmlnZ2VyIHJldHVy bnMgb2xkIHR1cGxlLgoKQSBiZWZvcmUtdXBkYXRlIHJvdyB0cmlnZ2VyIG1heSBjaG9vc2UgdG8g cmV0dXJuIHRoZSAibmV3IiBvciAib2xkIiB0dXBsZQp1bm1vZGlmaWVkLiAgRXhlY0JSVXBkYXRl VHJpZ2dlcnMgZmFpbGVkIHRvIGNvbnNpZGVyIHRoZSBzZWNvbmQKcG9zc2liaWxpdHksIGFuZCB3 b3VsZCBwcm9jZWVkIHRvIGZyZWUgdGhlICJvbGQiIHR1cGxlIGV2ZW4gaWYgaXQgd2FzIHRoZQpv bmUgcmV0dXJuZWQsIGxlYWRpbmcgdG8gc3Vic2VxdWVudCBhY2Nlc3MgdG8gYWxyZWFkeS1kZWFs bG9jYXRlZCBtZW1vcnkuCkluIGRlYnVnIGJ1aWxkcyB0aGlzIHJlbGlhYmx5IGxlYWRzIHRvIGFu ICJpbnZhbGlkIG1lbW9yeSBhbGxvYyByZXF1ZXN0CnNpemUiIGZhaWx1cmU7IGluIHByb2R1Y3Rp b24gYnVpbGRzIGl0IG1pZ2h0IGFjY2lkZW50YWxseSB3b3JrLCBidXQgZGF0YQpjb3JydXB0aW9u IGlzIGFsc28gcG9zc2libGUuCgpUaGlzIGlzIGEgdmVyeSBvbGQgYnVnLiAgVGhlcmUgYXJlIHBy b2JhYmx5IGEgY291cGxlIG9mIHJlYXNvbnMgaXQgaGFzbid0CmJlZW4gbm90aWNlZCB1cCB0byBu b3cuICBJdCB3b3VsZCBiZSBtb3JlIHVzdWFsIHRvIHJldHVybiBOVUxMIGlmIG9uZQp3YW50ZWQg dG8gc3VwcHJlc3MgdGhlIHVwZGF0ZSBhY3Rpb247IHJldHVybmluZyAib2xkIiBpcyBzaWduaWZp Y2FudGx5IGxlc3MKZWZmaWNpZW50IHNpbmNlIHRoZSB1cGRhdGUgd2lsbCBvY2N1ciBhbnl3YXku ICBBbHNvLCBub25lIG9mIHRoZSBzdGFuZGFyZApQTHMgd291bGQgZXZlciBjYXVzZSB0aGlzIGJl Y2F1c2UgdGhleSBhbGwgcmV0dXJuZWQgZnJlc2hseS1tYW51ZmFjdHVyZWQKdHVwbGVzIGV2ZW4g aWYgdGhleSB3ZXJlIGp1c3QgY29weWluZyAib2xkIi4gIEJ1dCBjb21taXQgNGI5M2Y1Nzk5IGNo YW5nZWQKdGhhdCBmb3IgcGxwZ3NxbCwgbWFraW5nIGl0IHBvc3NpYmxlIHRvIHNlZSB0aGUgYnVn IHdpdGggYSBwbHBnc3FsIHRyaWdnZXIuClN0aWxsLCB0aGlzIGlzIGNlcnRhaW5seSBsZWdhbCBi ZWhhdmlvciBmb3IgYSB0cmlnZ2VyIGZ1bmN0aW9uLCBzbyBpdCdzCkV4ZWNCUlVwZGF0ZVRyaWdn ZXJzJ3MgZmF1bHQgbm90IHBscGdzcWwncy4KCkl0IHNlZW1zIHdvcnRoIGNyZWF0aW5nIGEgdGVz dCBjYXNlIHRoYXQgZXhlcmNpc2VzIHJldHVybmluZyAib2xkIiBkaXJlY3RseQp3aXRoIGEgQy1s YW5ndWFnZSB0cmlnZ2VyOyB0ZXN0aW5nIHRoaXMgdGhyb3VnaCBwbHBnc3FsIHNlZW1zIHVucmVs aWFibGUKYmVjYXVzZSBpdHMgYmVoYXZpb3IgbWlnaHQgY2hhbmdlIGFnYWluLgoKUmVwb3J0IGFu ZCBmaXggYnkgUnVzaGFiaCBMYXRoaWE7IHJlZ3Jlc3Npb24gdGVzdCBjYXNlIGJ5IG1lLgpCYWNr LXBhdGNoIHRvIGFsbCBzdXBwb3J0ZWQgYnJhbmNoZXMuCgpEaXNjdXNzaW9uOiBodHRwczovL3Bv c3Rnci5lcy9tL0NBR1BxUWYxUDRwamlOUHJNb2Y9UF8xNkUtREZqdDQ1N2orbkgyZXgzPW5CVGV3 N3RYd0BtYWlsLmdtYWlsLmNvbQoKQnJhbmNoCi0tLS0tLQpSRUxfMTBfU1RBQkxFCgpEZXRhaWxz Ci0tLS0tLS0KaHR0cHM6Ly9naXQucG9zdGdyZXNxbC5vcmcvcGcvY29tbWl0ZGlmZi9iNDVmODIx ZTIyMjZiZDEwZDhhNmUyZTYwMWJiYjFmZTE3YzU2ODZmCgpNb2RpZmllZCBGaWxlcwotLS0tLS0t LS0tLS0tLQpzcmMvYmFja2VuZC9jb21tYW5kcy90cmlnZ2VyLmMgICAgICAgICAgICAgICAgICAg fCAgMiArLQpzcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3RyaWdnZXJzLm91dCAgICAgICAgICAg fCAyNiArKysrKysrKysrKysrKysrKysrKysrKysKc3JjL3Rlc3QvcmVncmVzcy9pbnB1dC9jcmVh dGVfZnVuY3Rpb25fMS5zb3VyY2UgIHwgIDUgKysrKysKc3JjL3Rlc3QvcmVncmVzcy9vdXRwdXQv Y3JlYXRlX2Z1bmN0aW9uXzEuc291cmNlIHwgIDQgKysrKwpzcmMvdGVzdC9yZWdyZXNzL3JlZ3Jl c3MuYyAgICAgICAgICAgICAgICAgICAgICAgfCAxNiArKysrKysrKysrKysrKysKc3JjL3Rlc3Qv cmVncmVzcy9zcWwvdHJpZ2dlcnMuc3FsICAgICAgICAgICAgICAgIHwgMTYgKysrKysrKysrKysr KysrCjYgZmlsZXMgY2hhbmdlZCwgNjggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoK