pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix pgbench lexer's "continuation" rule to cope with Windows new 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix pgbench lexer's "continuation" rule to cope with Windows new @ 2018-09-17 16:11 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2018-09-17 16:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pgbench lexer's "continuation" rule to cope with Windows newlines. Our general practice in frontend code is to accept input with either Unix-style newlines (\n) or DOS-style (\r\n). pgbench was mostly down with that, but its rule for line continuations (backslash-newline) was not. This had been masked on Windows buildfarm machines before commit 0ba06e0bf by use of Windows text mode to read files. We could have fixed it by forcing text mode again, but it's better to fix the parsing code so that Windows-style text files on Unix systems don't cause problems. Back-patch to v10 where pgbench grew line continuations. Discussion: https://postgr.es/m/17194.1537191697@sss.pgh.pa.us Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d45f157e8b07aee455df0bcc76fdf4e9963c0200 Modified Files -------------- src/bin/pgbench/exprscan.l | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix pgbench lexer's "continuation" rule to cope with Windows new @ 2018-09-17 16:11 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2018-09-17 16:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pgbench lexer's "continuation" rule to cope with Windows newlines. Our general practice in frontend code is to accept input with either Unix-style newlines (\n) or DOS-style (\r\n). pgbench was mostly down with that, but its rule for line continuations (backslash-newline) was not. This had been masked on Windows buildfarm machines before commit 0ba06e0bf by use of Windows text mode to read files. We could have fixed it by forcing text mode again, but it's better to fix the parsing code so that Windows-style text files on Unix systems don't cause problems. Back-patch to v10 where pgbench grew line continuations. Discussion: https://postgr.es/m/17194.1537191697@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/db37ab2c60b877b977f531bcd680848ee4511537 Modified Files -------------- src/bin/pgbench/exprscan.l | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix pgbench lexer's "continuation" rule to cope with Windows new @ 2018-09-17 16:11 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2018-09-17 16:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix pgbench lexer's "continuation" rule to cope with Windows newlines. Our general practice in frontend code is to accept input with either Unix-style newlines (\n) or DOS-style (\r\n). pgbench was mostly down with that, but its rule for line continuations (backslash-newline) was not. This had been masked on Windows buildfarm machines before commit 0ba06e0bf by use of Windows text mode to read files. We could have fixed it by forcing text mode again, but it's better to fix the parsing code so that Windows-style text files on Unix systems don't cause problems. Back-patch to v10 where pgbench grew line continuations. Discussion: https://postgr.es/m/17194.1537191697@sss.pgh.pa.us Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3ea7e015f37afd615234d94181840b8e6e44e6ed Modified Files -------------- src/bin/pgbench/exprscan.l | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2018-09-17 16:11 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2018-09-17 16:11 pgsql: Fix pgbench lexer's "continuation" rule to cope with Windows new Tom Lane <tgl@sss.pgh.pa.us> 2018-09-17 16:11 pgsql: Fix pgbench lexer's "continuation" rule to cope with Windows new Tom Lane <tgl@sss.pgh.pa.us> 2018-09-17 16:11 pgsql: Fix pgbench lexer's "continuation" rule to cope with Windows new Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox