pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
8+ messages / 1 participants
[nested] [flat]

* pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
@ 2018-11-19 17:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 8+ messages in thread

From: Tom Lane @ 2018-11-19 17:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

The test case that Autoconf uses to discover whether a function has
been declared doesn't work reliably with clang, because clang reports
a warning not an error if the name is a known built-in function.
On some platforms, this results in a lot of compile-time warnings about
strlcpy and related functions not having been declared.

There is a fix for this (by Noah Misch) in the upstream Autoconf sources,
but since they've not made a release in years and show no indication of
doing so anytime soon, let's just absorb their fix directly.  We can
revert this when and if we update to a newer Autoconf release.

Back-patch to all supported branches.

Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/16fbac39ff68a737317f6fc7be78cc93a14856af

Modified Files
--------------
aclocal.m4            |   1 +
config/check_decls.m4 | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++
configure             | 104 ++++++++++++++++++++++++++++++++++++++++++--
configure.in          |   9 ++--
4 files changed, 223 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
@ 2018-11-19 17:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 8+ messages in thread

From: Tom Lane @ 2018-11-19 17:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

The test case that Autoconf uses to discover whether a function has
been declared doesn't work reliably with clang, because clang reports
a warning not an error if the name is a known built-in function.
On some platforms, this results in a lot of compile-time warnings about
strlcpy and related functions not having been declared.

There is a fix for this (by Noah Misch) in the upstream Autoconf sources,
but since they've not made a release in years and show no indication of
doing so anytime soon, let's just absorb their fix directly.  We can
revert this when and if we update to a newer Autoconf release.

Back-patch to all supported branches.

Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dcd6200165ca583cc1b0d436774cf4c3cf7e642d

Modified Files
--------------
aclocal.m4            |   1 +
config/check_decls.m4 | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++
configure             | 104 ++++++++++++++++++++++++++++++++++++++++++--
configure.in          |   9 ++--
4 files changed, 223 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
@ 2018-11-19 17:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 8+ messages in thread

From: Tom Lane @ 2018-11-19 17:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

The test case that Autoconf uses to discover whether a function has
been declared doesn't work reliably with clang, because clang reports
a warning not an error if the name is a known built-in function.
On some platforms, this results in a lot of compile-time warnings about
strlcpy and related functions not having been declared.

There is a fix for this (by Noah Misch) in the upstream Autoconf sources,
but since they've not made a release in years and show no indication of
doing so anytime soon, let's just absorb their fix directly.  We can
revert this when and if we update to a newer Autoconf release.

Back-patch to all supported branches.

Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/97b398ee5cb76963d1d409515232c294110f24b5

Modified Files
--------------
aclocal.m4            |   1 +
config/check_decls.m4 | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++
configure             | 100 +++++++++++++++++++++++++++++++++++++++++--
configure.in          |   5 ++-
4 files changed, 217 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
@ 2018-11-19 17:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 8+ messages in thread

From: Tom Lane @ 2018-11-19 17:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

The test case that Autoconf uses to discover whether a function has
been declared doesn't work reliably with clang, because clang reports
a warning not an error if the name is a known built-in function.
On some platforms, this results in a lot of compile-time warnings about
strlcpy and related functions not having been declared.

There is a fix for this (by Noah Misch) in the upstream Autoconf sources,
but since they've not made a release in years and show no indication of
doing so anytime soon, let's just absorb their fix directly.  We can
revert this when and if we update to a newer Autoconf release.

Back-patch to all supported branches.

Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8af1511e9cb5fbcfe47cb081ff9a1800fee73348

Modified Files
--------------
aclocal.m4            |   1 +
config/check_decls.m4 | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++
configure             | 100 +++++++++++++++++++++++++++++++++++++++++--
configure.in          |   5 ++-
4 files changed, 217 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
@ 2018-11-19 17:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 8+ messages in thread

From: Tom Lane @ 2018-11-19 17:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

The test case that Autoconf uses to discover whether a function has
been declared doesn't work reliably with clang, because clang reports
a warning not an error if the name is a known built-in function.
On some platforms, this results in a lot of compile-time warnings about
strlcpy and related functions not having been declared.

There is a fix for this (by Noah Misch) in the upstream Autoconf sources,
but since they've not made a release in years and show no indication of
doing so anytime soon, let's just absorb their fix directly.  We can
revert this when and if we update to a newer Autoconf release.

Back-patch to all supported branches.

Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/593320abac7d3caa9a5b2fe4c97da32714548c8e

Modified Files
--------------
aclocal.m4            |   1 +
config/check_decls.m4 | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++
configure             | 100 +++++++++++++++++++++++++++++++++++++++++--
configure.in          |   5 ++-
4 files changed, 217 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
@ 2018-11-19 17:02 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 8+ messages in thread

From: Tom Lane @ 2018-11-19 17:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

The test case that Autoconf uses to discover whether a function has
been declared doesn't work reliably with clang, because clang reports
a warning not an error if the name is a known built-in function.
On some platforms, this results in a lot of compile-time warnings about
strlcpy and related functions not having been declared.

There is a fix for this (by Noah Misch) in the upstream Autoconf sources,
but since they've not made a release in years and show no indication of
doing so anytime soon, let's just absorb their fix directly.  We can
revert this when and if we update to a newer Autoconf release.

Back-patch to all supported branches.

Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5fcb210e8d0ec5ba982daaa3c323b368c4554f8d

Modified Files
--------------
aclocal.m4            |   1 +
config/check_decls.m4 | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++
configure             | 100 +++++++++++++++++++++++++++++++++++++++++--
configure.in          |   5 ++-
4 files changed, 217 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
@ 2022-09-21 19:42 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 8+ messages in thread

From: Tom Lane @ 2022-09-21 19:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

Back-port commit 16fbac39f into 9.3 and 9.2, so that these
out-of-support branches can be built with clang without wading
through a pile of warnings about strlcpy and related functions.
check_decls.m4 required some adaptation to work with autoconf 2.63,
but nothing too major.

Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us
Discussion: https://postgr.es/m/1081321.1663775084@sss.pgh.pa.us

Branch
------
REL9_3_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f6ce9cee620702d8df551cd25761169f45503dc9

Modified Files
--------------
aclocal.m4            |   1 +
config/check_decls.m4 | 112 ++++++++++++++++++++++++++++
configure             | 202 +++++++++++++++++++++++++++++++++++++++++++++++---
configure.in          |   5 +-
4 files changed, 308 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan
@ 2022-09-21 19:42 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 8+ messages in thread

From: Tom Lane @ 2022-09-21 19:42 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix configure's AC_CHECK_DECLS tests to work correctly with clang.

Back-port commit 16fbac39f into 9.3 and 9.2, so that these
out-of-support branches can be built with clang without wading
through a pile of warnings about strlcpy and related functions.
check_decls.m4 required some adaptation to work with autoconf 2.63,
but nothing too major.

Discussion: https://postgr.es/m/26819.1542515567@sss.pgh.pa.us
Discussion: https://postgr.es/m/1081321.1663775084@sss.pgh.pa.us

Branch
------
REL9_2_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b8464d2f5da0d1abe0925c5712d0c4810986e629

Modified Files
--------------
aclocal.m4            |   1 +
config/check_decls.m4 | 112 +++++++++++++++++++++++++++++
configure             | 192 +++++++++++++++++++++++++++++++++++++++++++++++---
configure.in          |   5 +-
4 files changed, 300 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread


end of thread, other threads:[~2022-09-21 19:42 UTC | newest]

Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 17:02 pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan Tom Lane <tgl@sss.pgh.pa.us>
2018-11-19 17:02 pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan Tom Lane <tgl@sss.pgh.pa.us>
2018-11-19 17:02 pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan Tom Lane <tgl@sss.pgh.pa.us>
2018-11-19 17:02 pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan Tom Lane <tgl@sss.pgh.pa.us>
2018-11-19 17:02 pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan Tom Lane <tgl@sss.pgh.pa.us>
2018-11-19 17:02 pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan Tom Lane <tgl@sss.pgh.pa.us>
2022-09-21 19:42 pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan Tom Lane <tgl@sss.pgh.pa.us>
2022-09-21 19:42 pgsql: Fix configure's AC_CHECK_DECLS tests to work correctly with clan Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox