pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Import changes from IMath versions (1.3, 1.29].
2+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2019-02-16 04a87ae262 In imath.h, replace stdint.h usage with c.h equivalents.
* pgsql: Import changes from IMath versions (1.3, 1.29].
@ 2019-02-16 21:12 Noah Misch <noah@leadboat.com>
0 siblings, 1 reply; 2+ messages in thread
From: Noah Misch @ 2019-02-16 21:12 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Import changes from IMath versions (1.3, 1.29].
Upstream fixed bugs over the years, but none are confirmed to have
affected pgcrypto. We're better off naively tracking upstream than
reactively maintaining a twelve-year-old snapshot of upstream. Add a
header comment describing the synchronization procedure. Discard use of
INVERT_COMPARE_RESULT(); the domain of the comparisons in question is
{-1,0,1}, controlled entirely by code in imath.c.
Andrew Gierth reviewed the Makefile change. Tom Lane reviewed the
synchronization procedure description.
Discussion: https://postgr.es/m/20190203035704.GA6226@rfd.leadboat.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/48e24ba6b7fd3bfd156b51e8d768fd48df0d288b
Modified Files
--------------
contrib/pgcrypto/Makefile | 3 +
contrib/pgcrypto/imath.c | 2638 ++++++++++++++++++++++-----------------------
contrib/pgcrypto/imath.h | 493 ++++++---
3 files changed, 1633 insertions(+), 1501 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgsql: Import changes from IMath versions (1.3, 1.29].
@ 2019-02-16 21:42 Tom Lane <tgl@sss.pgh.pa.us>
parent: Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lane @ 2019-02-16 21:42 UTC (permalink / raw)
To: Noah Misch <noah@leadboat.com>; +Cc: pgsql-committers@lists.postgresql.org
Noah Misch <noah@leadboat.com> writes:
> Import changes from IMath versions (1.3, 1.29].
"dory" doesn't like this a bit. I think you need s/uint32_t/uint32/g
and likewise for uint64.
regards, tom lane
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-02-16 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-02-16 21:12 pgsql: Import changes from IMath versions (1.3, 1.29]. Noah Misch <noah@leadboat.com>
2019-02-16 21:42 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox