pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Clean up newlines following left parentheses 4+ messages / 2 participants [nested] [flat]
* pgsql: Clean up newlines following left parentheses @ 2020-01-30 16:55 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 4+ messages in thread From: Alvaro Herrera @ 2020-01-30 16:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clean up newlines following left parentheses We used to strategically place newlines after some function call left parentheses to make pgindent move the argument list a few chars to the left, so that the whole line would fit under 80 chars. However, pgindent no longer does that, so the newlines just made the code vertically longer for no reason. Remove those newlines, and reflow some of those lines for some extra naturality. Reviewed-by: Michael Paquier, Tom Lane Discussion: https://postgr.es/m/20200129200401.GA6303@alvherre.pgsql Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c9d29775195922136c09cc980bb1b7091bf3d859 Modified Files -------------- contrib/btree_gin/btree_gin.c | 6 +-- contrib/btree_gist/btree_cash.c | 17 +++---- contrib/btree_gist/btree_date.c | 63 ++++++++++++------------- contrib/btree_gist/btree_enum.c | 48 +++++++++---------- contrib/btree_gist/btree_float4.c | 17 +++---- contrib/btree_gist/btree_float8.c | 17 +++---- contrib/btree_gist/btree_inet.c | 6 +-- contrib/btree_gist/btree_int2.c | 16 +++---- contrib/btree_gist/btree_int4.c | 16 +++---- contrib/btree_gist/btree_int8.c | 16 +++---- contrib/btree_gist/btree_interval.c | 16 +++---- contrib/btree_gist/btree_macaddr.c | 11 ++--- contrib/btree_gist/btree_macaddr8.c | 11 ++--- contrib/btree_gist/btree_numeric.c | 24 ++++------ contrib/btree_gist/btree_oid.c | 16 +++---- contrib/btree_gist/btree_time.c | 30 +++++------- contrib/btree_gist/btree_ts.c | 26 ++++------ contrib/btree_gist/btree_utils_var.c | 7 ++- contrib/btree_gist/btree_uuid.c | 13 ++--- contrib/cube/cube.c | 24 ++++------ contrib/dblink/dblink.c | 6 +-- contrib/fuzzystrmatch/dmetaphone.c | 18 +++---- contrib/hstore/hstore_op.c | 6 +-- contrib/intarray/_int_op.c | 8 +--- contrib/ltree/_ltree_gist.c | 6 +-- contrib/ltree/lquery_op.c | 13 ++--- contrib/ltree/ltree_gist.c | 18 +++---- contrib/ltree/ltxtquery_op.c | 13 ++--- contrib/oid2name/oid2name.c | 3 +- contrib/pageinspect/heapfuncs.c | 3 +- contrib/pg_trgm/trgm_gist.c | 12 ++--- contrib/pg_trgm/trgm_op.c | 6 +-- contrib/seg/seg.c | 30 +++++++----- contrib/test_decoding/test_decoding.c | 4 +- src/backend/access/gin/ginlogic.c | 6 +-- src/backend/access/gist/gistproc.c | 12 ++--- src/backend/access/heap/heapam.c | 3 +- src/backend/access/rmgrdesc/xactdesc.c | 11 ++--- src/backend/access/spgist/spgscan.c | 3 +- src/backend/access/transam/xact.c | 12 ++--- src/backend/catalog/heap.c | 3 +- src/backend/commands/event_trigger.c | 6 +-- src/backend/commands/tablecmds.c | 3 +- src/backend/executor/execExprInterp.c | 6 +-- src/backend/executor/nodeAgg.c | 6 +-- src/backend/libpq/auth.c | 6 +-- src/backend/optimizer/path/joinpath.c | 3 +- src/backend/optimizer/plan/createplan.c | 6 +-- src/backend/postmaster/pgstat.c | 12 ++--- src/backend/replication/logical/logicalfuncs.c | 3 +- src/backend/replication/logical/reorderbuffer.c | 3 +- src/backend/tcop/utility.c | 3 +- src/backend/tsearch/dict_thesaurus.c | 8 +--- src/backend/tsearch/to_tsany.c | 3 +- src/backend/tsearch/ts_parse.c | 12 ++--- src/backend/utils/adt/formatting.c | 3 +- src/backend/utils/adt/pgstatfuncs.c | 6 +-- src/backend/utils/adt/rangetypes_spgist.c | 3 +- src/backend/utils/adt/rangetypes_typanalyze.c | 9 ++-- src/backend/utils/adt/ruleutils.c | 3 +- src/backend/utils/adt/timestamp.c | 6 +-- src/backend/utils/adt/tsgistidx.c | 12 ++--- src/backend/utils/adt/tsquery_op.c | 11 ++--- src/backend/utils/adt/tsvector_op.c | 22 ++++----- src/backend/utils/misc/pg_controldata.c | 3 +- src/bin/pg_upgrade/tablespace.c | 7 ++- src/bin/psql/help.c | 6 +-- src/interfaces/libpq/fe-connect.c | 45 +++++++++--------- src/interfaces/libpq/fe-misc.c | 3 +- src/interfaces/libpq/fe-protocol2.c | 8 +--- src/interfaces/libpq/fe-protocol3.c | 6 +-- src/interfaces/libpq/fe-secure-openssl.c | 12 ++--- src/interfaces/libpq/fe-secure.c | 6 +-- src/interfaces/libpq/win32.c | 9 ++-- src/pl/plperl/plperl.c | 7 +-- src/pl/plpython/plpy_elog.c | 6 +-- src/pl/tcl/pltcl.c | 8 ++-- src/port/gettimeofday.c | 3 +- 78 files changed, 342 insertions(+), 538 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Clean up newlines following left parentheses @ 2022-05-13 22:04 Alvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 4+ messages in thread From: Alvaro Herrera @ 2022-05-13 22:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clean up newlines following left parentheses Like commit c9d297751959. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c4f113e8fef900e9e7e7c77a3a21db1535e5be72 Modified Files -------------- src/backend/executor/nodeAgg.c | 4 ++-- src/backend/replication/logical/reorderbuffer.c | 3 +-- src/backend/storage/ipc/standby.c | 3 +-- 3 files changed, 4 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Clean up newlines following left parentheses @ 2024-11-26 16:47 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 4+ messages in thread From: Álvaro Herrera @ 2024-11-26 16:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clean up newlines following left parentheses Most came in during the 17 cycle, so backpatch there. Some (particularly reorderbuffer.h) are very old, but backpatching doesn't seem useful. Like commits c9d297751959, c4f113e8fef9. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e6c32d9fad18f5a1dcb13c13f02445061b60523b Modified Files -------------- contrib/bloom/bloom.h | 9 +++------ src/backend/backup/basebackup_incremental.c | 8 ++++---- src/backend/utils/adt/pg_locale.c | 4 ++-- src/backend/utils/cache/relcache.c | 3 +-- src/bin/pg_combinebackup/load_manifest.c | 3 +-- src/common/parse_manifest.c | 5 ++--- src/common/unicode/category_test.c | 24 ++++++++---------------- src/include/common/parse_manifest.h | 4 ++-- src/include/replication/reorderbuffer.h | 27 +++++++++------------------ 9 files changed, 32 insertions(+), 55 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Clean up newlines following left parentheses @ 2024-11-26 16:47 Álvaro Herrera <alvherre@alvh.no-ip.org> 0 siblings, 0 replies; 4+ messages in thread From: Álvaro Herrera @ 2024-11-26 16:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clean up newlines following left parentheses Most came in during the 17 cycle, so backpatch there. Some (particularly reorderbuffer.h) are very old, but backpatching doesn't seem useful. Like commits c9d297751959, c4f113e8fef9. Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b0e572819d51bfd87d161e5e1d11178610f6fb3a Modified Files -------------- contrib/bloom/bloom.h | 9 +++------ src/backend/backup/basebackup_incremental.c | 8 ++++---- src/backend/utils/init/postinit.c | 3 +-- src/bin/pg_combinebackup/load_manifest.c | 3 +-- src/common/parse_manifest.c | 5 ++--- src/common/unicode/category_test.c | 24 ++++++++---------------- src/include/common/parse_manifest.h | 4 ++-- src/include/replication/reorderbuffer.h | 27 +++++++++------------------ 8 files changed, 30 insertions(+), 53 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-11-26 16:47 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-01-30 16:55 pgsql: Clean up newlines following left parentheses Alvaro Herrera <alvherre@alvh.no-ip.org> 2022-05-13 22:04 pgsql: Clean up newlines following left parentheses Alvaro Herrera <alvherre@alvh.no-ip.org> 2024-11-26 16:47 pgsql: Clean up newlines following left parentheses Álvaro Herrera <alvherre@alvh.no-ip.org> 2024-11-26 16:47 pgsql: Clean up newlines following left parentheses Álvaro Herrera <alvherre@alvh.no-ip.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox