pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Apply auto-vectorization to the inner loop of numeric multiplica 2+ messages / 2 participants [nested] [flat]
* pgsql: Apply auto-vectorization to the inner loop of numeric multiplica @ 2020-09-07 01:40 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2020-09-07 01:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Apply auto-vectorization to the inner loop of numeric multiplication. Compile numeric.c with -ftree-vectorize where available, and adjust the innermost loop of mul_var() so that it is amenable to being auto-vectorized. (Mainly, that involves making it process the arrays left-to-right not right-to-left.) Applying -ftree-vectorize actually makes numeric.o smaller, at least with my compiler (gcc 8.3.1 on x86_64), and it's a little faster too. Independently of that, fixing the inner loop to be vectorizable also makes things a bit faster. But doing both is a huge win for multiplications with lots of digits. For me, the numeric regression test is the same speed to within measurement noise, but numeric_big is a full 45% faster. We also looked into applying -funroll-loops, but that makes numeric.o bloat quite a bit, and the additional speed improvement is very marginal. Amit Khandekar, reviewed and edited a little by me Discussion: https://postgr.es/m/CAJ3gD9evtA_vBo+WMYMyT-u=keHX7-r8p2w7OSRfXf42LTwCZQ@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/88709176236caf3cb9655acda6bad2df0323ac8f Modified Files -------------- src/backend/utils/adt/Makefile | 3 +++ src/backend/utils/adt/numeric.c | 15 ++++++++++++--- 2 files changed, 15 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Apply auto-vectorization to the inner loop of div_var_fast(). @ 2022-02-27 10:19 Dean Rasheed <dean.a.rasheed@gmail.com> 0 siblings, 0 replies; 2+ messages in thread From: Dean Rasheed @ 2022-02-27 10:19 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Apply auto-vectorization to the inner loop of div_var_fast(). This loop is basically the same as the inner loop of mul_var(), which was auto-vectorized in commit 8870917623, but the compiler will only consider auto-vectorizing the div_var_fast() loop if the assignment target div[qi + i] is replaced by div_qi[i], where div_qi = &div[qi]. Additionally, since the compiler doesn't know that qdigit is guaranteed to fit in a 16-bit NumericDigit, cast it to NumericDigit before multiplying to make the resulting auto-vectorized code more efficient (avoiding unnecessary multiplication of the high 16 bits). While at it, per suggestion from Tom Lane, change var1digit in mul_var() to be a NumericDigit rather than an int for the same reason. This actually makes no difference with modern gcc, but it might help other compilers generate more efficient assembly. Dean Rasheed, reviewed by Tom Lane. Discussion: https://postgr.es/m/CAEZATCVwsBi-ND-t82Cuuh1=8ee6jdOpzsmGN+CUZB6yjLg9jw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e3d41d08a17549fdc60a8b9450c0511c11d666d7 Modified Files -------------- src/backend/utils/adt/numeric.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-02-27 10:19 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-09-07 01:40 pgsql: Apply auto-vectorization to the inner loop of numeric multiplica Tom Lane <tgl@sss.pgh.pa.us> 2022-02-27 10:19 pgsql: Apply auto-vectorization to the inner loop of div_var_fast(). Dean Rasheed <dean.a.rasheed@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox