pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: In messages, use singular nouns for -1, like we do for +1.
4+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2021-03-30 9ee7d533da adjust dblink regression expected output for commit 5da9868ed9
* pgsql: In messages, use singular nouns for -1, like we do for +1.
@ 2021-03-30 22:34 Bruce Momjian <bruce@momjian.us>
2021-03-30 23:15 ` Re: pgsql: In messages, use singular nouns for -1, like we do for +1. Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Momjian @ 2021-03-30 22:34 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
In messages, use singular nouns for -1, like we do for +1.
This outputs "-1 year", not "-1 years".
Reported-by: neverov.max@gmail.com
Bug: 16939
Discussion: https://postgr.es/m/16939-cceeb03fb72736ee@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5da9868ed983f95cc1cff80dcd81252a513774f8
Modified Files
--------------
src/backend/utils/adt/datetime.c | 4 ++--
src/interfaces/ecpg/pgtypeslib/interval.c | 4 ++--
src/interfaces/libpq/fe-print.c | 4 ++--
src/test/regress/expected/interval.out | 22 +++++++++++-----------
4 files changed, 17 insertions(+), 17 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: In messages, use singular nouns for -1, like we do for +1.
2021-03-30 22:34 pgsql: In messages, use singular nouns for -1, like we do for +1. Bruce Momjian <bruce@momjian.us>
@ 2021-03-30 23:15 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-03-30 23:20 ` Re: pgsql: In messages, use singular nouns for -1, like we do for +1. Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 4+ messages in thread
From: Alvaro Herrera @ 2021-03-30 23:15 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: pgsql-committers@lists.postgresql.org
On 2021-Mar-30, Bruce Momjian wrote:
> In messages, use singular nouns for -1, like we do for +1.
>
> This outputs "-1 year", not "-1 years".
This broke the dblink test ...
--
Álvaro Herrera Valdivia, Chile
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: In messages, use singular nouns for -1, like we do for +1.
2021-03-30 22:34 pgsql: In messages, use singular nouns for -1, like we do for +1. Bruce Momjian <bruce@momjian.us>
2021-03-30 23:15 ` Re: pgsql: In messages, use singular nouns for -1, like we do for +1. Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-03-30 23:20 ` Bruce Momjian <bruce@momjian.us>
2021-03-30 23:46 ` Re: pgsql: In messages, use singular nouns for -1, like we do for +1. Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Momjian @ 2021-03-30 23:20 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Mar 30, 2021 at 08:15:06PM -0300, Álvaro Herrera wrote:
> On 2021-Mar-30, Bruce Momjian wrote:
>
> > In messages, use singular nouns for -1, like we do for +1.
> >
> > This outputs "-1 year", not "-1 years".
>
> This broke the dblink test ...
OK, checking. I am testing check-world now. Thanks.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: In messages, use singular nouns for -1, like we do for +1.
2021-03-30 22:34 pgsql: In messages, use singular nouns for -1, like we do for +1. Bruce Momjian <bruce@momjian.us>
2021-03-30 23:15 ` Re: pgsql: In messages, use singular nouns for -1, like we do for +1. Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-03-30 23:20 ` Re: pgsql: In messages, use singular nouns for -1, like we do for +1. Bruce Momjian <bruce@momjian.us>
@ 2021-03-30 23:46 ` Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 4+ messages in thread
From: Bruce Momjian @ 2021-03-30 23:46 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Mar 30, 2021 at 07:20:32PM -0400, Bruce Momjian wrote:
> On Tue, Mar 30, 2021 at 08:15:06PM -0300, Álvaro Herrera wrote:
> > On 2021-Mar-30, Bruce Momjian wrote:
> >
> > > In messages, use singular nouns for -1, like we do for +1.
> > >
> > > This outputs "-1 year", not "-1 years".
> >
> > This broke the dblink test ...
>
> OK, checking. I am testing check-world now. Thanks.
Fixed, thanks.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2021-03-30 23:46 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 22:34 pgsql: In messages, use singular nouns for -1, like we do for +1. Bruce Momjian <bruce@momjian.us>
2021-03-30 23:15 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-03-30 23:20 ` Bruce Momjian <bruce@momjian.us>
2021-03-30 23:46 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox