pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add missing source files to nls.mk 13+ messages / 2 participants [nested] [flat]
* pgsql: Add missing source files to nls.mk @ 2014-07-15 14:11 Peter Eisentraut <peter_e@gmx.net> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2014-07-15 14:11 UTC (permalink / raw) To: pgsql-committers Add missing source files to nls.mk These are files under common/ that have been moved around. Updating these manually is not satisfactory, but it's the only solution at the moment. Branch ------ REL9_4_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/77b41010dbb159b77b35aef02b517ce1a130f3b6 Modified Files -------------- src/bin/initdb/nls.mk | 2 +- src/bin/pg_dump/nls.mk | 3 ++- src/bin/psql/nls.mk | 3 ++- src/bin/scripts/nls.mk | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2014-07-15 14:11 Peter Eisentraut <peter_e@gmx.net> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2014-07-15 14:11 UTC (permalink / raw) To: pgsql-committers Add missing source files to nls.mk These are files under common/ that have been moved around. Updating these manually is not satisfactory, but it's the only solution at the moment. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/f9ddcf75430467493aa6c2b07a45776e4ae8b416 Modified Files -------------- src/bin/initdb/nls.mk | 2 +- src/bin/pg_dump/nls.mk | 3 ++- src/bin/psql/nls.mk | 3 ++- src/bin/scripts/nls.mk | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2019-07-06 13:04 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2019-07-06 13:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b33283c36409aef7eddb5ba92bdd9300dd45d974 Modified Files -------------- src/interfaces/ecpg/ecpglib/nls.mk | 2 +- src/interfaces/libpq/nls.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2019-07-06 13:04 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2019-07-06 13:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c8e0997239840888a974624b0ab020177357f0ae Modified Files -------------- src/interfaces/ecpg/ecpglib/nls.mk | 2 +- src/interfaces/libpq/nls.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2020-06-06 18:01 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2020-06-06 18:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/35b527428d6110dd0de585223a4783fe996a0020 Modified Files -------------- src/bin/pg_basebackup/nls.mk | 2 +- src/bin/pg_rewind/nls.mk | 2 +- src/bin/psql/nls.mk | 2 +- src/bin/scripts/nls.mk | 3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2021-04-18 14:12 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2021-04-18 14:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4ed7f0599a8984d9ed967780a157d9b23d03fbb5 Modified Files -------------- src/bin/pg_amcheck/nls.mk | 5 ++++- src/bin/scripts/nls.mk | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2022-04-09 13:51 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2022-04-09 13:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/fc5b83bb60a862a4a27372b255405df598455ff1 Modified Files -------------- src/bin/pg_basebackup/nls.mk | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2022-05-09 05:19 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2022-05-09 05:19 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f45f8b7ff3fe6c8b8139e177bb3fec7629ef9f05 Modified Files -------------- src/bin/pg_amcheck/nls.mk | 1 + src/bin/pg_basebackup/nls.mk | 1 + src/bin/pg_checksums/nls.mk | 4 +++- src/bin/pg_dump/nls.mk | 3 ++- src/bin/pg_test_fsync/nls.mk | 5 +++-- src/bin/scripts/nls.mk | 4 +++- 6 files changed, 13 insertions(+), 5 deletions(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2022-05-11 04:20 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2022-05-11 04:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3aa7a3d2a3d1177d32680b94541dc2db7f3d7b0b Modified Files -------------- src/bin/psql/nls.mk | 2 +- src/interfaces/libpq/nls.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2023-04-14 08:03 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2023-04-14 08:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/99322d6eee6445665c1fb131ec6130924b7673b6 Modified Files -------------- src/bin/pg_dump/nls.mk | 4 ++++ src/bin/pg_rewind/nls.mk | 1 + 2 files changed, 5 insertions(+) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2024-03-18 15:46 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2024-03-18 15:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5162f663fcbe837648ae28f00e18ed972f5e360b Modified Files -------------- src/bin/initdb/nls.mk | 1 + src/bin/pg_resetwal/nls.mk | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* pgsql: Add missing source files to nls.mk @ 2024-06-13 08:25 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 1 reply; 13+ messages in thread From: Peter Eisentraut @ 2024-06-13 08:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add missing source files to nls.mk Files in common/ and fe_utils/ that contain translatable strings need to be listed in the nls.mk files of the programs that use them. (Not great, but that's the way it works for now.) This usually requires some manual analysis which is done about once during each major release beta period. This time, I wrote a hackish script that figures some of this out more automatically, so this update is a bit larger as it also includes some files that were missed in the past. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ad8877cb513733d8bb98d24770a094b81c27e4c5 Modified Files -------------- src/bin/initdb/nls.mk | 1 + src/bin/pg_amcheck/nls.mk | 7 ++++++- src/bin/pg_archivecleanup/nls.mk | 2 +- src/bin/pg_basebackup/nls.mk | 5 ++++- src/bin/pg_checksums/nls.mk | 3 +++ src/bin/pg_combinebackup/nls.mk | 7 ++++++- src/bin/pg_config/nls.mk | 5 ++++- src/bin/pg_controldata/nls.mk | 4 +++- src/bin/pg_ctl/nls.mk | 1 + src/bin/pg_dump/nls.mk | 4 +++- src/bin/pg_resetwal/nls.mk | 3 +++ src/bin/pg_rewind/nls.mk | 6 +++++- src/bin/pg_test_fsync/nls.mk | 2 +- src/bin/pg_test_timing/nls.mk | 2 +- src/bin/pg_upgrade/nls.mk | 8 +++++++- src/bin/pg_verifybackup/nls.mk | 3 +++ src/bin/pg_waldump/nls.mk | 4 +++- src/bin/pg_walsummary/nls.mk | 5 ++++- src/bin/psql/nls.mk | 1 + src/bin/scripts/nls.mk | 2 ++ 20 files changed, 62 insertions(+), 13 deletions(-) ^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pgsql: Add missing source files to nls.mk @ 2024-06-13 08:38 Peter Eisentraut <peter@eisentraut.org> parent: Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 13+ messages in thread From: Peter Eisentraut @ 2024-06-13 08:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org On 13.06.24 10:25, Peter Eisentraut wrote: > Add missing source files to nls.mk > > Files in common/ and fe_utils/ that contain translatable strings need > to be listed in the nls.mk files of the programs that use them. (Not > great, but that's the way it works for now.) This usually requires > some manual analysis which is done about once during each major > release beta period. This time, I wrote a hackish script that figures > some of this out more automatically, so this update is a bit larger as > it also includes some files that were missed in the past. For posterity, I have attached the script that used here. I hope to improve on this process in the future. Attachments:^ permalink raw reply [nested|flat] 13+ messages in threadpg-nls-find-missing.pl (text/x-perl-script, 1.8K) download
#!/usr/bin/perl use strict; use warnings; use autodie; use File::Spec; # Usage: $0 SUBDIR FILENAME... my %args = (); my %deps = (); my $subdir = shift @ARGV; sub process_deps { my $newstuff = 0; foreach my $filename (keys %deps) { my $dir; foreach my $d ($subdir, 'src', 'src/include') { if (-f "$d/$filename") { $dir = $d; last; } } next unless $dir; open my $fh, '<', "$dir/$filename"; while (my $line = <$fh>) { if ($line =~ m!^#include "([^"]+)"!) { my $inc = $1; if ($inc !~ m!/! || $inc =~ m!^common/! || $inc =~ m!^fe_utils/!) { if (!$deps{$inc}) { $deps{$inc} = 1; $newstuff = 1; } $inc =~ s!\.h!.c!; if (!$deps{$inc} && (-f "src/$inc" || -f "$subdir/$inc")) { $deps{$inc} = 1; $newstuff = 1; } } } } close $fh; } return $newstuff; } foreach my $arg (@ARGV) { $deps{$arg} = 1; } while (process_deps()) {} my @FRONTEND_COMMON_GETTEXT_FILES = qw(common/logging.c); foreach my $f (@FRONTEND_COMMON_GETTEXT_FILES) { delete $deps{$f}; } foreach my $k (keys %deps) { delete $deps{$k}; next unless $k =~ m!\.c!; if ($k =~ m!common/! || $k =~ m!fe_utils!) { $deps{"src/$k"} = 1; } else { $deps{"$subdir/$k"} = 1; } } my @triggers = qw(_ pg_log_error pg_log_error_detail pg_log_error_hint pg_log_warning pg_log_warning_detail pg_log_warning_hint pg_log_info pg_log_info_detail pg_log_info_hint pg_fatal pg_log_generic pg_log_generic_v ); foreach my $fn (keys %deps) { local $/; my $found = 0; open my $fh, '<', $fn; my $contents = <$fh>; close $fh; foreach my $t (@triggers) { $found = 1 if $contents =~ /\b$t\b/; } delete $deps{$fn} if !$found; } print join("\n", sort map { File::Spec->abs2rel($_, $subdir) } keys %deps), "\n";
end of thread, other threads:[~2024-06-13 08:38 UTC | newest] Thread overview: 13+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2014-07-15 14:11 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter_e@gmx.net> 2014-07-15 14:11 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter_e@gmx.net> 2019-07-06 13:04 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2019-07-06 13:04 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2020-06-06 18:01 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2021-04-18 14:12 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2022-04-09 13:51 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2022-05-09 05:19 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2022-05-11 04:20 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2023-04-14 08:03 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2024-03-18 15:46 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2024-06-13 08:25 pgsql: Add missing source files to nls.mk Peter Eisentraut <peter@eisentraut.org> 2024-06-13 08:38 ` Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox