pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Remove XLogFileInit() ability to skip ControlFileLock. 3+ messages / 2 participants [nested] [flat]
* pgsql: Remove XLogFileInit() ability to skip ControlFileLock. @ 2021-06-29 01:36 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 3+ messages in thread From: Noah Misch @ 2021-06-29 01:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove XLogFileInit() ability to skip ControlFileLock. Cold paths, initdb and end-of-recovery, used it. Don't optimize them. Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c53c6b98d38a4d238b2fe2ddcea63c33b0a61376 Modified Files -------------- src/backend/access/transam/xlog.c | 46 +++++++++++------------------------ src/backend/replication/walreceiver.c | 2 +- src/include/access/xlog.h | 2 +- 3 files changed, 16 insertions(+), 34 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove XLogFileInit() ability to skip ControlFileLock. @ 2025-04-06 05:33 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-04-06 05:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove XLogFileInit() ability to skip ControlFileLock. Cold paths, initdb and end-of-recovery, used it. Don't optimize them. This commit has been applied as of c53c6b98d38a in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6b168c1299c5da486c653e2456a87841d24b1ea7 Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 46 +++++++++++------------------------ src/backend/replication/walreceiver.c | 2 +- src/include/access/xlog.h | 2 +- 3 files changed, 16 insertions(+), 34 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Remove XLogFileInit() ability to skip ControlFileLock. @ 2025-04-06 05:33 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-04-06 05:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Remove XLogFileInit() ability to skip ControlFileLock. Cold paths, initdb and end-of-recovery, used it. Don't optimize them. This commit has been applied as of c53c6b98d38a in v15 and newer versions. This is required on stable branches of v13 and v14 to fix a regression reported by Noah Misch, introduced by 1f95181b44c8, causing spurious failures in archive recovery (neither streaming nor archive recovery) with concurrent restartpoints. The backpatched versions of the patches have been aligned on these branches by me, Noah Misch is the author. Tests have been conducted by the both of us. Reported-by: Arun Thirupathi Author: Noah Misch <noah@leadboat.com> Discussion: https://postgr.es/m/20210202151416.GB3304930@rfd.leadboat.com Discussion: https://postgr.es/m/20250306193013.36.nmisch@google.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/df8ec9634ccdc3c67871e36fcc54c44370639b37 Author: Noah Misch <noah@leadboat.com> Modified Files -------------- src/backend/access/transam/xlog.c | 46 +++++++++++------------------------ src/backend/replication/walreceiver.c | 2 +- src/include/access/xlog.h | 2 +- 3 files changed, 16 insertions(+), 34 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-04-06 05:33 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-06-29 01:36 pgsql: Remove XLogFileInit() ability to skip ControlFileLock. Noah Misch <noah@leadboat.com> 2025-04-06 05:33 pgsql: Remove XLogFileInit() ability to skip ControlFileLock. Michael Paquier <michael@paquier.xyz> 2025-04-06 05:33 pgsql: Remove XLogFileInit() ability to skip ControlFileLock. Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox