pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Add support for LZ4 with compression of full-page writes in WAL
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2021-06-29 445e36ad4e Bump XLOG_PAGE_MAGIC for format changes related to FPW compression
* pgsql: Add support for LZ4 with compression of full-page writes in WAL
@ 2021-06-29 02:19 Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2021-06-29 02:19 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Add support for LZ4 with compression of full-page writes in WAL
The logic is implemented so as there can be a choice in the compression
used when building a WAL record, and an extra per-record bit is used to
track down if a block is compressed with PGLZ, LZ4 or nothing.
wal_compression, the existing parameter, is changed to an enum with
support for the following backward-compatible values:
- "off", the default, to not use compression.
- "pglz" or "on", to compress FPWs with PGLZ.
- "lz4", the new mode, to compress FPWs with LZ4.
Benchmarking has showed that LZ4 outclasses easily PGLZ. ZSTD would be
also an interesting choice, but going just with LZ4 for now makes the
patch minimalistic as toast compression is already able to use LZ4, so
there is no need to worry about any build-related needs for this
implementation.
Author: Andrey Borodin, Justin Pryzby
Reviewed-by: Dilip Kumar, Michael Paquier
Discussion: https://postgr.es/m/3037310D-ECB7-4BF1-AF20-01C10BB33A33@yandex-team.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4035cd5d4eee4dae797bfc77ab07f8dcd8781b41
Modified Files
--------------
doc/src/sgml/config.sgml | 14 +++--
doc/src/sgml/install-windows.sgml | 2 +-
doc/src/sgml/installation.sgml | 5 +-
doc/src/sgml/standalone-profile.xsl | 4 ++
src/backend/access/transam/xlog.c | 2 +-
src/backend/access/transam/xloginsert.c | 73 +++++++++++++++++++++++----
src/backend/access/transam/xlogreader.c | 58 ++++++++++++++++-----
src/backend/utils/misc/guc.c | 36 +++++++++----
src/backend/utils/misc/postgresql.conf.sample | 3 +-
src/bin/pg_waldump/pg_waldump.c | 19 +++++--
src/include/access/xlog.h | 10 +++-
src/include/access/xlogrecord.h | 16 +++---
src/tools/pgindent/typedefs.list | 1 +
13 files changed, 191 insertions(+), 52 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Add support for LZ4 with compression of full-page writes in WAL
@ 2021-06-29 04:40 Tom Lane <tgl@sss.pgh.pa.us>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2021-06-29 04:40 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-committers@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> Add support for LZ4 with compression of full-page writes in WAL
Should this not have included a bump of XLOG_PAGE_MAGIC?
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Add support for LZ4 with compression of full-page writes in WAL
@ 2021-06-29 05:08 Michael Paquier <michael@paquier.xyz>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 3+ messages in thread
From: Michael Paquier @ 2021-06-29 05:08 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On Tue, Jun 29, 2021 at 12:40:13AM -0400, Tom Lane wrote:
> Should this not have included a bump of XLOG_PAGE_MAGIC?
It should, thanks! Fixed now.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-06-29 05:08 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 02:19 pgsql: Add support for LZ4 with compression of full-page writes in WAL Michael Paquier <michael@paquier.xyz>
2021-06-29 04:40 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-06-29 05:08 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox