pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: process startup: Remove bootstrap / checker modes from AuxProcTy
4+ messages / 2 participants
[nested] [flat]

* pgsql: process startup: Remove bootstrap / checker modes from AuxProcTy
@ 2021-08-05 19:26  Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 4+ messages in thread

From: Andres Freund @ 2021-08-05 19:26 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

process startup: Remove bootstrap / checker modes from AuxProcType.

Neither is actually initialized as an auxiliary process, so it does not really
make sense to reserve a PGPROC etc for them.

This keeps checker mode implemented by exiting partway through bootstrap
mode. That might be worth changing at some point, perhaps if we ever extend
checker mode to be a more general tool.

Author: Andres Freund <andres@anarazel.de>
Reviewed-By: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Reviewed-By: Robert Haas <robertmhaas@gmail.com>
Discussion: https://postgr.es/m/20210802164124.ufo5buo4apl6yuvs@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f8dd4ecb0b7fc3420e199021375e622815cd326f

Modified Files
--------------
src/backend/bootstrap/bootstrap.c   | 29 +++++++++++------------------
src/backend/main/main.c             |  8 +++++---
src/backend/postmaster/auxprocess.c |  5 -----
src/bin/initdb/initdb.c             |  6 +++---
src/include/bootstrap/bootstrap.h   |  2 +-
src/include/miscadmin.h             |  5 +----
6 files changed, 21 insertions(+), 34 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: process startup: Remove bootstrap / checker modes from AuxProcTy
@ 2022-09-14 04:43  Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 4+ messages in thread

From: Peter Eisentraut @ 2022-09-14 04:43 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org

On 05.08.21 21:26, Andres Freund wrote:
> process startup: Remove bootstrap / checker modes from AuxProcType.
> 
> Neither is actually initialized as an auxiliary process, so it does not really
> make sense to reserve a PGPROC etc for them.
> 
> This keeps checker mode implemented by exiting partway through bootstrap
> mode. That might be worth changing at some point, perhaps if we ever extend
> checker mode to be a more general tool.

I don't know if this was the original commit that added the --check 
option or was just refactoring around it, but:

I don't see any mention of the --check option in the postgres man page. 
That should be added.






^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: process startup: Remove bootstrap / checker modes from AuxProcTy
@ 2022-09-14 04:49  Andres Freund <andres@anarazel.de>
  parent: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Andres Freund @ 2022-09-14 04:49 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Hi, 

On September 13, 2022 9:43:57 PM PDT, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>On 05.08.21 21:26, Andres Freund wrote:
>> process startup: Remove bootstrap / checker modes from AuxProcType.
>> 
>> Neither is actually initialized as an auxiliary process, so it does not really
>> make sense to reserve a PGPROC etc for them.
>> 
>> This keeps checker mode implemented by exiting partway through bootstrap
>> mode. That might be worth changing at some point, perhaps if we ever extend
>> checker mode to be a more general tool.
>
>I don't know if this was the original commit that added the --check option or was just refactoring around it, but:
>
>I don't see any mention of the --check option in the postgres man page. That should be added.
>
>
>

IIRC we discussed that at some point and considered it a sufficiently internal option that documenting it in user facing docs doesn't seem useful.

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: process startup: Remove bootstrap / checker modes from AuxProcTy
@ 2022-09-14 16:11  Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  parent: Andres Freund <andres@anarazel.de>
  0 siblings, 0 replies; 4+ messages in thread

From: Peter Eisentraut @ 2022-09-14 16:11 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org

On 14.09.22 06:49, Andres Freund wrote:
>     I don't see any mention of the --check option in the postgres man page. That should be added.
> 
> IIRC we discussed that at some point and considered it a sufficiently 
> internal option that documenting it in user facing docs doesn't seem useful.

Ok, I see that we don't document --boot either, so I suppose that is 
consistent that way.






^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2022-09-14 16:11 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 19:26 pgsql: process startup: Remove bootstrap / checker modes from AuxProcTy Andres Freund <andres@anarazel.de>
2022-09-14 04:43 ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>
2022-09-14 04:49   ` Andres Freund <andres@anarazel.de>
2022-09-14 16:11     ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox