pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Make EXEC_BACKEND more convenient on macOS.
11+ messages / 2 participants
[nested] [flat]

* pgsql: Make EXEC_BACKEND more convenient on macOS.
@ 2021-08-13 00:03 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 11+ messages in thread

From: Thomas Munro @ 2021-08-13 00:03 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on macOS.

It's hard to disable ASLR on current macOS releases, for testing with
-DEXEC_BACKEND.  You could already set the environment variable
PG_SHMEM_ADDR to something not likely to collide with mappings created
earlier in process startup.  Let's also provide a default value that
works on current releases and architectures, for developer convenience.

As noted in the pre-existing comment, this is a horrible hack, but
-DEXEC_BACKEND is only used by Unix-based PostgreSQL developers for
testing some otherwise Windows-only code paths, so it seems excusable.

Back-patch to all supported branches.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/88cbbbfa3e2b0d38d6047af83764f140face5991

Modified Files
--------------
src/backend/port/sysv_shmem.c | 10 ++++++++++
1 file changed, 10 insertions(+)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on macOS.
@ 2021-08-13 00:04 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 11+ messages in thread

From: Thomas Munro @ 2021-08-13 00:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on macOS.

It's hard to disable ASLR on current macOS releases, for testing with
-DEXEC_BACKEND.  You could already set the environment variable
PG_SHMEM_ADDR to something not likely to collide with mappings created
earlier in process startup.  Let's also provide a default value that
works on current releases and architectures, for developer convenience.

As noted in the pre-existing comment, this is a horrible hack, but
-DEXEC_BACKEND is only used by Unix-based PostgreSQL developers for
testing some otherwise Windows-only code paths, so it seems excusable.

Back-patch to all supported branches.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8201b60565b8da465e75da4e4c6d2f01bf976a43

Modified Files
--------------
src/backend/port/sysv_shmem.c | 10 ++++++++++
1 file changed, 10 insertions(+)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on macOS.
@ 2021-08-13 00:04 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 11+ messages in thread

From: Thomas Munro @ 2021-08-13 00:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on macOS.

It's hard to disable ASLR on current macOS releases, for testing with
-DEXEC_BACKEND.  You could already set the environment variable
PG_SHMEM_ADDR to something not likely to collide with mappings created
earlier in process startup.  Let's also provide a default value that
works on current releases and architectures, for developer convenience.

As noted in the pre-existing comment, this is a horrible hack, but
-DEXEC_BACKEND is only used by Unix-based PostgreSQL developers for
testing some otherwise Windows-only code paths, so it seems excusable.

Back-patch to all supported branches.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2c6275423535f86d0d4bc2a4651852d05b3d60c1

Modified Files
--------------
src/backend/port/sysv_shmem.c | 10 ++++++++++
1 file changed, 10 insertions(+)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on macOS.
@ 2021-08-13 00:04 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 11+ messages in thread

From: Thomas Munro @ 2021-08-13 00:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on macOS.

It's hard to disable ASLR on current macOS releases, for testing with
-DEXEC_BACKEND.  You could already set the environment variable
PG_SHMEM_ADDR to something not likely to collide with mappings created
earlier in process startup.  Let's also provide a default value that
works on current releases and architectures, for developer convenience.

As noted in the pre-existing comment, this is a horrible hack, but
-DEXEC_BACKEND is only used by Unix-based PostgreSQL developers for
testing some otherwise Windows-only code paths, so it seems excusable.

Back-patch to all supported branches.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a8096e30f4d08f2b90cc147b44b414191de6155f

Modified Files
--------------
src/backend/port/sysv_shmem.c | 10 ++++++++++
1 file changed, 10 insertions(+)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on macOS.
@ 2021-08-13 00:04 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 11+ messages in thread

From: Thomas Munro @ 2021-08-13 00:04 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on macOS.

It's hard to disable ASLR on current macOS releases, for testing with
-DEXEC_BACKEND.  You could already set the environment variable
PG_SHMEM_ADDR to something not likely to collide with mappings created
earlier in process startup.  Let's also provide a default value that
works on current releases and architectures, for developer convenience.

As noted in the pre-existing comment, this is a horrible hack, but
-DEXEC_BACKEND is only used by Unix-based PostgreSQL developers for
testing some otherwise Windows-only code paths, so it seems excusable.

Back-patch to all supported branches.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0bfefb7dafe0019715075b6e8bf58ed5de58bffa

Modified Files
--------------
src/backend/port/sysv_shmem.c | 10 ++++++++++
1 file changed, 10 insertions(+)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on macOS.
@ 2021-08-13 00:05 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 11+ messages in thread

From: Thomas Munro @ 2021-08-13 00:05 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on macOS.

It's hard to disable ASLR on current macOS releases, for testing with
-DEXEC_BACKEND.  You could already set the environment variable
PG_SHMEM_ADDR to something not likely to collide with mappings created
earlier in process startup.  Let's also provide a default value that
works on current releases and architectures, for developer convenience.

As noted in the pre-existing comment, this is a horrible hack, but
-DEXEC_BACKEND is only used by Unix-based PostgreSQL developers for
testing some otherwise Windows-only code paths, so it seems excusable.

Back-patch to all supported branches.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d49e228a664dd868b6a034e730e99b4f510869a6

Modified Files
--------------
src/backend/port/sysv_shmem.c | 10 ++++++++++
1 file changed, 10 insertions(+)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on macOS.
@ 2021-08-13 00:05 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 11+ messages in thread

From: Thomas Munro @ 2021-08-13 00:05 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on macOS.

It's hard to disable ASLR on current macOS releases, for testing with
-DEXEC_BACKEND.  You could already set the environment variable
PG_SHMEM_ADDR to something not likely to collide with mappings created
earlier in process startup.  Let's also provide a default value that
works on current releases and architectures, for developer convenience.

As noted in the pre-existing comment, this is a horrible hack, but
-DEXEC_BACKEND is only used by Unix-based PostgreSQL developers for
testing some otherwise Windows-only code paths, so it seems excusable.

Back-patch to all supported branches.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/715a8668a5f703f00b8f6cdc126381eb87205d90

Modified Files
--------------
src/backend/port/sysv_shmem.c | 10 ++++++++++
1 file changed, 10 insertions(+)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on Linux and FreeBSD.
@ 2022-01-10 11:27 Thomas Munro <tmunro@postgresql.org>
  0 siblings, 0 replies; 11+ messages in thread

From: Thomas Munro @ 2022-01-10 11:27 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on Linux and FreeBSD.

Try to disable ASLR when building in EXEC_BACKEND mode, to avoid random
memory mapping failures while testing.  For developer use only, no
effect on regular builds.

Suggested-by: Andres Freund <andres@anarazel.de>
Tested-by: Bossart, Nathan <bossartn@amazon.com>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f3e78069db7f7a753ebfe1010b810e47e0d2aa9a

Modified Files
--------------
configure                     |  2 +-
configure.ac                  |  1 +
src/bin/pg_ctl/pg_ctl.c       |  4 ++++
src/common/exec.c             | 33 +++++++++++++++++++++++++++++++++
src/include/pg_config.h.in    |  3 +++
src/include/port.h            |  5 +++++
src/test/regress/pg_regress.c |  4 ++++
src/tools/msvc/Solution.pm    |  1 +
8 files changed, 52 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on Linux and FreeBSD.
@ 2023-02-08 04:11 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 11+ messages in thread

From: Michael Paquier @ 2023-02-08 04:11 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on Linux and FreeBSD.

Try to disable ASLR when building in EXEC_BACKEND mode, to avoid random
memory mapping failures while testing.  For developer use only, no
effect on regular builds.

This has been originally applied as of f3e7806 for v15~, but
recently-added buildfarm member gokiburi tests this configuration on
older branches as well, causing it to fail randomly as ASLR would be
enabled.

Suggested-by: Andres Freund <andres@anarazel.de>
Tested-by: Bossart, Nathan <bossartn@amazon.com>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de
Backpatch-through: 12

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0801345758db44ea8d2da7d8e7d8be2cf3d9bc4e

Modified Files
--------------
configure                     |  2 +-
configure.ac                  |  1 +
src/bin/pg_ctl/pg_ctl.c       |  4 ++++
src/common/exec.c             | 33 +++++++++++++++++++++++++++++++++
src/include/pg_config.h.in    |  3 +++
src/include/port.h            |  5 +++++
src/test/regress/pg_regress.c |  4 ++++
src/tools/msvc/Solution.pm    |  1 +
8 files changed, 52 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on Linux and FreeBSD.
@ 2023-02-08 04:11 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 11+ messages in thread

From: Michael Paquier @ 2023-02-08 04:11 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on Linux and FreeBSD.

Try to disable ASLR when building in EXEC_BACKEND mode, to avoid random
memory mapping failures while testing.  For developer use only, no
effect on regular builds.

This has been originally applied as of f3e7806 for v15~, but
recently-added buildfarm member gokiburi tests this configuration on
older branches as well, causing it to fail randomly as ASLR would be
enabled.

Suggested-by: Andres Freund <andres@anarazel.de>
Tested-by: Bossart, Nathan <bossartn@amazon.com>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de
Backpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/1e4fda6da918f734dd6dab67b3ddcaba4c2fecb2

Modified Files
--------------
configure                     |  2 +-
configure.in                  |  1 +
src/bin/pg_ctl/pg_ctl.c       |  4 ++++
src/common/exec.c             | 33 +++++++++++++++++++++++++++++++++
src/include/pg_config.h.in    |  3 +++
src/include/port.h            |  5 +++++
src/test/regress/pg_regress.c |  4 ++++
src/tools/msvc/Solution.pm    |  1 +
8 files changed, 52 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread

* pgsql: Make EXEC_BACKEND more convenient on Linux and FreeBSD.
@ 2023-02-08 04:11 Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 11+ messages in thread

From: Michael Paquier @ 2023-02-08 04:11 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make EXEC_BACKEND more convenient on Linux and FreeBSD.

Try to disable ASLR when building in EXEC_BACKEND mode, to avoid random
memory mapping failures while testing.  For developer use only, no
effect on regular builds.

This has been originally applied as of f3e7806 for v15~, but
recently-added buildfarm member gokiburi tests this configuration on
older branches as well, causing it to fail randomly as ASLR would be
enabled.

Suggested-by: Andres Freund <andres@anarazel.de>
Tested-by: Bossart, Nathan <bossartn@amazon.com>
Discussion: https://postgr.es/m/20210806032944.m4tz7j2w47mant26%40alap3.anarazel.de
Backpatch-through: 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6b4dba711a4ec4be87850108d4f9db12eecd399e

Modified Files
--------------
configure                     |  2 +-
configure.in                  |  1 +
src/bin/pg_ctl/pg_ctl.c       |  4 ++++
src/common/exec.c             | 33 +++++++++++++++++++++++++++++++++
src/include/pg_config.h.in    |  3 +++
src/include/port.h            |  5 +++++
src/test/regress/pg_regress.c |  4 ++++
7 files changed, 51 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 11+ messages in thread


end of thread, other threads:[~2023-02-08 04:11 UTC | newest]

Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 00:03 pgsql: Make EXEC_BACKEND more convenient on macOS. Thomas Munro <tmunro@postgresql.org>
2021-08-13 00:04 pgsql: Make EXEC_BACKEND more convenient on macOS. Thomas Munro <tmunro@postgresql.org>
2021-08-13 00:04 pgsql: Make EXEC_BACKEND more convenient on macOS. Thomas Munro <tmunro@postgresql.org>
2021-08-13 00:04 pgsql: Make EXEC_BACKEND more convenient on macOS. Thomas Munro <tmunro@postgresql.org>
2021-08-13 00:04 pgsql: Make EXEC_BACKEND more convenient on macOS. Thomas Munro <tmunro@postgresql.org>
2021-08-13 00:05 pgsql: Make EXEC_BACKEND more convenient on macOS. Thomas Munro <tmunro@postgresql.org>
2021-08-13 00:05 pgsql: Make EXEC_BACKEND more convenient on macOS. Thomas Munro <tmunro@postgresql.org>
2022-01-10 11:27 pgsql: Make EXEC_BACKEND more convenient on Linux and FreeBSD. Thomas Munro <tmunro@postgresql.org>
2023-02-08 04:11 pgsql: Make EXEC_BACKEND more convenient on Linux and FreeBSD. Michael Paquier <michael@paquier.xyz>
2023-02-08 04:11 pgsql: Make EXEC_BACKEND more convenient on Linux and FreeBSD. Michael Paquier <michael@paquier.xyz>
2023-02-08 04:11 pgsql: Make EXEC_BACKEND more convenient on Linux and FreeBSD. Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox