pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec 7+ messages / 1 participants [nested] [flat]
* pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec @ 2021-08-16 03:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-08-16 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refresh apply delay on reload of recovery_min_apply_delay at recovery This commit ensures that the wait interval in the replay delay loop waiting for an amount of time defined by recovery_min_apply_delay is correctly handled on reload, recalculating the delay if this GUC value is updated, based on the timestamp of the commit record being replayed. The previous behavior would be problematic for example with replay still waiting even if the delay got reduced or just cancelled. If the apply delay was increased to a larger value, the wait would have just respected the old value set, finishing earlier. Author: Soumyadeep Chakraborty, Ashwin Agrawal Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.com Backpatch-through: 9.6 Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/942416f4bdb056c2b12a97ef7fb2d21b565df3cb Modified Files -------------- src/backend/access/transam/xlog.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec @ 2021-08-16 03:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-08-16 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refresh apply delay on reload of recovery_min_apply_delay at recovery This commit ensures that the wait interval in the replay delay loop waiting for an amount of time defined by recovery_min_apply_delay is correctly handled on reload, recalculating the delay if this GUC value is updated, based on the timestamp of the commit record being replayed. The previous behavior would be problematic for example with replay still waiting even if the delay got reduced or just cancelled. If the apply delay was increased to a larger value, the wait would have just respected the old value set, finishing earlier. Author: Soumyadeep Chakraborty, Ashwin Agrawal Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.com Backpatch-through: 9.6 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f83d80ea1e57927471848d901843ddc6fd5ecacc Modified Files -------------- src/backend/access/transam/xlog.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec @ 2021-08-16 03:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-08-16 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refresh apply delay on reload of recovery_min_apply_delay at recovery This commit ensures that the wait interval in the replay delay loop waiting for an amount of time defined by recovery_min_apply_delay is correctly handled on reload, recalculating the delay if this GUC value is updated, based on the timestamp of the commit record being replayed. The previous behavior would be problematic for example with replay still waiting even if the delay got reduced or just cancelled. If the apply delay was increased to a larger value, the wait would have just respected the old value set, finishing earlier. Author: Soumyadeep Chakraborty, Ashwin Agrawal Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.com Backpatch-through: 9.6 Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/024fd44e0566fe2db264aaa3c6d45d0dfdd30b60 Modified Files -------------- src/backend/access/transam/xlog.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec @ 2021-08-16 03:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-08-16 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refresh apply delay on reload of recovery_min_apply_delay at recovery This commit ensures that the wait interval in the replay delay loop waiting for an amount of time defined by recovery_min_apply_delay is correctly handled on reload, recalculating the delay if this GUC value is updated, based on the timestamp of the commit record being replayed. The previous behavior would be problematic for example with replay still waiting even if the delay got reduced or just cancelled. If the apply delay was increased to a larger value, the wait would have just respected the old value set, finishing earlier. Author: Soumyadeep Chakraborty, Ashwin Agrawal Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.com Backpatch-through: 9.6 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d392e86fa9c4ef5170eebf700d81f77ede4363ad Modified Files -------------- src/backend/access/transam/xlog.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec @ 2021-08-16 03:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-08-16 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refresh apply delay on reload of recovery_min_apply_delay at recovery This commit ensures that the wait interval in the replay delay loop waiting for an amount of time defined by recovery_min_apply_delay is correctly handled on reload, recalculating the delay if this GUC value is updated, based on the timestamp of the commit record being replayed. The previous behavior would be problematic for example with replay still waiting even if the delay got reduced or just cancelled. If the apply delay was increased to a larger value, the wait would have just respected the old value set, finishing earlier. Author: Soumyadeep Chakraborty, Ashwin Agrawal Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.com Backpatch-through: 9.6 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/e4ba1005c0f7a95e3252f38aee02426117b8e12b Modified Files -------------- src/backend/access/transam/xlog.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec @ 2021-08-16 03:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-08-16 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refresh apply delay on reload of recovery_min_apply_delay at recovery This commit ensures that the wait interval in the replay delay loop waiting for an amount of time defined by recovery_min_apply_delay is correctly handled on reload, recalculating the delay if this GUC value is updated, based on the timestamp of the commit record being replayed. The previous behavior would be problematic for example with replay still waiting even if the delay got reduced or just cancelled. If the apply delay was increased to a larger value, the wait would have just respected the old value set, finishing earlier. Author: Soumyadeep Chakraborty, Ashwin Agrawal Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.com Backpatch-through: 9.6 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7f0873f328efe057090071805be3f1ade48ecc8a Modified Files -------------- src/backend/access/transam/xlog.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec @ 2021-08-16 03:12 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 7+ messages in thread From: Michael Paquier @ 2021-08-16 03:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refresh apply delay on reload of recovery_min_apply_delay at recovery This commit ensures that the wait interval in the replay delay loop waiting for an amount of time defined by recovery_min_apply_delay is correctly handled on reload, recalculating the delay if this GUC value is updated, based on the timestamp of the commit record being replayed. The previous behavior would be problematic for example with replay still waiting even if the delay got reduced or just cancelled. If the apply delay was increased to a larger value, the wait would have just respected the old value set, finishing earlier. Author: Soumyadeep Chakraborty, Ashwin Agrawal Reviewed-by: Kyotaro Horiguchi, Michael Paquier Discussion: https://postgr.es/m/CAE-ML+93zfr-HLN8OuxF0BjpWJ17O5dv1eMvSE5jsj9jpnAXZA@mail.gmail.com Backpatch-through: 9.6 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/84c1bac579db605e6a7d7b15f7f641c583d7e6e9 Modified Files -------------- src/backend/access/transam/xlog.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2021-08-16 03:12 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-08-16 03:12 pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec Michael Paquier <michael@paquier.xyz> 2021-08-16 03:12 pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec Michael Paquier <michael@paquier.xyz> 2021-08-16 03:12 pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec Michael Paquier <michael@paquier.xyz> 2021-08-16 03:12 pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec Michael Paquier <michael@paquier.xyz> 2021-08-16 03:12 pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec Michael Paquier <michael@paquier.xyz> 2021-08-16 03:12 pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec Michael Paquier <michael@paquier.xyz> 2021-08-16 03:12 pgsql: Refresh apply delay on reload of recovery_min_apply_delay at rec Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox