pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Count SP-GiST index scans in pg_stat statistics.
7+ messages / 1 participants
[nested] [flat]

* pgsql: Count SP-GiST index scans in pg_stat statistics.
@ 2021-08-27 23:53 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-08-27 23:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Count SP-GiST index scans in pg_stat statistics.

Somehow, spgist overlooked the need to call pgstat_count_index_scan().
Hence, pg_stat_all_indexes.idx_scan and equivalent columns never
became nonzero for an SP-GiST index, although the related per-tuple
counters worked fine.

This fix works a bit differently from other index AMs, in that the
counter increment occurs in spgrescan not spggettuple/spggetbitmap.
It looks like this won't make the user-visible semantics noticeably
different, so I won't go to the trouble of introducing an is-this-
the-first-call flag just to make the counter bumps happen in the
same places.

Per bug #17163 from Christian Quest.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/17163-b8c5cc88322a5e92@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3778bcb39a94a3b6a821fd60fcd9919a95725e78

Modified Files
--------------
src/backend/access/spgist/spgscan.c | 4 ++++
1 file changed, 4 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Count SP-GiST index scans in pg_stat statistics.
@ 2021-08-27 23:53 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-08-27 23:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Count SP-GiST index scans in pg_stat statistics.

Somehow, spgist overlooked the need to call pgstat_count_index_scan().
Hence, pg_stat_all_indexes.idx_scan and equivalent columns never
became nonzero for an SP-GiST index, although the related per-tuple
counters worked fine.

This fix works a bit differently from other index AMs, in that the
counter increment occurs in spgrescan not spggettuple/spggetbitmap.
It looks like this won't make the user-visible semantics noticeably
different, so I won't go to the trouble of introducing an is-this-
the-first-call flag just to make the counter bumps happen in the
same places.

Per bug #17163 from Christian Quest.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/17163-b8c5cc88322a5e92@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e84d4810cd47d83a6a864fa33db74bcc5570dd76

Modified Files
--------------
src/backend/access/spgist/spgscan.c | 4 ++++
1 file changed, 4 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Count SP-GiST index scans in pg_stat statistics.
@ 2021-08-27 23:53 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-08-27 23:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Count SP-GiST index scans in pg_stat statistics.

Somehow, spgist overlooked the need to call pgstat_count_index_scan().
Hence, pg_stat_all_indexes.idx_scan and equivalent columns never
became nonzero for an SP-GiST index, although the related per-tuple
counters worked fine.

This fix works a bit differently from other index AMs, in that the
counter increment occurs in spgrescan not spggettuple/spggetbitmap.
It looks like this won't make the user-visible semantics noticeably
different, so I won't go to the trouble of introducing an is-this-
the-first-call flag just to make the counter bumps happen in the
same places.

Per bug #17163 from Christian Quest.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/17163-b8c5cc88322a5e92@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dbb239d518eef791ec6e8f2180e71078e7f89e38

Modified Files
--------------
src/backend/access/spgist/spgscan.c | 4 ++++
1 file changed, 4 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Count SP-GiST index scans in pg_stat statistics.
@ 2021-08-27 23:53 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-08-27 23:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Count SP-GiST index scans in pg_stat statistics.

Somehow, spgist overlooked the need to call pgstat_count_index_scan().
Hence, pg_stat_all_indexes.idx_scan and equivalent columns never
became nonzero for an SP-GiST index, although the related per-tuple
counters worked fine.

This fix works a bit differently from other index AMs, in that the
counter increment occurs in spgrescan not spggettuple/spggetbitmap.
It looks like this won't make the user-visible semantics noticeably
different, so I won't go to the trouble of introducing an is-this-
the-first-call flag just to make the counter bumps happen in the
same places.

Per bug #17163 from Christian Quest.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/17163-b8c5cc88322a5e92@postgresql.org

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/187b5fea982e6fd56a0311ca9f899f792307e534

Modified Files
--------------
src/backend/access/spgist/spgscan.c | 4 ++++
1 file changed, 4 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Count SP-GiST index scans in pg_stat statistics.
@ 2021-08-27 23:53 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-08-27 23:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Count SP-GiST index scans in pg_stat statistics.

Somehow, spgist overlooked the need to call pgstat_count_index_scan().
Hence, pg_stat_all_indexes.idx_scan and equivalent columns never
became nonzero for an SP-GiST index, although the related per-tuple
counters worked fine.

This fix works a bit differently from other index AMs, in that the
counter increment occurs in spgrescan not spggettuple/spggetbitmap.
It looks like this won't make the user-visible semantics noticeably
different, so I won't go to the trouble of introducing an is-this-
the-first-call flag just to make the counter bumps happen in the
same places.

Per bug #17163 from Christian Quest.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/17163-b8c5cc88322a5e92@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7c1b0f4c35354edf5460cf6e87c63a4a65be1e00

Modified Files
--------------
src/backend/access/spgist/spgscan.c | 4 ++++
1 file changed, 4 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Count SP-GiST index scans in pg_stat statistics.
@ 2021-08-27 23:53 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-08-27 23:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Count SP-GiST index scans in pg_stat statistics.

Somehow, spgist overlooked the need to call pgstat_count_index_scan().
Hence, pg_stat_all_indexes.idx_scan and equivalent columns never
became nonzero for an SP-GiST index, although the related per-tuple
counters worked fine.

This fix works a bit differently from other index AMs, in that the
counter increment occurs in spgrescan not spggettuple/spggetbitmap.
It looks like this won't make the user-visible semantics noticeably
different, so I won't go to the trouble of introducing an is-this-
the-first-call flag just to make the counter bumps happen in the
same places.

Per bug #17163 from Christian Quest.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/17163-b8c5cc88322a5e92@postgresql.org

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6a787c83c48a4d87d5aaa57776015ab77934d0ce

Modified Files
--------------
src/backend/access/spgist/spgscan.c | 4 ++++
1 file changed, 4 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Count SP-GiST index scans in pg_stat statistics.
@ 2021-08-27 23:53 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-08-27 23:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Count SP-GiST index scans in pg_stat statistics.

Somehow, spgist overlooked the need to call pgstat_count_index_scan().
Hence, pg_stat_all_indexes.idx_scan and equivalent columns never
became nonzero for an SP-GiST index, although the related per-tuple
counters worked fine.

This fix works a bit differently from other index AMs, in that the
counter increment occurs in spgrescan not spggettuple/spggetbitmap.
It looks like this won't make the user-visible semantics noticeably
different, so I won't go to the trouble of introducing an is-this-
the-first-call flag just to make the counter bumps happen in the
same places.

Per bug #17163 from Christian Quest.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/17163-b8c5cc88322a5e92@postgresql.org

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9e959f7ed5d5cfcb0852ee56a4c5113a54c52ee1

Modified Files
--------------
src/backend/access/spgist/spgscan.c | 4 ++++
1 file changed, 4 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2021-08-27 23:53 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 23:53 pgsql: Count SP-GiST index scans in pg_stat statistics. Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 23:53 pgsql: Count SP-GiST index scans in pg_stat statistics. Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 23:53 pgsql: Count SP-GiST index scans in pg_stat statistics. Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 23:53 pgsql: Count SP-GiST index scans in pg_stat statistics. Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 23:53 pgsql: Count SP-GiST index scans in pg_stat statistics. Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 23:53 pgsql: Count SP-GiST index scans in pg_stat statistics. Tom Lane <tgl@sss.pgh.pa.us>
2021-08-27 23:53 pgsql: Count SP-GiST index scans in pg_stat statistics. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox