pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: psql: Fix name quoting on extended statistics
2+ messages / 1 participants
[nested] [flat]

* pgsql: psql: Fix name quoting on extended statistics
@ 2021-08-30 18:02 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alvaro Herrera @ 2021-08-30 18:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

psql: Fix name quoting on extended statistics

Per our message style guidelines, for human consumption we quote
qualified names as a whole rather than each part separately; but commits
bc085205c8a4 introduced a deviation for extended statistics and
a4d75c86bf15 copied it.  I don't agree with this policy applying to
names shown by psql, but that's a poor reason to deviate from the
practice only in two obscure corners, so make said corners use the same
style as everywhere else.

Backpatch to 14.  The first of these is older, but I'm not sure we want
to destabilize the psql output in the older branches for such a small
thing.

Discussion: https://postgr.es/m/20210828181618.GS26465@telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a397109114c8569e21ed3c858a16143de28a1897

Modified Files
--------------
src/bin/psql/describe.c                         |  4 ++--
src/test/regress/expected/create_table_like.out | 12 ++++++------
src/test/regress/expected/stats_ext.out         |  6 +++---
3 files changed, 11 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: psql: Fix name quoting on extended statistics
@ 2021-08-30 18:02 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Alvaro Herrera @ 2021-08-30 18:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

psql: Fix name quoting on extended statistics

Per our message style guidelines, for human consumption we quote
qualified names as a whole rather than each part separately; but commits
bc085205c8a4 introduced a deviation for extended statistics and
a4d75c86bf15 copied it.  I don't agree with this policy applying to
names shown by psql, but that's a poor reason to deviate from the
practice only in two obscure corners, so make said corners use the same
style as everywhere else.

Backpatch to 14.  The first of these is older, but I'm not sure we want
to destabilize the psql output in the older branches for such a small
thing.

Discussion: https://postgr.es/m/20210828181618.GS26465@telsasoft.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ce6b662aae7abc8b533b0cfa8fff50a9001508b1

Modified Files
--------------
src/bin/psql/describe.c                         |  4 ++--
src/test/regress/expected/create_table_like.out | 12 ++++++------
src/test/regress/expected/stats_ext.out         |  6 +++---
3 files changed, 11 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2021-08-30 18:02 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-08-30 18:02 pgsql: psql: Fix name quoting on extended statistics Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-08-30 18:02 pgsql: psql: Fix name quoting on extended statistics Alvaro Herrera <alvherre@alvh.no-ip.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox