pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix lookup error in extended stats ownership check 6+ messages / 1 participants [nested] [flat]
* pgsql: Fix lookup error in extended stats ownership check @ 2021-08-31 16:35 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2021-08-31 16:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lookup error in extended stats ownership check When an ownership check on extended statistics object failed, the code was calling aclcheck_error_type to report the failure, which is clearly wrong, resulting in cache lookup errors. Fix by calling aclcheck_error. This issue exists since the introduction of extended statistics, so backpatch all the way back to PostgreSQL 10. It went unnoticed because there were no tests triggering the error, so add one. Reported-by: Mark Dilger Backpatch-through: 10, where extended stats were introduced Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5be8ce82e84f8f3604916c06668990c524f3856d Modified Files -------------- src/backend/catalog/objectaddress.c | 3 ++- src/test/regress/expected/stats_ext.out | 11 +++++++++++ src/test/regress/sql/stats_ext.sql | 9 +++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lookup error in extended stats ownership check @ 2021-08-31 16:37 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2021-08-31 16:37 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lookup error in extended stats ownership check When an ownership check on extended statistics object failed, the code was calling aclcheck_error_type to report the failure, which is clearly wrong, resulting in cache lookup errors. Fix by calling aclcheck_error. This issue exists since the introduction of extended statistics, so backpatch all the way back to PostgreSQL 10. It went unnoticed because there were no tests triggering the error, so add one. Reported-by: Mark Dilger Backpatch-through: 10, where extended stats were introduced Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a371a5ba349d9c39e7754f7d0f195ac46ee87b3f Modified Files -------------- src/backend/catalog/objectaddress.c | 3 ++- src/test/regress/expected/stats_ext.out | 11 +++++++++++ src/test/regress/sql/stats_ext.sql | 9 +++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lookup error in extended stats ownership check @ 2021-08-31 16:39 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2021-08-31 16:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lookup error in extended stats ownership check When an ownership check on extended statistics object failed, the code was calling aclcheck_error_type to report the failure, which is clearly wrong, resulting in cache lookup errors. Fix by calling aclcheck_error. This issue exists since the introduction of extended statistics, so backpatch all the way back to PostgreSQL 10. It went unnoticed because there were no tests triggering the error, so add one. Reported-by: Mark Dilger Backpatch-through: 10, where extended stats were introduced Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1fe1a04af81de4c659ab2a85e578a6bbd4903035 Modified Files -------------- src/backend/catalog/objectaddress.c | 3 ++- src/test/regress/expected/stats_ext.out | 11 +++++++++++ src/test/regress/sql/stats_ext.sql | 9 +++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lookup error in extended stats ownership check @ 2021-08-31 16:41 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2021-08-31 16:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lookup error in extended stats ownership check When an ownership check on extended statistics object failed, the code was calling aclcheck_error_type to report the failure, which is clearly wrong, resulting in cache lookup errors. Fix by calling aclcheck_error. This issue exists since the introduction of extended statistics, so backpatch all the way back to PostgreSQL 10. It went unnoticed because there were no tests triggering the error, so add one. Reported-by: Mark Dilger Backpatch-through: 10, where extended stats were introduced Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/6c8b98669d1479148f02375c68ff17772ce7f95b Modified Files -------------- src/backend/catalog/objectaddress.c | 3 ++- src/test/regress/expected/stats_ext.out | 11 +++++++++++ src/test/regress/sql/stats_ext.sql | 9 +++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lookup error in extended stats ownership check @ 2021-08-31 16:44 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2021-08-31 16:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lookup error in extended stats ownership check When an ownership check on extended statistics object failed, the code was calling aclcheck_error_type to report the failure, which is clearly wrong, resulting in cache lookup errors. Fix by calling aclcheck_error. This issue exists since the introduction of extended statistics, so backpatch all the way back to PostgreSQL 10. It went unnoticed because there were no tests triggering the error, so add one. Reported-by: Mark Dilger Backpatch-through: 10, where extended stats were introduced Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b46ff4b50f449e01fd1646c4a65c182e7519a48b Modified Files -------------- src/backend/catalog/objectaddress.c | 3 ++- src/test/regress/expected/stats_ext.out | 11 +++++++++++ src/test/regress/sql/stats_ext.sql | 9 +++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix lookup error in extended stats ownership check @ 2021-08-31 16:46 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Tomas Vondra @ 2021-08-31 16:46 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix lookup error in extended stats ownership check When an ownership check on extended statistics object failed, the code was calling aclcheck_error_type to report the failure, which is clearly wrong, resulting in cache lookup errors. Fix by calling aclcheck_error. This issue exists since the introduction of extended statistics, so backpatch all the way back to PostgreSQL 10. It went unnoticed because there were no tests triggering the error, so add one. Reported-by: Mark Dilger Backpatch-through: 10, where extended stats were introduced Discussion: https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bfb732c0e849705a04c7c07800edf7f407742f9f Modified Files -------------- src/backend/catalog/objectaddress.c | 3 ++- src/test/regress/expected/stats_ext.out | 11 +++++++++++ src/test/regress/sql/stats_ext.sql | 9 +++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-08-31 16:46 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-08-31 16:35 pgsql: Fix lookup error in extended stats ownership check Tomas Vondra <tomas.vondra@postgresql.org> 2021-08-31 16:37 pgsql: Fix lookup error in extended stats ownership check Tomas Vondra <tomas.vondra@postgresql.org> 2021-08-31 16:39 pgsql: Fix lookup error in extended stats ownership check Tomas Vondra <tomas.vondra@postgresql.org> 2021-08-31 16:41 pgsql: Fix lookup error in extended stats ownership check Tomas Vondra <tomas.vondra@postgresql.org> 2021-08-31 16:44 pgsql: Fix lookup error in extended stats ownership check Tomas Vondra <tomas.vondra@postgresql.org> 2021-08-31 16:46 pgsql: Fix lookup error in extended stats ownership check Tomas Vondra <tomas.vondra@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox