pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Don't print extra parens around expressions in extended stats 2+ messages / 1 participants [nested] [flat]
* pgsql: Don't print extra parens around expressions in extended stats @ 2021-08-31 23:13 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tomas Vondra @ 2021-08-31 23:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't print extra parens around expressions in extended stats The code printing expressions for extended statistics doubled the parens, producing results like ((a+1)), which is unnecessary and not consistent with how we print expressions elsewhere. Fixed by tweaking the code to produce just a single set of parens. Reported by Mark Dilger, fix by me. Backpatch to 14, where support for extended statistics on expressions was added. Reported-by: Mark Dilger Discussion: https://postgr.es/m/20210122040101.GF27167%40telsasoft.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4d1816ec26e877297608a850736afed962527d70 Modified Files -------------- src/backend/utils/adt/ruleutils.c | 2 +- src/bin/pg_dump/t/002_pg_dump.pl | 2 +- src/test/regress/expected/create_table_like.out | 6 +- src/test/regress/expected/stats_ext.out | 110 ++++++++++++------------ 4 files changed, 60 insertions(+), 60 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Don't print extra parens around expressions in extended stats @ 2021-08-31 23:13 Tomas Vondra <tomas.vondra@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tomas Vondra @ 2021-08-31 23:13 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't print extra parens around expressions in extended stats The code printing expressions for extended statistics doubled the parens, producing results like ((a+1)), which is unnecessary and not consistent with how we print expressions elsewhere. Fixed by tweaking the code to produce just a single set of parens. Reported by Mark Dilger, fix by me. Backpatch to 14, where support for extended statistics on expressions was added. Reported-by: Mark Dilger Discussion: https://postgr.es/m/20210122040101.GF27167%40telsasoft.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/13380e1476490932c7b15530ead1f649a16e1125 Modified Files -------------- src/backend/utils/adt/ruleutils.c | 2 +- src/bin/pg_dump/t/002_pg_dump.pl | 2 +- src/test/regress/expected/create_table_like.out | 6 +- src/test/regress/expected/stats_ext.out | 110 ++++++++++++------------ 4 files changed, 60 insertions(+), 60 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-08-31 23:13 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-08-31 23:13 pgsql: Don't print extra parens around expressions in extended stats Tomas Vondra <tomas.vondra@postgresql.org> 2021-08-31 23:13 pgsql: Don't print extra parens around expressions in extended stats Tomas Vondra <tomas.vondra@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox