pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Disallow creating an ICU collation if the DB encoding won't supp 6+ messages / 1 participants [nested] [flat]
* pgsql: Disallow creating an ICU collation if the DB encoding won't supp @ 2021-09-03 20:39 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-09-03 20:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow creating an ICU collation if the DB encoding won't support it. Previously this was allowed, but the collation effectively vanished into the ether because of the way lookup_collation() works: you could not use the collation, nor even drop it. Seems better to give an error up front than to leave the user wondering why it doesn't work. (Because this test is in DefineCollation not CreateCollation, it does not prevent pg_import_system_collations from creating ICU collations, regardless of the initially-chosen encoding.) Per bug #17170 from Andrew Bille. Back-patch to v10 where ICU support was added. Discussion: https://postgr.es/m/17170-95845cf3f0a9c36d@postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/db2760a84191c329c0cdfaa1dae048c32b0c1752 Modified Files -------------- src/backend/commands/collationcmds.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Disallow creating an ICU collation if the DB encoding won't supp @ 2021-09-03 20:39 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-09-03 20:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow creating an ICU collation if the DB encoding won't support it. Previously this was allowed, but the collation effectively vanished into the ether because of the way lookup_collation() works: you could not use the collation, nor even drop it. Seems better to give an error up front than to leave the user wondering why it doesn't work. (Because this test is in DefineCollation not CreateCollation, it does not prevent pg_import_system_collations from creating ICU collations, regardless of the initially-chosen encoding.) Per bug #17170 from Andrew Bille. Back-patch to v10 where ICU support was added. Discussion: https://postgr.es/m/17170-95845cf3f0a9c36d@postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2cc018ba8f80a5236faf2c58dfcd18fee581dbbc Modified Files -------------- src/backend/commands/collationcmds.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Disallow creating an ICU collation if the DB encoding won't supp @ 2021-09-03 20:39 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-09-03 20:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow creating an ICU collation if the DB encoding won't support it. Previously this was allowed, but the collation effectively vanished into the ether because of the way lookup_collation() works: you could not use the collation, nor even drop it. Seems better to give an error up front than to leave the user wondering why it doesn't work. (Because this test is in DefineCollation not CreateCollation, it does not prevent pg_import_system_collations from creating ICU collations, regardless of the initially-chosen encoding.) Per bug #17170 from Andrew Bille. Back-patch to v10 where ICU support was added. Discussion: https://postgr.es/m/17170-95845cf3f0a9c36d@postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/132be60006b334df00093973465215cd8b892f37 Modified Files -------------- src/backend/commands/collationcmds.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Disallow creating an ICU collation if the DB encoding won't supp @ 2021-09-03 20:39 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-09-03 20:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow creating an ICU collation if the DB encoding won't support it. Previously this was allowed, but the collation effectively vanished into the ether because of the way lookup_collation() works: you could not use the collation, nor even drop it. Seems better to give an error up front than to leave the user wondering why it doesn't work. (Because this test is in DefineCollation not CreateCollation, it does not prevent pg_import_system_collations from creating ICU collations, regardless of the initially-chosen encoding.) Per bug #17170 from Andrew Bille. Back-patch to v10 where ICU support was added. Discussion: https://postgr.es/m/17170-95845cf3f0a9c36d@postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9046a05368de54d8b20a79ac3e42b363bac6ff17 Modified Files -------------- src/backend/commands/collationcmds.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Disallow creating an ICU collation if the DB encoding won't supp @ 2021-09-03 20:39 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-09-03 20:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow creating an ICU collation if the DB encoding won't support it. Previously this was allowed, but the collation effectively vanished into the ether because of the way lookup_collation() works: you could not use the collation, nor even drop it. Seems better to give an error up front than to leave the user wondering why it doesn't work. (Because this test is in DefineCollation not CreateCollation, it does not prevent pg_import_system_collations from creating ICU collations, regardless of the initially-chosen encoding.) Per bug #17170 from Andrew Bille. Back-patch to v10 where ICU support was added. Discussion: https://postgr.es/m/17170-95845cf3f0a9c36d@postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9ebe2852e5435d88d5e3d655b05887b66059cc4d Modified Files -------------- src/backend/commands/collationcmds.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Disallow creating an ICU collation if the DB encoding won't supp @ 2021-09-03 20:39 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-09-03 20:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow creating an ICU collation if the DB encoding won't support it. Previously this was allowed, but the collation effectively vanished into the ether because of the way lookup_collation() works: you could not use the collation, nor even drop it. Seems better to give an error up front than to leave the user wondering why it doesn't work. (Because this test is in DefineCollation not CreateCollation, it does not prevent pg_import_system_collations from creating ICU collations, regardless of the initially-chosen encoding.) Per bug #17170 from Andrew Bille. Back-patch to v10 where ICU support was added. Discussion: https://postgr.es/m/17170-95845cf3f0a9c36d@postgresql.org Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5d7c6b6c8b4a9e03a16b5c2f5106e1fc5bff9681 Modified Files -------------- src/backend/commands/collationcmds.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-09-03 20:39 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-03 20:39 pgsql: Disallow creating an ICU collation if the DB encoding won't supp Tom Lane <tgl@sss.pgh.pa.us> 2021-09-03 20:39 pgsql: Disallow creating an ICU collation if the DB encoding won't supp Tom Lane <tgl@sss.pgh.pa.us> 2021-09-03 20:39 pgsql: Disallow creating an ICU collation if the DB encoding won't supp Tom Lane <tgl@sss.pgh.pa.us> 2021-09-03 20:39 pgsql: Disallow creating an ICU collation if the DB encoding won't supp Tom Lane <tgl@sss.pgh.pa.us> 2021-09-03 20:39 pgsql: Disallow creating an ICU collation if the DB encoding won't supp Tom Lane <tgl@sss.pgh.pa.us> 2021-09-03 20:39 pgsql: Disallow creating an ICU collation if the DB encoding won't supp Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox