pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Further portability tweaks for float4/float8 hash functions.
7+ messages / 1 participants
[nested] [flat]

* pgsql: Further portability tweaks for float4/float8 hash functions.
@ 2021-09-04 20:29 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-09-04 20:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further portability tweaks for float4/float8 hash functions.

Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8.  However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases.  As before, back-patch.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b30cc0fd6d5d96c63037824c286cec561e092b6f

Modified Files
--------------
src/backend/access/hash/hashfunc.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Further portability tweaks for float4/float8 hash functions.
@ 2021-09-04 20:29 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-09-04 20:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further portability tweaks for float4/float8 hash functions.

Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8.  However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases.  As before, back-patch.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/718978d9daa7128e0f5e4e06c0fd402cdd63704f

Modified Files
--------------
src/backend/access/hash/hashfunc.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Further portability tweaks for float4/float8 hash functions.
@ 2021-09-04 20:29 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-09-04 20:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further portability tweaks for float4/float8 hash functions.

Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8.  However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases.  As before, back-patch.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2c0dd669c3c909484c24b40a797bd99b352c6f0b

Modified Files
--------------
src/backend/access/hash/hashfunc.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Further portability tweaks for float4/float8 hash functions.
@ 2021-09-04 20:29 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-09-04 20:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further portability tweaks for float4/float8 hash functions.

Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8.  However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases.  As before, back-patch.

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fd295d0c687eb8f2e9ec6d9bb1cedf0cc45e1dd8

Modified Files
--------------
src/backend/access/hash/hashfunc.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Further portability tweaks for float4/float8 hash functions.
@ 2021-09-04 20:29 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-09-04 20:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further portability tweaks for float4/float8 hash functions.

Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8.  However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases.  As before, back-patch.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8782a84529035baca1639c3680458e2062ef9b44

Modified Files
--------------
src/backend/access/hash/hashfunc.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Further portability tweaks for float4/float8 hash functions.
@ 2021-09-04 20:29 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-09-04 20:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further portability tweaks for float4/float8 hash functions.

Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8.  However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases.  As before, back-patch.

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/70354dd560c7cdf4bf32653e9687051bf8abcb0e

Modified Files
--------------
src/backend/access/hash/hashfunc.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* pgsql: Further portability tweaks for float4/float8 hash functions.
@ 2021-09-04 20:29 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2021-09-04 20:29 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Further portability tweaks for float4/float8 hash functions.

Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8.  However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases.  As before, back-patch.

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a5e8f7b3798b6fb9a4f3129a5eab98b7087c8a80

Modified Files
--------------
src/backend/access/hash/hashfunc.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2021-09-04 20:29 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-09-04 20:29 pgsql: Further portability tweaks for float4/float8 hash functions. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-04 20:29 pgsql: Further portability tweaks for float4/float8 hash functions. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-04 20:29 pgsql: Further portability tweaks for float4/float8 hash functions. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-04 20:29 pgsql: Further portability tweaks for float4/float8 hash functions. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-04 20:29 pgsql: Further portability tweaks for float4/float8 hash functions. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-04 20:29 pgsql: Further portability tweaks for float4/float8 hash functions. Tom Lane <tgl@sss.pgh.pa.us>
2021-09-04 20:29 pgsql: Further portability tweaks for float4/float8 hash functions. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox