pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix issue with WAL archiving in standby. 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix issue with WAL archiving in standby. @ 2021-09-09 15:00 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2021-09-09 15:00 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue with WAL archiving in standby. Previously, walreceiver always closed the currently-opened WAL segment and created its archive notification file, after it finished writing the current segment up and received any WAL data that should be written into the next segment. If walreceiver exited just before any WAL data in the next segment arrived at standby, it did not create the archive notification file of the current segment even though that's known completed. This behavior could cause WAL archiving of the segment to be delayed until subsequent restartpoints or checkpoints created its notification file. To fix the issue, this commit changes walreceiver so that it creates an archive notification file of a current WAL segment immediately if that's known completed before receiving next WAL data. Back-patch to all supported branches. Reported-by: Kyotaro Horiguchi Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/20200630.165503.1465894182551545886.horikyota.ntt@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/596ba75cb11173a528c6b6ec0142a282e42b69ec Modified Files -------------- src/backend/replication/walreceiver.c | 96 ++++++++++++++++++++++------------- 1 file changed, 61 insertions(+), 35 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix issue with WAL archiving in standby. @ 2021-09-09 15:01 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2021-09-09 15:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue with WAL archiving in standby. Previously, walreceiver always closed the currently-opened WAL segment and created its archive notification file, after it finished writing the current segment up and received any WAL data that should be written into the next segment. If walreceiver exited just before any WAL data in the next segment arrived at standby, it did not create the archive notification file of the current segment even though that's known completed. This behavior could cause WAL archiving of the segment to be delayed until subsequent restartpoints or checkpoints created its notification file. To fix the issue, this commit changes walreceiver so that it creates an archive notification file of a current WAL segment immediately if that's known completed before receiving next WAL data. Back-patch to all supported branches. Reported-by: Kyotaro Horiguchi Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/20200630.165503.1465894182551545886.horikyota.ntt@gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b5ec22bf5e8f19964f7c7d7ef357ff947a38c7fc Modified Files -------------- src/backend/replication/walreceiver.c | 99 ++++++++++++++++++++++------------- 1 file changed, 62 insertions(+), 37 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix issue with WAL archiving in standby. @ 2021-09-09 15:01 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2021-09-09 15:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue with WAL archiving in standby. Previously, walreceiver always closed the currently-opened WAL segment and created its archive notification file, after it finished writing the current segment up and received any WAL data that should be written into the next segment. If walreceiver exited just before any WAL data in the next segment arrived at standby, it did not create the archive notification file of the current segment even though that's known completed. This behavior could cause WAL archiving of the segment to be delayed until subsequent restartpoints or checkpoints created its notification file. To fix the issue, this commit changes walreceiver so that it creates an archive notification file of a current WAL segment immediately if that's known completed before receiving next WAL data. Back-patch to all supported branches. Reported-by: Kyotaro Horiguchi Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/20200630.165503.1465894182551545886.horikyota.ntt@gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dd9b3fced83edb51a3e2f44d3d4476a45d0f5a24 Modified Files -------------- src/backend/replication/walreceiver.c | 99 ++++++++++++++++++++++------------- 1 file changed, 62 insertions(+), 37 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix issue with WAL archiving in standby. @ 2021-09-09 15:01 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2021-09-09 15:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue with WAL archiving in standby. Previously, walreceiver always closed the currently-opened WAL segment and created its archive notification file, after it finished writing the current segment up and received any WAL data that should be written into the next segment. If walreceiver exited just before any WAL data in the next segment arrived at standby, it did not create the archive notification file of the current segment even though that's known completed. This behavior could cause WAL archiving of the segment to be delayed until subsequent restartpoints or checkpoints created its notification file. To fix the issue, this commit changes walreceiver so that it creates an archive notification file of a current WAL segment immediately if that's known completed before receiving next WAL data. Back-patch to all supported branches. Reported-by: Kyotaro Horiguchi Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/20200630.165503.1465894182551545886.horikyota.ntt@gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4665352543d73a182a8fe638065430ef7db8b2b9 Modified Files -------------- src/backend/replication/walreceiver.c | 98 ++++++++++++++++++++++------------- 1 file changed, 62 insertions(+), 36 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix issue with WAL archiving in standby. @ 2021-09-09 15:01 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2021-09-09 15:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue with WAL archiving in standby. Previously, walreceiver always closed the currently-opened WAL segment and created its archive notification file, after it finished writing the current segment up and received any WAL data that should be written into the next segment. If walreceiver exited just before any WAL data in the next segment arrived at standby, it did not create the archive notification file of the current segment even though that's known completed. This behavior could cause WAL archiving of the segment to be delayed until subsequent restartpoints or checkpoints created its notification file. To fix the issue, this commit changes walreceiver so that it creates an archive notification file of a current WAL segment immediately if that's known completed before receiving next WAL data. Back-patch to all supported branches. Reported-by: Kyotaro Horiguchi Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/20200630.165503.1465894182551545886.horikyota.ntt@gmail.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/aacb3cfaf5e8b69da19446ad6a8e7ce426edb898 Modified Files -------------- src/backend/replication/walreceiver.c | 98 ++++++++++++++++++++++------------- 1 file changed, 62 insertions(+), 36 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix issue with WAL archiving in standby. @ 2021-09-09 15:02 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2021-09-09 15:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue with WAL archiving in standby. Previously, walreceiver always closed the currently-opened WAL segment and created its archive notification file, after it finished writing the current segment up and received any WAL data that should be written into the next segment. If walreceiver exited just before any WAL data in the next segment arrived at standby, it did not create the archive notification file of the current segment even though that's known completed. This behavior could cause WAL archiving of the segment to be delayed until subsequent restartpoints or checkpoints created its notification file. To fix the issue, this commit changes walreceiver so that it creates an archive notification file of a current WAL segment immediately if that's known completed before receiving next WAL data. Back-patch to all supported branches. Reported-by: Kyotaro Horiguchi Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/20200630.165503.1465894182551545886.horikyota.ntt@gmail.com Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f77489046d172b3111d4d588479fc4e7444ec36b Modified Files -------------- src/backend/replication/walreceiver.c | 98 ++++++++++++++++++++++------------- 1 file changed, 62 insertions(+), 36 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix issue with WAL archiving in standby. @ 2021-09-09 15:02 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2021-09-09 15:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix issue with WAL archiving in standby. Previously, walreceiver always closed the currently-opened WAL segment and created its archive notification file, after it finished writing the current segment up and received any WAL data that should be written into the next segment. If walreceiver exited just before any WAL data in the next segment arrived at standby, it did not create the archive notification file of the current segment even though that's known completed. This behavior could cause WAL archiving of the segment to be delayed until subsequent restartpoints or checkpoints created its notification file. To fix the issue, this commit changes walreceiver so that it creates an archive notification file of a current WAL segment immediately if that's known completed before receiving next WAL data. Back-patch to all supported branches. Reported-by: Kyotaro Horiguchi Author: Fujii Masao Reviewed-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/20200630.165503.1465894182551545886.horikyota.ntt@gmail.com Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/61e2aa2dbe55f138b6eea922687747416a4b4f67 Modified Files -------------- src/backend/replication/walreceiver.c | 98 ++++++++++++++++++++++------------- 1 file changed, 62 insertions(+), 36 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2021-09-09 15:02 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-09 15:00 pgsql: Fix issue with WAL archiving in standby. Fujii Masao <fujii@postgresql.org> 2021-09-09 15:01 pgsql: Fix issue with WAL archiving in standby. Fujii Masao <fujii@postgresql.org> 2021-09-09 15:01 pgsql: Fix issue with WAL archiving in standby. Fujii Masao <fujii@postgresql.org> 2021-09-09 15:01 pgsql: Fix issue with WAL archiving in standby. Fujii Masao <fujii@postgresql.org> 2021-09-09 15:01 pgsql: Fix issue with WAL archiving in standby. Fujii Masao <fujii@postgresql.org> 2021-09-09 15:02 pgsql: Fix issue with WAL archiving in standby. Fujii Masao <fujii@postgresql.org> 2021-09-09 15:02 pgsql: Fix issue with WAL archiving in standby. Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox