pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Avoid fetching from an already-terminated plan. 5+ messages / 1 participants [nested] [flat]
* pgsql: Avoid fetching from an already-terminated plan. @ 2021-09-09 17:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2021-09-09 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid fetching from an already-terminated plan. Some plan node types don't react well to being called again after they've already returned NULL. PortalRunSelect() has long dealt with this by calling the executor with NoMovementScanDirection if it sees that we've already run the portal to the end. However, commit ba2c6d6ce overlooked this point, so that persisting an already-fully-fetched cursor would fail if it had such a plan. Per report from Tomas Barton. Back-patch to v11, as the faulty commit was. (I've omitted a test case because the type of plan that causes a problem isn't all that stable.) Discussion: https://postgr.es/m/CAPV2KRjd=ErgVGbvO2Ty20tKTEZZr6cYsYLxgN_W3eAo9pf5sw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cba79a163267a44205e391137deb543f4f89bc8b Modified Files -------------- src/backend/commands/portalcmds.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Avoid fetching from an already-terminated plan. @ 2021-09-09 17:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2021-09-09 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid fetching from an already-terminated plan. Some plan node types don't react well to being called again after they've already returned NULL. PortalRunSelect() has long dealt with this by calling the executor with NoMovementScanDirection if it sees that we've already run the portal to the end. However, commit ba2c6d6ce overlooked this point, so that persisting an already-fully-fetched cursor would fail if it had such a plan. Per report from Tomas Barton. Back-patch to v11, as the faulty commit was. (I've omitted a test case because the type of plan that causes a problem isn't all that stable.) Discussion: https://postgr.es/m/CAPV2KRjd=ErgVGbvO2Ty20tKTEZZr6cYsYLxgN_W3eAo9pf5sw@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b7056c0a25e545f4c1efcc1e2a6118e4626e377b Modified Files -------------- src/backend/commands/portalcmds.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Avoid fetching from an already-terminated plan. @ 2021-09-09 17:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2021-09-09 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid fetching from an already-terminated plan. Some plan node types don't react well to being called again after they've already returned NULL. PortalRunSelect() has long dealt with this by calling the executor with NoMovementScanDirection if it sees that we've already run the portal to the end. However, commit ba2c6d6ce overlooked this point, so that persisting an already-fully-fetched cursor would fail if it had such a plan. Per report from Tomas Barton. Back-patch to v11, as the faulty commit was. (I've omitted a test case because the type of plan that causes a problem isn't all that stable.) Discussion: https://postgr.es/m/CAPV2KRjd=ErgVGbvO2Ty20tKTEZZr6cYsYLxgN_W3eAo9pf5sw@mail.gmail.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d8d93bc8baa934fb23c90271d200e061386b546d Modified Files -------------- src/backend/commands/portalcmds.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Avoid fetching from an already-terminated plan. @ 2021-09-09 17:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2021-09-09 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid fetching from an already-terminated plan. Some plan node types don't react well to being called again after they've already returned NULL. PortalRunSelect() has long dealt with this by calling the executor with NoMovementScanDirection if it sees that we've already run the portal to the end. However, commit ba2c6d6ce overlooked this point, so that persisting an already-fully-fetched cursor would fail if it had such a plan. Per report from Tomas Barton. Back-patch to v11, as the faulty commit was. (I've omitted a test case because the type of plan that causes a problem isn't all that stable.) Discussion: https://postgr.es/m/CAPV2KRjd=ErgVGbvO2Ty20tKTEZZr6cYsYLxgN_W3eAo9pf5sw@mail.gmail.com Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2e75e969c88f51a2dd571540252f6423c936d49c Modified Files -------------- src/backend/commands/portalcmds.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Avoid fetching from an already-terminated plan. @ 2021-09-09 17:36 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2021-09-09 17:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid fetching from an already-terminated plan. Some plan node types don't react well to being called again after they've already returned NULL. PortalRunSelect() has long dealt with this by calling the executor with NoMovementScanDirection if it sees that we've already run the portal to the end. However, commit ba2c6d6ce overlooked this point, so that persisting an already-fully-fetched cursor would fail if it had such a plan. Per report from Tomas Barton. Back-patch to v11, as the faulty commit was. (I've omitted a test case because the type of plan that causes a problem isn't all that stable.) Discussion: https://postgr.es/m/CAPV2KRjd=ErgVGbvO2Ty20tKTEZZr6cYsYLxgN_W3eAo9pf5sw@mail.gmail.com Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7813451c20c3b341c8af542d80bb941c9c893825 Modified Files -------------- src/backend/commands/portalcmds.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2021-09-09 17:36 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-09 17:36 pgsql: Avoid fetching from an already-terminated plan. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-09 17:36 pgsql: Avoid fetching from an already-terminated plan. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-09 17:36 pgsql: Avoid fetching from an already-terminated plan. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-09 17:36 pgsql: Avoid fetching from an already-terminated plan. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-09 17:36 pgsql: Avoid fetching from an already-terminated plan. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox