pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Disallow LISTEN in background workers. 3+ messages / 1 participants [nested] [flat]
* pgsql: Disallow LISTEN in background workers. @ 2021-09-15 16:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2021-09-15 16:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow LISTEN in background workers. It's possible to execute user-defined SQL in some background processes; for example, logical replication workers can fire triggers. This opens the possibility that someone would try to execute LISTEN in such a context. But since only regular backends ever call ProcessNotifyInterrupt, no messages would actually be received, and thus the registered listener would simply prevent the message queue from being cleaned. Eventually NOTIFY would stop working, which is bad. Perhaps someday somebody will invent infrastructure to make listening in a background worker actually useful. In the meantime, forbid it. Back-patch to v13, which is where we introduced the MyBackendType variable. It'd be a lot harder to implement the check without that, and it doesn't seem worth the trouble. Discussion: https://postgr.es/m/153243441449.1404.2274116228506175596@wrigleys.postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1316be28664f1834ac091113217537101331bdf3 Modified Files -------------- src/backend/tcop/utility.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Disallow LISTEN in background workers. @ 2021-09-15 16:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2021-09-15 16:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow LISTEN in background workers. It's possible to execute user-defined SQL in some background processes; for example, logical replication workers can fire triggers. This opens the possibility that someone would try to execute LISTEN in such a context. But since only regular backends ever call ProcessNotifyInterrupt, no messages would actually be received, and thus the registered listener would simply prevent the message queue from being cleaned. Eventually NOTIFY would stop working, which is bad. Perhaps someday somebody will invent infrastructure to make listening in a background worker actually useful. In the meantime, forbid it. Back-patch to v13, which is where we introduced the MyBackendType variable. It'd be a lot harder to implement the check without that, and it doesn't seem worth the trouble. Discussion: https://postgr.es/m/153243441449.1404.2274116228506175596@wrigleys.postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d84d62b6225b4af86cd9837b71f6fd2cf33fe80c Modified Files -------------- src/backend/tcop/utility.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Disallow LISTEN in background workers. @ 2021-09-15 16:32 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2021-09-15 16:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Disallow LISTEN in background workers. It's possible to execute user-defined SQL in some background processes; for example, logical replication workers can fire triggers. This opens the possibility that someone would try to execute LISTEN in such a context. But since only regular backends ever call ProcessNotifyInterrupt, no messages would actually be received, and thus the registered listener would simply prevent the message queue from being cleaned. Eventually NOTIFY would stop working, which is bad. Perhaps someday somebody will invent infrastructure to make listening in a background worker actually useful. In the meantime, forbid it. Back-patch to v13, which is where we introduced the MyBackendType variable. It'd be a lot harder to implement the check without that, and it doesn't seem worth the trouble. Discussion: https://postgr.es/m/153243441449.1404.2274116228506175596@wrigleys.postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e06cc024bd3372cb4280246e114d7508e3e2c20a Modified Files -------------- src/backend/tcop/utility.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-09-15 16:32 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-15 16:32 pgsql: Disallow LISTEN in background workers. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-15 16:32 pgsql: Disallow LISTEN in background workers. Tom Lane <tgl@sss.pgh.pa.us> 2021-09-15 16:32 pgsql: Disallow LISTEN in background workers. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox