pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix "single value strategy" index deletion issue. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix "single value strategy" index deletion issue. @ 2021-09-22 02:01 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 2+ messages in thread From: Peter Geoghegan @ 2021-09-22 02:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix "single value strategy" index deletion issue. It is not appropriate for deduplication to apply single value strategy when triggered by a bottom-up index deletion pass. This wastes cycles because later bottom-up deletion passes will overinterpret older duplicate tuples that deduplication actually just skipped over "by design". It also makes bottom-up deletion much less effective for low cardinality indexes that happen to cross a meaningless "index has single key value per leaf page" threshold. To fix, slightly narrow the conditions under which deduplication's single value strategy is considered. We already avoided the strategy for a unique index, since our high level goal must just be to buy time for VACUUM to run (not to buy space). We'll now also avoid it when we just had a bottom-up pass that reported failure. The two cases share the same high level goal, and already overlapped significantly, so this approach is quite natural. Oversight in commit d168b666, which added bottom-up index deletion. Author: Peter Geoghegan <pg@bowt.ie> Discussion: https://postgr.es/m/CAH2-WznaOvM+Gyj-JQ0X=JxoMDxctDTYjiEuETdAGbF5EUc3MA@mail.gmail.com Backpatch: 14-, where bottom-up deletion was introduced. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/dd94c2852e6e3a246b9fd64bf2d9c7fc01020905 Modified Files -------------- src/backend/access/nbtree/nbtdedup.c | 36 +++++++++++++++++------------------ src/backend/access/nbtree/nbtinsert.c | 2 +- src/include/access/nbtree.h | 2 +- 3 files changed, 19 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix "single value strategy" index deletion issue. @ 2021-09-22 02:01 Peter Geoghegan <pg@bowt.ie> 0 siblings, 0 replies; 2+ messages in thread From: Peter Geoghegan @ 2021-09-22 02:01 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix "single value strategy" index deletion issue. It is not appropriate for deduplication to apply single value strategy when triggered by a bottom-up index deletion pass. This wastes cycles because later bottom-up deletion passes will overinterpret older duplicate tuples that deduplication actually just skipped over "by design". It also makes bottom-up deletion much less effective for low cardinality indexes that happen to cross a meaningless "index has single key value per leaf page" threshold. To fix, slightly narrow the conditions under which deduplication's single value strategy is considered. We already avoided the strategy for a unique index, since our high level goal must just be to buy time for VACUUM to run (not to buy space). We'll now also avoid it when we just had a bottom-up pass that reported failure. The two cases share the same high level goal, and already overlapped significantly, so this approach is quite natural. Oversight in commit d168b666, which added bottom-up index deletion. Author: Peter Geoghegan <pg@bowt.ie> Discussion: https://postgr.es/m/CAH2-WznaOvM+Gyj-JQ0X=JxoMDxctDTYjiEuETdAGbF5EUc3MA@mail.gmail.com Backpatch: 14-, where bottom-up deletion was introduced. Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e665129c4727004e7a7c12c86d077abc750b3307 Modified Files -------------- src/backend/access/nbtree/nbtdedup.c | 36 +++++++++++++++++------------------ src/backend/access/nbtree/nbtinsert.c | 2 +- src/include/access/nbtree.h | 2 +- 3 files changed, 19 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-09-22 02:01 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-22 02:01 pgsql: Fix "single value strategy" index deletion issue. Peter Geoghegan <pg@bowt.ie> 2021-09-22 02:01 pgsql: Fix "single value strategy" index deletion issue. Peter Geoghegan <pg@bowt.ie>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox