pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Invalidate all partitions for a partitioned table in publication 3+ messages / 1 participants [nested] [flat]
* pgsql: Invalidate all partitions for a partitioned table in publication @ 2021-09-22 03:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2021-09-22 03:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate all partitions for a partitioned table in publication. Updates/Deletes on a partition were allowed even without replica identity after the parent table was added to a publication. This would later lead to an error on subscribers. The reason was that we were not invalidating the partition's relcache and the publication information for partitions was not getting rebuilt. Similarly, we were not invalidating the partitions' relcache after dropping a partitioned table from a publication which will prohibit Updates/Deletes on its partition without replica identity even without any publication. Reported-by: Haiying Tang Author: Hou Zhijie and Vignesh C Reviewed-by: Vignesh C and Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/OS0PR01MB6113D77F583C922F1CEAA1C3FBD29@OS0PR01MB6113.jpnprd01.prod.outlook.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4548c76738b368a11a5dad052f9653a349eeb52c Modified Files -------------- src/backend/catalog/pg_publication.c | 82 ++++++++++++++++++++----------- src/backend/commands/publicationcmds.c | 57 ++++++++++++--------- src/include/catalog/pg_publication.h | 3 ++ src/include/commands/publicationcmds.h | 5 ++ src/test/regress/expected/publication.out | 13 ++++- src/test/regress/sql/publication.sql | 11 ++++- 6 files changed, 116 insertions(+), 55 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Invalidate all partitions for a partitioned table in publication @ 2021-09-22 03:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2021-09-22 03:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate all partitions for a partitioned table in publication. Updates/Deletes on a partition were allowed even without replica identity after the parent table was added to a publication. This would later lead to an error on subscribers. The reason was that we were not invalidating the partition's relcache and the publication information for partitions was not getting rebuilt. Similarly, we were not invalidating the partitions' relcache after dropping a partitioned table from a publication which will prohibit Updates/Deletes on its partition without replica identity even without any publication. Reported-by: Haiying Tang Author: Hou Zhijie and Vignesh C Reviewed-by: Vignesh C and Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/OS0PR01MB6113D77F583C922F1CEAA1C3FBD29@OS0PR01MB6113.jpnprd01.prod.outlook.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9eff8593265929d3a1fcdee375bd0a801c12b367 Modified Files -------------- src/backend/catalog/pg_publication.c | 82 ++++++++++++++++++++----------- src/backend/commands/publicationcmds.c | 57 ++++++++++++--------- src/include/catalog/pg_publication.h | 3 ++ src/include/commands/publicationcmds.h | 5 ++ src/test/regress/expected/publication.out | 13 ++++- src/test/regress/sql/publication.sql | 11 ++++- 6 files changed, 116 insertions(+), 55 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Invalidate all partitions for a partitioned table in publication @ 2021-09-22 03:03 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2021-09-22 03:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Invalidate all partitions for a partitioned table in publication. Updates/Deletes on a partition were allowed even without replica identity after the parent table was added to a publication. This would later lead to an error on subscribers. The reason was that we were not invalidating the partition's relcache and the publication information for partitions was not getting rebuilt. Similarly, we were not invalidating the partitions' relcache after dropping a partitioned table from a publication which will prohibit Updates/Deletes on its partition without replica identity even without any publication. Reported-by: Haiying Tang Author: Hou Zhijie and Vignesh C Reviewed-by: Vignesh C and Amit Kapila Backpatch-through: 13 Discussion: https://postgr.es/m/OS0PR01MB6113D77F583C922F1CEAA1C3FBD29@OS0PR01MB6113.jpnprd01.prod.outlook.com Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f09a81f1c08fa5c2fed12bed88d53a11a72ff993 Modified Files -------------- src/backend/catalog/pg_publication.c | 82 ++++++++++++++++++++----------- src/backend/commands/publicationcmds.c | 57 ++++++++++++--------- src/include/catalog/pg_publication.h | 3 ++ src/include/commands/publicationcmds.h | 5 ++ src/test/regress/expected/publication.out | 13 ++++- src/test/regress/sql/publication.sql | 11 ++++- 6 files changed, 116 insertions(+), 55 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-09-22 03:03 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-09-22 03:03 pgsql: Invalidate all partitions for a partitioned table in publication Amit Kapila <akapila@postgresql.org> 2021-09-22 03:03 pgsql: Invalidate all partitions for a partitioned table in publication Amit Kapila <akapila@postgresql.org> 2021-09-22 03:03 pgsql: Invalidate all partitions for a partitioned table in publication Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox